diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2006-07-01 07:35:45 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-07-01 12:55:57 -0400 |
commit | e8c4b9d003e72199a705fb5a40fcd2487fa16933 (patch) | |
tree | e1bad5c0ba134e55c1e22921a96eabf348c305c0 | |
parent | 17311c03c3e2c16d64d9e8cb2a3f45be2e2f8d3b (diff) |
[PATCH] IRQ: warning message cleanup
Make warnings more consistent.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | kernel/irq/manage.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index e3a122931e1a..fcce5181e453 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
@@ -114,7 +114,7 @@ void enable_irq(unsigned int irq) | |||
114 | spin_lock_irqsave(&desc->lock, flags); | 114 | spin_lock_irqsave(&desc->lock, flags); |
115 | switch (desc->depth) { | 115 | switch (desc->depth) { |
116 | case 0: | 116 | case 0: |
117 | printk(KERN_WARNING "Unablanced enable_irq(%d)\n", irq); | 117 | printk(KERN_WARNING "Unbalanced enable for IRQ %d\n", irq); |
118 | WARN_ON(1); | 118 | WARN_ON(1); |
119 | break; | 119 | break; |
120 | case 1: { | 120 | case 1: { |
@@ -267,9 +267,10 @@ int setup_irq(unsigned int irq, struct irqaction *new) | |||
267 | * SA_TRIGGER_* but the PIC does not support | 267 | * SA_TRIGGER_* but the PIC does not support |
268 | * multiple flow-types? | 268 | * multiple flow-types? |
269 | */ | 269 | */ |
270 | printk(KERN_WARNING "setup_irq(%d) SA_TRIGGER" | 270 | printk(KERN_WARNING "No SA_TRIGGER set_type " |
271 | "set. No set_type function available\n", | 271 | "function for IRQ %d (%s)\n", irq, |
272 | irq); | 272 | desc->chip ? desc->chip->name : |
273 | "unknown"); | ||
273 | } else | 274 | } else |
274 | compat_irq_chip_set_default_handler(desc); | 275 | compat_irq_chip_set_default_handler(desc); |
275 | 276 | ||
@@ -299,7 +300,7 @@ int setup_irq(unsigned int irq, struct irqaction *new) | |||
299 | mismatch: | 300 | mismatch: |
300 | spin_unlock_irqrestore(&desc->lock, flags); | 301 | spin_unlock_irqrestore(&desc->lock, flags); |
301 | if (!(new->flags & SA_PROBEIRQ)) { | 302 | if (!(new->flags & SA_PROBEIRQ)) { |
302 | printk(KERN_ERR "%s: irq handler mismatch\n", __FUNCTION__); | 303 | printk(KERN_ERR "IRQ handler type mismatch for IRQ %d\n", irq); |
303 | dump_stack(); | 304 | dump_stack(); |
304 | } | 305 | } |
305 | return -EBUSY; | 306 | return -EBUSY; |
@@ -366,7 +367,7 @@ void free_irq(unsigned int irq, void *dev_id) | |||
366 | kfree(action); | 367 | kfree(action); |
367 | return; | 368 | return; |
368 | } | 369 | } |
369 | printk(KERN_ERR "Trying to free free IRQ%d\n", irq); | 370 | printk(KERN_ERR "Trying to free already-free IRQ %d\n", irq); |
370 | spin_unlock_irqrestore(&desc->lock, flags); | 371 | spin_unlock_irqrestore(&desc->lock, flags); |
371 | return; | 372 | return; |
372 | } | 373 | } |