diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-01-15 06:28:43 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:02:43 -0500 |
commit | ca629f2472762088b105cd6081bf9aaa56d4547d (patch) | |
tree | a6988addf385478b33a804d3cb350f972d7c66f1 | |
parent | c71e9167081a6a0d2a076cda674b696b89bb31c2 (diff) |
[APPLETALK]: Annotations to clear sparse warnings
CHECK net/appletalk/aarp.c
net/appletalk/aarp.c:951:14: warning: context imbalance in 'aarp_seq_start' - wrong count at exit
net/appletalk/aarp.c:977:13: warning: context imbalance in 'aarp_seq_stop' - unexpected unlock
CHECK net/appletalk/atalk_proc.c
net/appletalk/atalk_proc.c:34:11: warning: context imbalance in 'atalk_seq_interface_start' - wrong count at exit
net/appletalk/atalk_proc.c:54:13: warning: context imbalance in 'atalk_seq_interface_stop' - unexpected unlock
net/appletalk/atalk_proc.c:93:11: warning: context imbalance in 'atalk_seq_route_start' - wrong count at exit
net/appletalk/atalk_proc.c:113:13: warning: context imbalance in 'atalk_seq_route_stop' - unexpected unlock
net/appletalk/atalk_proc.c:161:11: warning: context imbalance in 'atalk_seq_socket_start' - wrong count at exit
net/appletalk/atalk_proc.c:178:13: warning: context imbalance in 'atalk_seq_socket_stop' - unexpected unlock
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/appletalk/aarp.c | 2 | ||||
-rw-r--r-- | net/appletalk/atalk_proc.c | 6 |
2 files changed, 8 insertions, 0 deletions
diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c index b950fb6bd2bf..18058bbc7962 100644 --- a/net/appletalk/aarp.c +++ b/net/appletalk/aarp.c | |||
@@ -941,6 +941,7 @@ static struct aarp_entry *iter_next(struct aarp_iter_state *iter, loff_t *pos) | |||
941 | } | 941 | } |
942 | 942 | ||
943 | static void *aarp_seq_start(struct seq_file *seq, loff_t *pos) | 943 | static void *aarp_seq_start(struct seq_file *seq, loff_t *pos) |
944 | __acquires(aarp_lock) | ||
944 | { | 945 | { |
945 | struct aarp_iter_state *iter = seq->private; | 946 | struct aarp_iter_state *iter = seq->private; |
946 | 947 | ||
@@ -975,6 +976,7 @@ static void *aarp_seq_next(struct seq_file *seq, void *v, loff_t *pos) | |||
975 | } | 976 | } |
976 | 977 | ||
977 | static void aarp_seq_stop(struct seq_file *seq, void *v) | 978 | static void aarp_seq_stop(struct seq_file *seq, void *v) |
979 | __releases(aarp_lock) | ||
978 | { | 980 | { |
979 | read_unlock_bh(&aarp_lock); | 981 | read_unlock_bh(&aarp_lock); |
980 | } | 982 | } |
diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c index 05d9652afcb6..8e8dcfd532db 100644 --- a/net/appletalk/atalk_proc.c +++ b/net/appletalk/atalk_proc.c | |||
@@ -27,6 +27,7 @@ static __inline__ struct atalk_iface *atalk_get_interface_idx(loff_t pos) | |||
27 | } | 27 | } |
28 | 28 | ||
29 | static void *atalk_seq_interface_start(struct seq_file *seq, loff_t *pos) | 29 | static void *atalk_seq_interface_start(struct seq_file *seq, loff_t *pos) |
30 | __acquires(atalk_interfaces_lock) | ||
30 | { | 31 | { |
31 | loff_t l = *pos; | 32 | loff_t l = *pos; |
32 | 33 | ||
@@ -52,6 +53,7 @@ out: | |||
52 | } | 53 | } |
53 | 54 | ||
54 | static void atalk_seq_interface_stop(struct seq_file *seq, void *v) | 55 | static void atalk_seq_interface_stop(struct seq_file *seq, void *v) |
56 | __releases(atalk_interfaces_lock) | ||
55 | { | 57 | { |
56 | read_unlock_bh(&atalk_interfaces_lock); | 58 | read_unlock_bh(&atalk_interfaces_lock); |
57 | } | 59 | } |
@@ -86,6 +88,7 @@ static __inline__ struct atalk_route *atalk_get_route_idx(loff_t pos) | |||
86 | } | 88 | } |
87 | 89 | ||
88 | static void *atalk_seq_route_start(struct seq_file *seq, loff_t *pos) | 90 | static void *atalk_seq_route_start(struct seq_file *seq, loff_t *pos) |
91 | __acquires(atalk_routes_lock) | ||
89 | { | 92 | { |
90 | loff_t l = *pos; | 93 | loff_t l = *pos; |
91 | 94 | ||
@@ -111,6 +114,7 @@ out: | |||
111 | } | 114 | } |
112 | 115 | ||
113 | static void atalk_seq_route_stop(struct seq_file *seq, void *v) | 116 | static void atalk_seq_route_stop(struct seq_file *seq, void *v) |
117 | __releases(atalk_routes_lock) | ||
114 | { | 118 | { |
115 | read_unlock_bh(&atalk_routes_lock); | 119 | read_unlock_bh(&atalk_routes_lock); |
116 | } | 120 | } |
@@ -154,6 +158,7 @@ found: | |||
154 | } | 158 | } |
155 | 159 | ||
156 | static void *atalk_seq_socket_start(struct seq_file *seq, loff_t *pos) | 160 | static void *atalk_seq_socket_start(struct seq_file *seq, loff_t *pos) |
161 | __acquires(atalk_sockets_lock) | ||
157 | { | 162 | { |
158 | loff_t l = *pos; | 163 | loff_t l = *pos; |
159 | 164 | ||
@@ -176,6 +181,7 @@ out: | |||
176 | } | 181 | } |
177 | 182 | ||
178 | static void atalk_seq_socket_stop(struct seq_file *seq, void *v) | 183 | static void atalk_seq_socket_stop(struct seq_file *seq, void *v) |
184 | __releases(atalk_sockets_lock) | ||
179 | { | 185 | { |
180 | read_unlock_bh(&atalk_sockets_lock); | 186 | read_unlock_bh(&atalk_sockets_lock); |
181 | } | 187 | } |