diff options
author | Tejun Heo <tj@kernel.org> | 2009-04-22 22:05:18 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2009-04-28 01:37:35 -0400 |
commit | b243ddcbe9be146172baa544dadecebf156eda0e (patch) | |
tree | 20ae5d9460498ae6c53e9e82f1b9d9ed6daffbb3 | |
parent | 2e60e02297cf54e367567f2d85b2ca56b1c4a906 (diff) |
block: move rq->start_time initialization to blk_rq_init()
rq->start_time was initialized in init_request_from_bio() so special
requests didn't have start_time set. This has been okay as start_time
has been used only for fs requests; however, there is no indication of
this actually is the case or not. Set rq->start_time in blk_rq_init()
and guarantee that all initialized rq's have its start_time set. This
improves consistency at virtually no cost and future changes will make
use of the timestamp for !bio requests.
[ Impact: rq->start_time is valid for all requests ]
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | block/blk-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-core.c b/block/blk-core.c index 89cc05d9a7a9..b84250d3019b 100644 --- a/block/blk-core.c +++ b/block/blk-core.c | |||
@@ -134,6 +134,7 @@ void blk_rq_init(struct request_queue *q, struct request *rq) | |||
134 | rq->cmd_len = BLK_MAX_CDB; | 134 | rq->cmd_len = BLK_MAX_CDB; |
135 | rq->tag = -1; | 135 | rq->tag = -1; |
136 | rq->ref_count = 1; | 136 | rq->ref_count = 1; |
137 | rq->start_time = jiffies; | ||
137 | } | 138 | } |
138 | EXPORT_SYMBOL(blk_rq_init); | 139 | EXPORT_SYMBOL(blk_rq_init); |
139 | 140 | ||
@@ -1099,7 +1100,6 @@ void init_request_from_bio(struct request *req, struct bio *bio) | |||
1099 | req->errors = 0; | 1100 | req->errors = 0; |
1100 | req->hard_sector = req->sector = bio->bi_sector; | 1101 | req->hard_sector = req->sector = bio->bi_sector; |
1101 | req->ioprio = bio_prio(bio); | 1102 | req->ioprio = bio_prio(bio); |
1102 | req->start_time = jiffies; | ||
1103 | blk_rq_bio_prep(req->q, req, bio); | 1103 | blk_rq_bio_prep(req->q, req, bio); |
1104 | } | 1104 | } |
1105 | 1105 | ||