diff options
author | David Woodhouse <David.Woodhouse@intel.com> | 2008-09-03 04:49:20 -0400 |
---|---|---|
committer | David Woodhouse <David.Woodhouse@intel.com> | 2008-09-04 04:46:00 -0400 |
commit | aa7a7fb3990ffc74945494cbd2fc6e920825ee2c (patch) | |
tree | 7720faa92d1348b51d6b90af3c948120afb9b4e2 | |
parent | 514fca4373d28522c0709fcdd439fc9e1e257bb6 (diff) |
Define and use PCI_DEVICE_ID_MARVELL_88ALP01_CCIC for CAFÉ camera driver
Also, stop looking at the NAND controller (0x4100) and checking the
device class. For a while during development, all three functions on the
chip had the same ID. We made them fix that fairly promptly, and we can
forget about it now.
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
-rw-r--r-- | drivers/media/video/cafe_ccic.c | 13 | ||||
-rw-r--r-- | include/linux/pci_ids.h | 1 |
2 files changed, 4 insertions, 10 deletions
diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c index c149b7d712e5..ea0db819184c 100644 --- a/drivers/media/video/cafe_ccic.c +++ b/drivers/media/video/cafe_ccic.c | |||
@@ -2091,15 +2091,8 @@ static int cafe_pci_probe(struct pci_dev *pdev, | |||
2091 | const struct pci_device_id *id) | 2091 | const struct pci_device_id *id) |
2092 | { | 2092 | { |
2093 | int ret; | 2093 | int ret; |
2094 | u16 classword; | ||
2095 | struct cafe_camera *cam; | 2094 | struct cafe_camera *cam; |
2096 | /* | 2095 | |
2097 | * Make sure we have a camera here - we'll get calls for | ||
2098 | * the other cafe devices as well. | ||
2099 | */ | ||
2100 | pci_read_config_word(pdev, PCI_CLASS_DEVICE, &classword); | ||
2101 | if (classword != PCI_CLASS_MULTIMEDIA_VIDEO) | ||
2102 | return -ENODEV; | ||
2103 | /* | 2096 | /* |
2104 | * Start putting together one of our big camera structures. | 2097 | * Start putting together one of our big camera structures. |
2105 | */ | 2098 | */ |
@@ -2287,8 +2280,8 @@ static int cafe_pci_resume(struct pci_dev *pdev) | |||
2287 | 2280 | ||
2288 | 2281 | ||
2289 | static struct pci_device_id cafe_ids[] = { | 2282 | static struct pci_device_id cafe_ids[] = { |
2290 | { PCI_DEVICE(0x11ab, 0x4100) }, /* Eventual real ID */ | 2283 | { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, |
2291 | { PCI_DEVICE(0x11ab, 0x4102) }, /* Really eventual real ID */ | 2284 | PCI_DEVICE_ID_MARVELL_88ALP01_CCIC) }, |
2292 | { 0, } | 2285 | { 0, } |
2293 | }; | 2286 | }; |
2294 | 2287 | ||
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index e6240b7cb404..6cf53f49b625 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h | |||
@@ -1523,6 +1523,7 @@ | |||
1523 | #define PCI_DEVICE_ID_MARVELL_MV64460 0x6480 | 1523 | #define PCI_DEVICE_ID_MARVELL_MV64460 0x6480 |
1524 | #define PCI_DEVICE_ID_MARVELL_88ALP01_NAND 0x4100 | 1524 | #define PCI_DEVICE_ID_MARVELL_88ALP01_NAND 0x4100 |
1525 | #define PCI_DEVICE_ID_MARVELL_88ALP01_SD 0x4101 | 1525 | #define PCI_DEVICE_ID_MARVELL_88ALP01_SD 0x4101 |
1526 | #define PCI_DEVICE_ID_MARVELL_88ALP01_CCIC 0x4102 | ||
1526 | 1527 | ||
1527 | #define PCI_VENDOR_ID_V3 0x11b0 | 1528 | #define PCI_VENDOR_ID_V3 0x11b0 |
1528 | #define PCI_DEVICE_ID_V3_V960 0x0001 | 1529 | #define PCI_DEVICE_ID_V3_V960 0x0001 |