diff options
author | Jonathan Brassow <jbrassow@redhat.com> | 2007-10-19 17:47:57 -0400 |
---|---|---|
committer | Alasdair G Kergon <agk@redhat.com> | 2007-10-19 21:01:21 -0400 |
commit | 6b3df0d7a5e85ad2afd3eecc50e2dee59e876ae8 (patch) | |
tree | d20f30d0a40d1162a6cc135dca31403ae38198e5 | |
parent | fe97e2aa0502922488ad62303a19a20c8044ae18 (diff) |
dm log: split suspend
There are now two phases to a suspend in device-mapper -
presuspend and postsuspend. This patch removes the
single 'suspend' in the logging API and replaces it with
'presuspend' and 'postsuspend' functions to align it
better with core device-mapper.
A subsequent patch will make use of 'presuspend'.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
-rw-r--r-- | drivers/md/dm-log.c | 2 | ||||
-rw-r--r-- | drivers/md/dm-log.h | 3 | ||||
-rw-r--r-- | drivers/md/dm-raid1.c | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c index a66428d860fe..072ee4353eab 100644 --- a/drivers/md/dm-log.c +++ b/drivers/md/dm-log.c | |||
@@ -696,7 +696,7 @@ static struct dirty_log_type _disk_type = { | |||
696 | .module = THIS_MODULE, | 696 | .module = THIS_MODULE, |
697 | .ctr = disk_ctr, | 697 | .ctr = disk_ctr, |
698 | .dtr = disk_dtr, | 698 | .dtr = disk_dtr, |
699 | .suspend = disk_flush, | 699 | .postsuspend = disk_flush, |
700 | .resume = disk_resume, | 700 | .resume = disk_resume, |
701 | .get_region_size = core_get_region_size, | 701 | .get_region_size = core_get_region_size, |
702 | .is_clean = core_is_clean, | 702 | .is_clean = core_is_clean, |
diff --git a/drivers/md/dm-log.h b/drivers/md/dm-log.h index 86a301c8daf1..3fae87eb5963 100644 --- a/drivers/md/dm-log.h +++ b/drivers/md/dm-log.h | |||
@@ -32,7 +32,8 @@ struct dirty_log_type { | |||
32 | * There are times when we don't want the log to touch | 32 | * There are times when we don't want the log to touch |
33 | * the disk. | 33 | * the disk. |
34 | */ | 34 | */ |
35 | int (*suspend)(struct dirty_log *log); | 35 | int (*presuspend)(struct dirty_log *log); |
36 | int (*postsuspend)(struct dirty_log *log); | ||
36 | int (*resume)(struct dirty_log *log); | 37 | int (*resume)(struct dirty_log *log); |
37 | 38 | ||
38 | /* | 39 | /* |
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c index 2b2ca371e20b..8aafbb7ec574 100644 --- a/drivers/md/dm-raid1.c +++ b/drivers/md/dm-raid1.c | |||
@@ -1305,7 +1305,7 @@ static void mirror_postsuspend(struct dm_target *ti) | |||
1305 | wait_event(_kmirrord_recovery_stopped, | 1305 | wait_event(_kmirrord_recovery_stopped, |
1306 | !atomic_read(&ms->rh.recovery_in_flight)); | 1306 | !atomic_read(&ms->rh.recovery_in_flight)); |
1307 | 1307 | ||
1308 | if (log->type->suspend && log->type->suspend(log)) | 1308 | if (log->type->postsuspend && log->type->postsuspend(log)) |
1309 | /* FIXME: need better error handling */ | 1309 | /* FIXME: need better error handling */ |
1310 | DMWARN("log suspend failed"); | 1310 | DMWARN("log suspend failed"); |
1311 | } | 1311 | } |