diff options
| author | Jesper Juhl <jesper.juhl@gmail.com> | 2006-04-23 13:59:23 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-04-27 13:28:57 -0400 |
| commit | 67ca0284f69992ad71ac12dc375f2b158d9d703d (patch) | |
| tree | 4c26826c5bb23c651967dcefd8a466adb402314a | |
| parent | 2be4d50295e2b6f62c07b614e1b103e280dddb84 (diff) | |
[PATCH] USB: Resource leak fix for whiteheat driver
We may return from drivers/usb/serial/whiteheat.c::whiteheat_attach()
without freeing `result' if we leave via the no_firmware: label.
Spotted by the coverity checker as #670
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/serial/whiteheat.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c index 557411c6e7c7..f806553cd9a4 100644 --- a/drivers/usb/serial/whiteheat.c +++ b/drivers/usb/serial/whiteheat.c | |||
| @@ -508,6 +508,7 @@ no_firmware: | |||
| 508 | err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description); | 508 | err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description); |
| 509 | err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description); | 509 | err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description); |
| 510 | err("%s: please contact support@connecttech.com\n", serial->type->description); | 510 | err("%s: please contact support@connecttech.com\n", serial->type->description); |
| 511 | kfree(result); | ||
| 511 | return -ENODEV; | 512 | return -ENODEV; |
| 512 | 513 | ||
| 513 | no_command_private: | 514 | no_command_private: |