diff options
author | Dan Carpenter <error27@gmail.com> | 2009-12-28 13:08:39 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-01-18 11:48:14 -0500 |
commit | 5d7ebb9c7a04d29efce1099024944dfd94d9f63c (patch) | |
tree | 55785299094a271f9a8b63ff6b4e46585d6a0521 | |
parent | 0ed8570ef4d51bb46e2028b2e3c3ddd1f860e193 (diff) |
[SCSI] FlashPoint: fix off by one tests
The check on MAX_SCSI_TAR should be >= instead of > or we could go past the
end of the array.
Joe Eykholt aslo correctly points out that the check on MAX_LUN should be
>= as well. That matches with how it is used in the rest of the file.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rw-r--r-- | drivers/scsi/FlashPoint.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c index b898d382b7b0..e40cdfb7541f 100644 --- a/drivers/scsi/FlashPoint.c +++ b/drivers/scsi/FlashPoint.c | |||
@@ -3924,7 +3924,7 @@ static void FPT_sinits(struct sccb *p_sccb, unsigned char p_card) | |||
3924 | { | 3924 | { |
3925 | struct sccb_mgr_tar_info *currTar_Info; | 3925 | struct sccb_mgr_tar_info *currTar_Info; |
3926 | 3926 | ||
3927 | if ((p_sccb->TargID > MAX_SCSI_TAR) || (p_sccb->Lun > MAX_LUN)) { | 3927 | if ((p_sccb->TargID >= MAX_SCSI_TAR) || (p_sccb->Lun >= MAX_LUN)) { |
3928 | return; | 3928 | return; |
3929 | } | 3929 | } |
3930 | currTar_Info = &FPT_sccbMgrTbl[p_card][p_sccb->TargID]; | 3930 | currTar_Info = &FPT_sccbMgrTbl[p_card][p_sccb->TargID]; |