aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormatthieu castet <castet.matthieu@free.fr>2006-04-02 12:45:46 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2006-04-14 14:12:23 -0400
commit4d45e21867bee51e3bb42e95bc2929231d7c8192 (patch)
treea5ff1c57145b09b3e6f22b6db5fb1c94a970dcf5
parent584958c3d2985396bdb6f96ae632971b43f6f984 (diff)
[PATCH] USB: UEAGLE : memory leack fix
this patch fix leak of memory allocated to intr if allocation of sc->urb_int fails. Found by the Coverity checker. Signed-off-by: Duncan Sands <baldrick@free.fr> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/atm/ueagle-atm.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
index 047fb4ea2fa6..b38990adf1cd 100644
--- a/drivers/usb/atm/ueagle-atm.c
+++ b/drivers/usb/atm/ueagle-atm.c
@@ -1376,7 +1376,7 @@ static int uea_boot(struct uea_softc *sc)
1376 if (ret < 0) { 1376 if (ret < 0) {
1377 uea_err(INS_TO_USBDEV(sc), 1377 uea_err(INS_TO_USBDEV(sc),
1378 "urb submition failed with error %d\n", ret); 1378 "urb submition failed with error %d\n", ret);
1379 goto err1; 1379 goto err;
1380 } 1380 }
1381 1381
1382 sc->kthread = kthread_run(uea_kthread, sc, "ueagle-atm"); 1382 sc->kthread = kthread_run(uea_kthread, sc, "ueagle-atm");
@@ -1390,10 +1390,10 @@ static int uea_boot(struct uea_softc *sc)
1390 1390
1391err2: 1391err2:
1392 usb_kill_urb(sc->urb_int); 1392 usb_kill_urb(sc->urb_int);
1393err1:
1394 kfree(intr);
1395err: 1393err:
1396 usb_free_urb(sc->urb_int); 1394 usb_free_urb(sc->urb_int);
1395 sc->urb_int = NULL;
1396 kfree(intr);
1397 uea_leaves(INS_TO_USBDEV(sc)); 1397 uea_leaves(INS_TO_USBDEV(sc));
1398 return -ENOMEM; 1398 return -ENOMEM;
1399} 1399}