diff options
author | Paul Jackson <pj@sgi.com> | 2006-03-31 05:30:50 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-03-31 15:18:55 -0500 |
commit | 4a01c8d5be628ac20cfd432c21808d76be5813e6 (patch) | |
tree | 040ae0d60df3993a752ce852d3e3dc036586b037 | |
parent | 2cf8d82d63807c2c68adf20bb28bf502496186dd (diff) |
[PATCH] cpuset: task_lock comment fix
Fix cpuset comment involving case of a tasks cpuset pointer being NULL.
Thanks to "the_top_cpuset_hack", this code no longer sees NULL task->cpuset
pointers.
Signed-off-by: Paul Jackson <pj@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | kernel/cpuset.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/kernel/cpuset.c b/kernel/cpuset.c index 18aea1bd1284..2523a4b6a8c6 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c | |||
@@ -616,12 +616,10 @@ static void guarantee_online_mems(const struct cpuset *cs, nodemask_t *pmask) | |||
616 | * current->cpuset if a task has its memory placement changed. | 616 | * current->cpuset if a task has its memory placement changed. |
617 | * Do not call this routine if in_interrupt(). | 617 | * Do not call this routine if in_interrupt(). |
618 | * | 618 | * |
619 | * Call without callback_mutex or task_lock() held. May be called | 619 | * Call without callback_mutex or task_lock() held. May be |
620 | * with or without manage_mutex held. Doesn't need task_lock to guard | 620 | * called with or without manage_mutex held. Thanks in part to |
621 | * against another task changing a non-NULL cpuset pointer to NULL, | 621 | * 'the_top_cpuset_hack', the tasks cpuset pointer will never |
622 | * as that is only done by a task on itself, and if the current task | 622 | * be NULL. This routine also might acquire callback_mutex and |
623 | * is here, it is not simultaneously in the exit code NULL'ing its | ||
624 | * cpuset pointer. This routine also might acquire callback_mutex and | ||
625 | * current->mm->mmap_sem during call. | 623 | * current->mm->mmap_sem during call. |
626 | * | 624 | * |
627 | * Reading current->cpuset->mems_generation doesn't need task_lock | 625 | * Reading current->cpuset->mems_generation doesn't need task_lock |