diff options
author | Paul Bolle <pebolle@tiscali.nl> | 2009-03-08 00:23:13 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-03-10 08:22:42 -0400 |
commit | 3f612132c7164d5cc9ed677a2fdf8950222d2170 (patch) | |
tree | 1e8bc23ad60cfb8af6b8e9d33b5fd27cb20a90ac | |
parent | 3c420f27b7b2340a81989c8d9ed619e545dd2ad7 (diff) |
gigaset: return -ENOTTY for unimplemented functions
A number of functions in the usb_gigaset module will return -EINVAL if
CONFIG_GIGASET_UNDOCREQ is not set. Make these return -ENOTTY as it's
more specific and it might make it easier to see (from userspace) why
these functions actually fail.
Impact: some error return codes changed
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/isdn/gigaset/usb-gigaset.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c index fba61f670527..d78385166099 100644 --- a/drivers/isdn/gigaset/usb-gigaset.c +++ b/drivers/isdn/gigaset/usb-gigaset.c | |||
@@ -278,17 +278,17 @@ static int gigaset_set_line_ctrl(struct cardstate *cs, unsigned cflag) | |||
278 | static int gigaset_set_modem_ctrl(struct cardstate *cs, unsigned old_state, | 278 | static int gigaset_set_modem_ctrl(struct cardstate *cs, unsigned old_state, |
279 | unsigned new_state) | 279 | unsigned new_state) |
280 | { | 280 | { |
281 | return -EINVAL; | 281 | return -ENOTTY; |
282 | } | 282 | } |
283 | 283 | ||
284 | static int gigaset_set_line_ctrl(struct cardstate *cs, unsigned cflag) | 284 | static int gigaset_set_line_ctrl(struct cardstate *cs, unsigned cflag) |
285 | { | 285 | { |
286 | return -EINVAL; | 286 | return -ENOTTY; |
287 | } | 287 | } |
288 | 288 | ||
289 | static int gigaset_baud_rate(struct cardstate *cs, unsigned cflag) | 289 | static int gigaset_baud_rate(struct cardstate *cs, unsigned cflag) |
290 | { | 290 | { |
291 | return -EINVAL; | 291 | return -ENOTTY; |
292 | } | 292 | } |
293 | #endif | 293 | #endif |
294 | 294 | ||
@@ -577,7 +577,7 @@ static int gigaset_brkchars(struct cardstate *cs, const unsigned char buf[6]) | |||
577 | return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x19, 0x41, | 577 | return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x19, 0x41, |
578 | 0, 0, &buf, 6, 2000); | 578 | 0, 0, &buf, 6, 2000); |
579 | #else | 579 | #else |
580 | return -EINVAL; | 580 | return -ENOTTY; |
581 | #endif | 581 | #endif |
582 | } | 582 | } |
583 | 583 | ||