diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2010-05-21 10:22:33 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-05-31 02:46:09 -0400 |
commit | 2e97942fe57864588774f173cf4cd7bb68968b76 (patch) | |
tree | bf0eeda8c13a6e851ad755b7114ceaa82c51fd97 | |
parent | 3771f0771154675d4a0ca780be2411f3cc357208 (diff) |
perf_events, trace: Fix perf_trace_destroy(), mutex went missing
Steve spotted I forgot to do the destroy under event_mutex.
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1274451913.1674.1707.camel@laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | kernel/trace/trace_event_perf.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c index 49c7abf2ba5c..e6f65887842c 100644 --- a/kernel/trace/trace_event_perf.c +++ b/kernel/trace/trace_event_perf.c | |||
@@ -132,8 +132,9 @@ void perf_trace_destroy(struct perf_event *p_event) | |||
132 | struct ftrace_event_call *tp_event = p_event->tp_event; | 132 | struct ftrace_event_call *tp_event = p_event->tp_event; |
133 | int i; | 133 | int i; |
134 | 134 | ||
135 | mutex_lock(&event_mutex); | ||
135 | if (--tp_event->perf_refcount > 0) | 136 | if (--tp_event->perf_refcount > 0) |
136 | return; | 137 | goto out; |
137 | 138 | ||
138 | if (tp_event->class->reg) | 139 | if (tp_event->class->reg) |
139 | tp_event->class->reg(tp_event, TRACE_REG_PERF_UNREGISTER); | 140 | tp_event->class->reg(tp_event, TRACE_REG_PERF_UNREGISTER); |
@@ -157,6 +158,8 @@ void perf_trace_destroy(struct perf_event *p_event) | |||
157 | perf_trace_buf[i] = NULL; | 158 | perf_trace_buf[i] = NULL; |
158 | } | 159 | } |
159 | } | 160 | } |
161 | out: | ||
162 | mutex_unlock(&event_mutex); | ||
160 | } | 163 | } |
161 | 164 | ||
162 | __kprobes void *perf_trace_buf_prepare(int size, unsigned short type, | 165 | __kprobes void *perf_trace_buf_prepare(int size, unsigned short type, |