diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-05-21 15:52:33 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-07-22 00:54:41 -0400 |
commit | 275e64decc01acf4d2f6b6ad1b83f1c4bd9033e5 (patch) | |
tree | a2f49b20c8bbf05b146876c79c0d73e8aba89e04 | |
parent | 6143b599700f7d6d7961e2de88f1486b2b19b1f2 (diff) |
device create: dca: convert device_create to device_create_drvdata
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/dca/dca-sysfs.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c index 011328faa5f2..9a70377bfb34 100644 --- a/drivers/dca/dca-sysfs.c +++ b/drivers/dca/dca-sysfs.c | |||
@@ -14,8 +14,9 @@ int dca_sysfs_add_req(struct dca_provider *dca, struct device *dev, int slot) | |||
14 | { | 14 | { |
15 | struct device *cd; | 15 | struct device *cd; |
16 | 16 | ||
17 | cd = device_create(dca_class, dca->cd, MKDEV(0, slot + 1), | 17 | cd = device_create_drvdata(dca_class, dca->cd, |
18 | "requester%d", slot); | 18 | MKDEV(0, slot + 1), NULL, |
19 | "requester%d", slot); | ||
19 | if (IS_ERR(cd)) | 20 | if (IS_ERR(cd)) |
20 | return PTR_ERR(cd); | 21 | return PTR_ERR(cd); |
21 | return 0; | 22 | return 0; |
@@ -46,7 +47,8 @@ idr_try_again: | |||
46 | return err; | 47 | return err; |
47 | } | 48 | } |
48 | 49 | ||
49 | cd = device_create(dca_class, dev, MKDEV(0, 0), "dca%d", dca->id); | 50 | cd = device_create_drvdata(dca_class, dev, MKDEV(0, 0), NULL, |
51 | "dca%d", dca->id); | ||
50 | if (IS_ERR(cd)) { | 52 | if (IS_ERR(cd)) { |
51 | spin_lock(&dca_idr_lock); | 53 | spin_lock(&dca_idr_lock); |
52 | idr_remove(&dca_idr, dca->id); | 54 | idr_remove(&dca_idr, dca->id); |