diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-02-28 17:16:33 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-02-28 17:16:33 -0500 |
commit | 2335f8ec27e125208d8d2d3e257a82862c4977d6 (patch) | |
tree | 8cb85e6bf5b05ceab9f7ae95ae1c21628114135c | |
parent | 6d37a1581695fba42f4b51e3ff4c2871552cd6d7 (diff) |
[X25]: Use proc_create() to setup ->proc_fops first
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/x25/x25_proc.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/net/x25/x25_proc.c b/net/x25/x25_proc.c index 3f52b09bed03..1afa44d25beb 100644 --- a/net/x25/x25_proc.c +++ b/net/x25/x25_proc.c | |||
@@ -312,20 +312,18 @@ int __init x25_proc_init(void) | |||
312 | if (!x25_proc_dir) | 312 | if (!x25_proc_dir) |
313 | goto out; | 313 | goto out; |
314 | 314 | ||
315 | p = create_proc_entry("route", S_IRUGO, x25_proc_dir); | 315 | p = proc_create("route", S_IRUGO, x25_proc_dir, &x25_seq_route_fops); |
316 | if (!p) | 316 | if (!p) |
317 | goto out_route; | 317 | goto out_route; |
318 | p->proc_fops = &x25_seq_route_fops; | ||
319 | 318 | ||
320 | p = create_proc_entry("socket", S_IRUGO, x25_proc_dir); | 319 | p = proc_create("socket", S_IRUGO, x25_proc_dir, &x25_seq_socket_fops); |
321 | if (!p) | 320 | if (!p) |
322 | goto out_socket; | 321 | goto out_socket; |
323 | p->proc_fops = &x25_seq_socket_fops; | ||
324 | 322 | ||
325 | p = create_proc_entry("forward", S_IRUGO, x25_proc_dir); | 323 | p = proc_create("forward", S_IRUGO, x25_proc_dir, |
324 | &x25_seq_forward_fops); | ||
326 | if (!p) | 325 | if (!p) |
327 | goto out_forward; | 326 | goto out_forward; |
328 | p->proc_fops = &x25_seq_forward_fops; | ||
329 | rc = 0; | 327 | rc = 0; |
330 | 328 | ||
331 | out: | 329 | out: |