diff options
author | David Daney <ddaney@caviumnetworks.com> | 2010-01-08 17:47:36 -0500 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2010-01-12 12:19:36 -0500 |
commit | 0e8a1d8262f41d6e8c1d736a408882bbb7a5c0a6 (patch) | |
tree | b8943db01b333cbd3629555e2de92a8670f39404 | |
parent | 9b54dc5869c3989077e456c57e51810f0a1bdbcb (diff) |
MIPS: Octeon: Use non-overflowing arithmetic in sched_clock
With typical mult and shift values, the calculation for Octeon's sched_clock
overflows when using 64-bit arithmetic. Use 128-bit calculations instead.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
To: linux-mips@linux-mips.org
Patchwork: http://patchwork.linux-mips.org/patch/849/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r-- | arch/mips/cavium-octeon/csrc-octeon.c | 31 |
1 files changed, 28 insertions, 3 deletions
diff --git a/arch/mips/cavium-octeon/csrc-octeon.c b/arch/mips/cavium-octeon/csrc-octeon.c index 96df821fbd81..0bf4bbe04ae2 100644 --- a/arch/mips/cavium-octeon/csrc-octeon.c +++ b/arch/mips/cavium-octeon/csrc-octeon.c | |||
@@ -52,9 +52,34 @@ static struct clocksource clocksource_mips = { | |||
52 | 52 | ||
53 | unsigned long long notrace sched_clock(void) | 53 | unsigned long long notrace sched_clock(void) |
54 | { | 54 | { |
55 | return clocksource_cyc2ns(read_c0_cvmcount(), | 55 | /* 64-bit arithmatic can overflow, so use 128-bit. */ |
56 | clocksource_mips.mult, | 56 | #if (__GNUC__ < 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ <= 3)) |
57 | clocksource_mips.shift); | 57 | u64 t1, t2, t3; |
58 | unsigned long long rv; | ||
59 | u64 mult = clocksource_mips.mult; | ||
60 | u64 shift = clocksource_mips.shift; | ||
61 | u64 cnt = read_c0_cvmcount(); | ||
62 | |||
63 | asm ( | ||
64 | "dmultu\t%[cnt],%[mult]\n\t" | ||
65 | "nor\t%[t1],$0,%[shift]\n\t" | ||
66 | "mfhi\t%[t2]\n\t" | ||
67 | "mflo\t%[t3]\n\t" | ||
68 | "dsll\t%[t2],%[t2],1\n\t" | ||
69 | "dsrlv\t%[rv],%[t3],%[shift]\n\t" | ||
70 | "dsllv\t%[t1],%[t2],%[t1]\n\t" | ||
71 | "or\t%[rv],%[t1],%[rv]\n\t" | ||
72 | : [rv] "=&r" (rv), [t1] "=&r" (t1), [t2] "=&r" (t2), [t3] "=&r" (t3) | ||
73 | : [cnt] "r" (cnt), [mult] "r" (mult), [shift] "r" (shift) | ||
74 | : "hi", "lo"); | ||
75 | return rv; | ||
76 | #else | ||
77 | /* GCC > 4.3 do it the easy way. */ | ||
78 | unsigned int __attribute__((mode(TI))) t; | ||
79 | t = read_c0_cvmcount(); | ||
80 | t = t * clocksource_mips.mult; | ||
81 | return (unsigned long long)(t >> clocksource_mips.shift); | ||
82 | #endif | ||
58 | } | 83 | } |
59 | 84 | ||
60 | void __init plat_time_init(void) | 85 | void __init plat_time_init(void) |