aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKarl Dahlke <eklhad@comcast.net>2008-04-15 01:30:32 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2008-04-15 01:30:32 -0400
commit0beb4f6f294b0f2dde07fa9da9c00abd4f9c8b50 (patch)
tree2b1b330a3b836e99ca5be38a5c2923dd319c8936
parent76d057ce5a48034c97f604a0a25a87093e072c71 (diff)
Input: put ledstate in the keyboard notifier
Led state should be part of the key event, like shiftstate, and not grabbed asynchronously after the fact. [samuel.thibault@ens-lyon.org: various fixes] Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
-rw-r--r--drivers/char/keyboard.c2
-rw-r--r--include/linux/keyboard.h1
2 files changed, 3 insertions, 0 deletions
diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
index 4dbd3425e928..59608e341385 100644
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -1237,6 +1237,7 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw)
1237 } 1237 }
1238 1238
1239 param.shift = shift_final = (shift_state | kbd->slockstate) ^ kbd->lockstate; 1239 param.shift = shift_final = (shift_state | kbd->slockstate) ^ kbd->lockstate;
1240 param.ledstate = kbd->ledflagstate;
1240 key_map = key_maps[shift_final]; 1241 key_map = key_maps[shift_final];
1241 1242
1242 if (atomic_notifier_call_chain(&keyboard_notifier_list, KBD_KEYCODE, &param) == NOTIFY_STOP || !key_map) { 1243 if (atomic_notifier_call_chain(&keyboard_notifier_list, KBD_KEYCODE, &param) == NOTIFY_STOP || !key_map) {
@@ -1285,6 +1286,7 @@ static void kbd_keycode(unsigned int keycode, int down, int hw_raw)
1285 1286
1286 (*k_handler[type])(vc, keysym & 0xff, !down); 1287 (*k_handler[type])(vc, keysym & 0xff, !down);
1287 1288
1289 param.ledstate = kbd->ledflagstate;
1288 atomic_notifier_call_chain(&keyboard_notifier_list, KBD_POST_KEYSYM, &param); 1290 atomic_notifier_call_chain(&keyboard_notifier_list, KBD_POST_KEYSYM, &param);
1289 1291
1290 if (type != KT_SLOCK) 1292 if (type != KT_SLOCK)
diff --git a/include/linux/keyboard.h b/include/linux/keyboard.h
index 65c2d70853e9..a3c984d780f0 100644
--- a/include/linux/keyboard.h
+++ b/include/linux/keyboard.h
@@ -33,6 +33,7 @@ struct keyboard_notifier_param {
33 struct vc_data *vc; /* VC on which the keyboard press was done */ 33 struct vc_data *vc; /* VC on which the keyboard press was done */
34 int down; /* Pressure of the key? */ 34 int down; /* Pressure of the key? */
35 int shift; /* Current shift mask */ 35 int shift; /* Current shift mask */
36 int ledstate; /* Current led state */
36 unsigned int value; /* keycode, unicode value or keysym */ 37 unsigned int value; /* keycode, unicode value or keysym */
37}; 38};
38 39