aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2006-10-10 02:58:14 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-10-10 19:29:37 -0400
commit0968cf51b6f2ca8a951de4b976370189cf43bbdd (patch)
treefd29fb864a516b4c52e26700f0b1d782857c9797
parent15e541feb340bc2a4caaf707ee5ad71a47fdd068 (diff)
[PATCH] firmware/dcdbas: fix bug in error cleanup
The error path path mistakenly called sysfs_create_group() rather than sysfs_remove_group(). They take the same arguments, so it's easy to cut-n-paste such a bug. Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/firmware/dcdbas.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index 339f405ff708..8bcb58cd4ac0 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev)
559 while (--i >= 0) 559 while (--i >= 0)
560 sysfs_remove_bin_file(&dev->dev.kobj, 560 sysfs_remove_bin_file(&dev->dev.kobj,
561 dcdbas_bin_attrs[i]); 561 dcdbas_bin_attrs[i]);
562 sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group); 562 sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group);
563 return error; 563 return error;
564 } 564 }
565 } 565 }