diff options
author | Andy Whitcroft <apw@canonical.com> | 2009-02-27 17:03:07 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-02-27 19:26:21 -0500 |
commit | 00ef4ece05096a5c523e265b8ce6627fb5e171c2 (patch) | |
tree | 13e3db3b95e04ed3fd53dae599a947c87e87c799 | |
parent | e2f7aa4b8bc811ebf8afbdf423caf90a5a03cb08 (diff) |
checkpatch: correctly handle type spacing in the face of modifiers
We need to handle interspersed modifiers in the middle of pointer types,
for example:
void * __user * __user bar;
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-x | scripts/checkpatch.pl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 5ffc940399be..92d13710ff52 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -1658,7 +1658,7 @@ sub process { | |||
1658 | 1658 | ||
1659 | # * goes on variable not on type | 1659 | # * goes on variable not on type |
1660 | # (char*[ const]) | 1660 | # (char*[ const]) |
1661 | if ($line =~ m{\($NonptrType(\s*\*[\s\*]*(?:$Modifier\s*)*)\)}) { | 1661 | if ($line =~ m{\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\)}) { |
1662 | my ($from, $to) = ($1, $1); | 1662 | my ($from, $to) = ($1, $1); |
1663 | 1663 | ||
1664 | # Should start with a space. | 1664 | # Should start with a space. |
@@ -1673,7 +1673,7 @@ sub process { | |||
1673 | if ($from ne $to) { | 1673 | if ($from ne $to) { |
1674 | ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr); | 1674 | ERROR("\"(foo$from)\" should be \"(foo$to)\"\n" . $herecurr); |
1675 | } | 1675 | } |
1676 | } elsif ($line =~ m{\b$NonptrType(\s*\*[\s\*]*(?:$Modifier\s*)?)($Ident)}) { | 1676 | } elsif ($line =~ m{\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident)}) { |
1677 | my ($from, $to, $ident) = ($1, $1, $2); | 1677 | my ($from, $to, $ident) = ($1, $1, $2); |
1678 | 1678 | ||
1679 | # Should start with a space. | 1679 | # Should start with a space. |