diff options
author | Robert P. J. Day <rpjday@crashcourse.ca> | 2008-07-25 04:45:32 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-25 13:53:27 -0400 |
commit | e0ce0da9fefcc723dc006c35a7f91a32750abd40 (patch) | |
tree | 49ca0889a60cb545eb5c21c3365d1c54e1e226f8 | |
parent | fd193829744bc77392395cf8f47889235c97f0a3 (diff) |
lists: remove a redundant conditional definition of list_add()
Remove the conditional surrounding the definition of list_add() from list.h
since, if you define CONFIG_DEBUG_LIST, the definition you will subsequently
pick up from lib/list_debug.c will be absolutely identical, at which point you
can remove that redundant definition from list_debug.c as well.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Cc: Dave Jones <davej@codemonkey.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/linux/list.h | 4 | ||||
-rw-r--r-- | lib/list_debug.c | 14 |
2 files changed, 0 insertions, 18 deletions
diff --git a/include/linux/list.h b/include/linux/list.h index 139ec41d9c2e..453916bc0412 100644 --- a/include/linux/list.h +++ b/include/linux/list.h | |||
@@ -61,14 +61,10 @@ extern void __list_add(struct list_head *new, | |||
61 | * Insert a new entry after the specified head. | 61 | * Insert a new entry after the specified head. |
62 | * This is good for implementing stacks. | 62 | * This is good for implementing stacks. |
63 | */ | 63 | */ |
64 | #ifndef CONFIG_DEBUG_LIST | ||
65 | static inline void list_add(struct list_head *new, struct list_head *head) | 64 | static inline void list_add(struct list_head *new, struct list_head *head) |
66 | { | 65 | { |
67 | __list_add(new, head, head->next); | 66 | __list_add(new, head, head->next); |
68 | } | 67 | } |
69 | #else | ||
70 | extern void list_add(struct list_head *new, struct list_head *head); | ||
71 | #endif | ||
72 | 68 | ||
73 | 69 | ||
74 | /** | 70 | /** |
diff --git a/lib/list_debug.c b/lib/list_debug.c index 4350ba9655bd..45c03fd608dd 100644 --- a/lib/list_debug.c +++ b/lib/list_debug.c | |||
@@ -40,20 +40,6 @@ void __list_add(struct list_head *new, | |||
40 | EXPORT_SYMBOL(__list_add); | 40 | EXPORT_SYMBOL(__list_add); |
41 | 41 | ||
42 | /** | 42 | /** |
43 | * list_add - add a new entry | ||
44 | * @new: new entry to be added | ||
45 | * @head: list head to add it after | ||
46 | * | ||
47 | * Insert a new entry after the specified head. | ||
48 | * This is good for implementing stacks. | ||
49 | */ | ||
50 | void list_add(struct list_head *new, struct list_head *head) | ||
51 | { | ||
52 | __list_add(new, head, head->next); | ||
53 | } | ||
54 | EXPORT_SYMBOL(list_add); | ||
55 | |||
56 | /** | ||
57 | * list_del - deletes entry from list. | 43 | * list_del - deletes entry from list. |
58 | * @entry: the element to delete from the list. | 44 | * @entry: the element to delete from the list. |
59 | * Note: list_empty on entry does not return true after this, the entry is | 45 | * Note: list_empty on entry does not return true after this, the entry is |