diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-23 15:04:34 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-23 15:04:34 -0400 |
commit | 20b7997e8abdf338dcc27fb4f1333c4973a7f113 (patch) | |
tree | d060f0ba9940781ca2351c09f4638640584052a5 | |
parent | 5554b35933245e95710d709175e14c02cbc956a4 (diff) | |
parent | 7659150c60839a2bd31f74e866374abb9be17e43 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc:
sdhci: highmem capable PIO routines
sg: reimplement sg mapping iterator
mmc_test: print message when attaching to card
mmc: Remove Russell as primecell mci maintainer
mmc_block: bounce buffer highmem support
sdhci: fix bad warning from commit c8b3e02
sdhci: add warnings for bad buffers in ADMA path
mmc_test: test oversized sg lists
mmc_test: highmem tests
s3cmci: ensure host stopped on machine shutdown
au1xmmc: suspend/resume implementation
s3cmci: fixes for section mismatch warnings
pxamci: trivial fix of DMA alignment register bit clearing
-rw-r--r-- | MAINTAINERS | 5 | ||||
-rw-r--r-- | drivers/mmc/card/mmc_test.c | 225 | ||||
-rw-r--r-- | drivers/mmc/card/queue.c | 97 | ||||
-rw-r--r-- | drivers/mmc/host/au1xmmc.c | 54 | ||||
-rw-r--r-- | drivers/mmc/host/pxamci.c | 2 | ||||
-rw-r--r-- | drivers/mmc/host/s3cmci.c | 50 | ||||
-rw-r--r-- | drivers/mmc/host/sdhci.c | 167 | ||||
-rw-r--r-- | drivers/mmc/host/sdhci.h | 7 | ||||
-rw-r--r-- | include/linux/scatterlist.h | 38 | ||||
-rw-r--r-- | lib/scatterlist.c | 176 |
10 files changed, 573 insertions, 248 deletions
diff --git a/MAINTAINERS b/MAINTAINERS index 0652ab384d51..f4d78211000b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
@@ -441,10 +441,7 @@ M: spyro@f2s.com | |||
441 | S: Maintained | 441 | S: Maintained |
442 | 442 | ||
443 | ARM PRIMECELL MMCI PL180/1 DRIVER | 443 | ARM PRIMECELL MMCI PL180/1 DRIVER |
444 | P: Russell King | 444 | S: Orphan |
445 | M: rmk@arm.linux.org.uk | ||
446 | L: linux-arm-kernel@lists.arm.linux.org.uk (subscribers-only) | ||
447 | S: Maintained | ||
448 | 445 | ||
449 | ARM/ADI ROADRUNNER MACHINE SUPPORT | 446 | ARM/ADI ROADRUNNER MACHINE SUPPORT |
450 | P: Lennert Buytenhek | 447 | P: Lennert Buytenhek |
diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c index d6b9b486417c..a067fe436301 100644 --- a/drivers/mmc/card/mmc_test.c +++ b/drivers/mmc/card/mmc_test.c | |||
@@ -21,13 +21,17 @@ | |||
21 | #define RESULT_UNSUP_HOST 2 | 21 | #define RESULT_UNSUP_HOST 2 |
22 | #define RESULT_UNSUP_CARD 3 | 22 | #define RESULT_UNSUP_CARD 3 |
23 | 23 | ||
24 | #define BUFFER_SIZE (PAGE_SIZE * 4) | 24 | #define BUFFER_ORDER 2 |
25 | #define BUFFER_SIZE (PAGE_SIZE << BUFFER_ORDER) | ||
25 | 26 | ||
26 | struct mmc_test_card { | 27 | struct mmc_test_card { |
27 | struct mmc_card *card; | 28 | struct mmc_card *card; |
28 | 29 | ||
29 | u8 scratch[BUFFER_SIZE]; | 30 | u8 scratch[BUFFER_SIZE]; |
30 | u8 *buffer; | 31 | u8 *buffer; |
32 | #ifdef CONFIG_HIGHMEM | ||
33 | struct page *highmem; | ||
34 | #endif | ||
31 | }; | 35 | }; |
32 | 36 | ||
33 | /*******************************************************************/ | 37 | /*******************************************************************/ |
@@ -384,14 +388,16 @@ static int mmc_test_transfer(struct mmc_test_card *test, | |||
384 | int ret, i; | 388 | int ret, i; |
385 | unsigned long flags; | 389 | unsigned long flags; |
386 | 390 | ||
391 | BUG_ON(blocks * blksz > BUFFER_SIZE); | ||
392 | |||
387 | if (write) { | 393 | if (write) { |
388 | for (i = 0;i < blocks * blksz;i++) | 394 | for (i = 0;i < blocks * blksz;i++) |
389 | test->scratch[i] = i; | 395 | test->scratch[i] = i; |
390 | } else { | 396 | } else { |
391 | memset(test->scratch, 0, BUFFER_SIZE); | 397 | memset(test->scratch, 0, blocks * blksz); |
392 | } | 398 | } |
393 | local_irq_save(flags); | 399 | local_irq_save(flags); |
394 | sg_copy_from_buffer(sg, sg_len, test->scratch, BUFFER_SIZE); | 400 | sg_copy_from_buffer(sg, sg_len, test->scratch, blocks * blksz); |
395 | local_irq_restore(flags); | 401 | local_irq_restore(flags); |
396 | 402 | ||
397 | ret = mmc_test_set_blksize(test, blksz); | 403 | ret = mmc_test_set_blksize(test, blksz); |
@@ -438,7 +444,7 @@ static int mmc_test_transfer(struct mmc_test_card *test, | |||
438 | } | 444 | } |
439 | } else { | 445 | } else { |
440 | local_irq_save(flags); | 446 | local_irq_save(flags); |
441 | sg_copy_to_buffer(sg, sg_len, test->scratch, BUFFER_SIZE); | 447 | sg_copy_to_buffer(sg, sg_len, test->scratch, blocks * blksz); |
442 | local_irq_restore(flags); | 448 | local_irq_restore(flags); |
443 | for (i = 0;i < blocks * blksz;i++) { | 449 | for (i = 0;i < blocks * blksz;i++) { |
444 | if (test->scratch[i] != (u8)i) | 450 | if (test->scratch[i] != (u8)i) |
@@ -799,6 +805,157 @@ static int mmc_test_multi_xfersize_read(struct mmc_test_card *test) | |||
799 | return 0; | 805 | return 0; |
800 | } | 806 | } |
801 | 807 | ||
808 | static int mmc_test_bigsg_write(struct mmc_test_card *test) | ||
809 | { | ||
810 | int ret; | ||
811 | unsigned int size; | ||
812 | struct scatterlist sg; | ||
813 | |||
814 | if (test->card->host->max_blk_count == 1) | ||
815 | return RESULT_UNSUP_HOST; | ||
816 | |||
817 | size = PAGE_SIZE * 2; | ||
818 | size = min(size, test->card->host->max_req_size); | ||
819 | size = min(size, test->card->host->max_seg_size); | ||
820 | size = min(size, test->card->host->max_blk_count * 512); | ||
821 | |||
822 | memset(test->buffer, 0, BUFFER_SIZE); | ||
823 | |||
824 | if (size < 1024) | ||
825 | return RESULT_UNSUP_HOST; | ||
826 | |||
827 | sg_init_table(&sg, 1); | ||
828 | sg_init_one(&sg, test->buffer, BUFFER_SIZE); | ||
829 | |||
830 | ret = mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 1); | ||
831 | if (ret) | ||
832 | return ret; | ||
833 | |||
834 | return 0; | ||
835 | } | ||
836 | |||
837 | static int mmc_test_bigsg_read(struct mmc_test_card *test) | ||
838 | { | ||
839 | int ret, i; | ||
840 | unsigned int size; | ||
841 | struct scatterlist sg; | ||
842 | |||
843 | if (test->card->host->max_blk_count == 1) | ||
844 | return RESULT_UNSUP_HOST; | ||
845 | |||
846 | size = PAGE_SIZE * 2; | ||
847 | size = min(size, test->card->host->max_req_size); | ||
848 | size = min(size, test->card->host->max_seg_size); | ||
849 | size = min(size, test->card->host->max_blk_count * 512); | ||
850 | |||
851 | if (size < 1024) | ||
852 | return RESULT_UNSUP_HOST; | ||
853 | |||
854 | memset(test->buffer, 0xCD, BUFFER_SIZE); | ||
855 | |||
856 | sg_init_table(&sg, 1); | ||
857 | sg_init_one(&sg, test->buffer, BUFFER_SIZE); | ||
858 | ret = mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 0); | ||
859 | if (ret) | ||
860 | return ret; | ||
861 | |||
862 | /* mmc_test_transfer() doesn't check for read overflows */ | ||
863 | for (i = size;i < BUFFER_SIZE;i++) { | ||
864 | if (test->buffer[i] != 0xCD) | ||
865 | return RESULT_FAIL; | ||
866 | } | ||
867 | |||
868 | return 0; | ||
869 | } | ||
870 | |||
871 | #ifdef CONFIG_HIGHMEM | ||
872 | |||
873 | static int mmc_test_write_high(struct mmc_test_card *test) | ||
874 | { | ||
875 | int ret; | ||
876 | struct scatterlist sg; | ||
877 | |||
878 | sg_init_table(&sg, 1); | ||
879 | sg_set_page(&sg, test->highmem, 512, 0); | ||
880 | |||
881 | ret = mmc_test_transfer(test, &sg, 1, 0, 1, 512, 1); | ||
882 | if (ret) | ||
883 | return ret; | ||
884 | |||
885 | return 0; | ||
886 | } | ||
887 | |||
888 | static int mmc_test_read_high(struct mmc_test_card *test) | ||
889 | { | ||
890 | int ret; | ||
891 | struct scatterlist sg; | ||
892 | |||
893 | sg_init_table(&sg, 1); | ||
894 | sg_set_page(&sg, test->highmem, 512, 0); | ||
895 | |||
896 | ret = mmc_test_transfer(test, &sg, 1, 0, 1, 512, 0); | ||
897 | if (ret) | ||
898 | return ret; | ||
899 | |||
900 | return 0; | ||
901 | } | ||
902 | |||
903 | static int mmc_test_multi_write_high(struct mmc_test_card *test) | ||
904 | { | ||
905 | int ret; | ||
906 | unsigned int size; | ||
907 | struct scatterlist sg; | ||
908 | |||
909 | if (test->card->host->max_blk_count == 1) | ||
910 | return RESULT_UNSUP_HOST; | ||
911 | |||
912 | size = PAGE_SIZE * 2; | ||
913 | size = min(size, test->card->host->max_req_size); | ||
914 | size = min(size, test->card->host->max_seg_size); | ||
915 | size = min(size, test->card->host->max_blk_count * 512); | ||
916 | |||
917 | if (size < 1024) | ||
918 | return RESULT_UNSUP_HOST; | ||
919 | |||
920 | sg_init_table(&sg, 1); | ||
921 | sg_set_page(&sg, test->highmem, size, 0); | ||
922 | |||
923 | ret = mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 1); | ||
924 | if (ret) | ||
925 | return ret; | ||
926 | |||
927 | return 0; | ||
928 | } | ||
929 | |||
930 | static int mmc_test_multi_read_high(struct mmc_test_card *test) | ||
931 | { | ||
932 | int ret; | ||
933 | unsigned int size; | ||
934 | struct scatterlist sg; | ||
935 | |||
936 | if (test->card->host->max_blk_count == 1) | ||
937 | return RESULT_UNSUP_HOST; | ||
938 | |||
939 | size = PAGE_SIZE * 2; | ||
940 | size = min(size, test->card->host->max_req_size); | ||
941 | size = min(size, test->card->host->max_seg_size); | ||
942 | size = min(size, test->card->host->max_blk_count * 512); | ||
943 | |||
944 | if (size < 1024) | ||
945 | return RESULT_UNSUP_HOST; | ||
946 | |||
947 | sg_init_table(&sg, 1); | ||
948 | sg_set_page(&sg, test->highmem, size, 0); | ||
949 | |||
950 | ret = mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 0); | ||
951 | if (ret) | ||
952 | return ret; | ||
953 | |||
954 | return 0; | ||
955 | } | ||
956 | |||
957 | #endif /* CONFIG_HIGHMEM */ | ||
958 | |||
802 | static const struct mmc_test_case mmc_test_cases[] = { | 959 | static const struct mmc_test_case mmc_test_cases[] = { |
803 | { | 960 | { |
804 | .name = "Basic write (no data verification)", | 961 | .name = "Basic write (no data verification)", |
@@ -913,6 +1070,53 @@ static const struct mmc_test_case mmc_test_cases[] = { | |||
913 | .name = "Correct xfer_size at read (midway failure)", | 1070 | .name = "Correct xfer_size at read (midway failure)", |
914 | .run = mmc_test_multi_xfersize_read, | 1071 | .run = mmc_test_multi_xfersize_read, |
915 | }, | 1072 | }, |
1073 | |||
1074 | { | ||
1075 | .name = "Over-sized SG list write", | ||
1076 | .prepare = mmc_test_prepare_write, | ||
1077 | .run = mmc_test_bigsg_write, | ||
1078 | .cleanup = mmc_test_cleanup, | ||
1079 | }, | ||
1080 | |||
1081 | { | ||
1082 | .name = "Over-sized SG list read", | ||
1083 | .prepare = mmc_test_prepare_read, | ||
1084 | .run = mmc_test_bigsg_read, | ||
1085 | .cleanup = mmc_test_cleanup, | ||
1086 | }, | ||
1087 | |||
1088 | #ifdef CONFIG_HIGHMEM | ||
1089 | |||
1090 | { | ||
1091 | .name = "Highmem write", | ||
1092 | .prepare = mmc_test_prepare_write, | ||
1093 | .run = mmc_test_write_high, | ||
1094 | .cleanup = mmc_test_cleanup, | ||
1095 | }, | ||
1096 | |||
1097 | { | ||
1098 | .name = "Highmem read", | ||
1099 | .prepare = mmc_test_prepare_read, | ||
1100 | .run = mmc_test_read_high, | ||
1101 | .cleanup = mmc_test_cleanup, | ||
1102 | }, | ||
1103 | |||
1104 | { | ||
1105 | .name = "Multi-block highmem write", | ||
1106 | .prepare = mmc_test_prepare_write, | ||
1107 | .run = mmc_test_multi_write_high, | ||
1108 | .cleanup = mmc_test_cleanup, | ||
1109 | }, | ||
1110 | |||
1111 | { | ||
1112 | .name = "Multi-block highmem read", | ||
1113 | .prepare = mmc_test_prepare_read, | ||
1114 | .run = mmc_test_multi_read_high, | ||
1115 | .cleanup = mmc_test_cleanup, | ||
1116 | }, | ||
1117 | |||
1118 | #endif /* CONFIG_HIGHMEM */ | ||
1119 | |||
916 | }; | 1120 | }; |
917 | 1121 | ||
918 | static struct mutex mmc_test_lock; | 1122 | static struct mutex mmc_test_lock; |
@@ -1014,12 +1218,23 @@ static ssize_t mmc_test_store(struct device *dev, | |||
1014 | test->card = card; | 1218 | test->card = card; |
1015 | 1219 | ||
1016 | test->buffer = kzalloc(BUFFER_SIZE, GFP_KERNEL); | 1220 | test->buffer = kzalloc(BUFFER_SIZE, GFP_KERNEL); |
1221 | #ifdef CONFIG_HIGHMEM | ||
1222 | test->highmem = alloc_pages(GFP_KERNEL | __GFP_HIGHMEM, BUFFER_ORDER); | ||
1223 | #endif | ||
1224 | |||
1225 | #ifdef CONFIG_HIGHMEM | ||
1226 | if (test->buffer && test->highmem) { | ||
1227 | #else | ||
1017 | if (test->buffer) { | 1228 | if (test->buffer) { |
1229 | #endif | ||
1018 | mutex_lock(&mmc_test_lock); | 1230 | mutex_lock(&mmc_test_lock); |
1019 | mmc_test_run(test, testcase); | 1231 | mmc_test_run(test, testcase); |
1020 | mutex_unlock(&mmc_test_lock); | 1232 | mutex_unlock(&mmc_test_lock); |
1021 | } | 1233 | } |
1022 | 1234 | ||
1235 | #ifdef CONFIG_HIGHMEM | ||
1236 | __free_pages(test->highmem, BUFFER_ORDER); | ||
1237 | #endif | ||
1023 | kfree(test->buffer); | 1238 | kfree(test->buffer); |
1024 | kfree(test); | 1239 | kfree(test); |
1025 | 1240 | ||
@@ -1041,6 +1256,8 @@ static int mmc_test_probe(struct mmc_card *card) | |||
1041 | if (ret) | 1256 | if (ret) |
1042 | return ret; | 1257 | return ret; |
1043 | 1258 | ||
1259 | dev_info(&card->dev, "Card claimed for testing.\n"); | ||
1260 | |||
1044 | return 0; | 1261 | return 0; |
1045 | } | 1262 | } |
1046 | 1263 | ||
diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c index 7731ddefdc1b..3dee97e7d165 100644 --- a/drivers/mmc/card/queue.c +++ b/drivers/mmc/card/queue.c | |||
@@ -148,7 +148,7 @@ int mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card, spinlock_t *lock | |||
148 | printk(KERN_WARNING "%s: unable to allocate " | 148 | printk(KERN_WARNING "%s: unable to allocate " |
149 | "bounce buffer\n", mmc_card_name(card)); | 149 | "bounce buffer\n", mmc_card_name(card)); |
150 | } else { | 150 | } else { |
151 | blk_queue_bounce_limit(mq->queue, BLK_BOUNCE_HIGH); | 151 | blk_queue_bounce_limit(mq->queue, BLK_BOUNCE_ANY); |
152 | blk_queue_max_sectors(mq->queue, bouncesz / 512); | 152 | blk_queue_max_sectors(mq->queue, bouncesz / 512); |
153 | blk_queue_max_phys_segments(mq->queue, bouncesz / 512); | 153 | blk_queue_max_phys_segments(mq->queue, bouncesz / 512); |
154 | blk_queue_max_hw_segments(mq->queue, bouncesz / 512); | 154 | blk_queue_max_hw_segments(mq->queue, bouncesz / 512); |
@@ -290,55 +290,15 @@ void mmc_queue_resume(struct mmc_queue *mq) | |||
290 | } | 290 | } |
291 | } | 291 | } |
292 | 292 | ||
293 | static void copy_sg(struct scatterlist *dst, unsigned int dst_len, | 293 | /* |
294 | struct scatterlist *src, unsigned int src_len) | 294 | * Prepare the sg list(s) to be handed of to the host driver |
295 | { | 295 | */ |
296 | unsigned int chunk; | ||
297 | char *dst_buf, *src_buf; | ||
298 | unsigned int dst_size, src_size; | ||
299 | |||
300 | dst_buf = NULL; | ||
301 | src_buf = NULL; | ||
302 | dst_size = 0; | ||
303 | src_size = 0; | ||
304 | |||
305 | while (src_len) { | ||
306 | BUG_ON(dst_len == 0); | ||
307 | |||
308 | if (dst_size == 0) { | ||
309 | dst_buf = sg_virt(dst); | ||
310 | dst_size = dst->length; | ||
311 | } | ||
312 | |||
313 | if (src_size == 0) { | ||
314 | src_buf = sg_virt(src); | ||
315 | src_size = src->length; | ||
316 | } | ||
317 | |||
318 | chunk = min(dst_size, src_size); | ||
319 | |||
320 | memcpy(dst_buf, src_buf, chunk); | ||
321 | |||
322 | dst_buf += chunk; | ||
323 | src_buf += chunk; | ||
324 | dst_size -= chunk; | ||
325 | src_size -= chunk; | ||
326 | |||
327 | if (dst_size == 0) { | ||
328 | dst++; | ||
329 | dst_len--; | ||
330 | } | ||
331 | |||
332 | if (src_size == 0) { | ||
333 | src++; | ||
334 | src_len--; | ||
335 | } | ||
336 | } | ||
337 | } | ||
338 | |||
339 | unsigned int mmc_queue_map_sg(struct mmc_queue *mq) | 296 | unsigned int mmc_queue_map_sg(struct mmc_queue *mq) |
340 | { | 297 | { |
341 | unsigned int sg_len; | 298 | unsigned int sg_len; |
299 | size_t buflen; | ||
300 | struct scatterlist *sg; | ||
301 | int i; | ||
342 | 302 | ||
343 | if (!mq->bounce_buf) | 303 | if (!mq->bounce_buf) |
344 | return blk_rq_map_sg(mq->queue, mq->req, mq->sg); | 304 | return blk_rq_map_sg(mq->queue, mq->req, mq->sg); |
@@ -349,47 +309,52 @@ unsigned int mmc_queue_map_sg(struct mmc_queue *mq) | |||
349 | 309 | ||
350 | mq->bounce_sg_len = sg_len; | 310 | mq->bounce_sg_len = sg_len; |
351 | 311 | ||
352 | /* | 312 | buflen = 0; |
353 | * Shortcut in the event we only get a single entry. | 313 | for_each_sg(mq->bounce_sg, sg, sg_len, i) |
354 | */ | 314 | buflen += sg->length; |
355 | if (sg_len == 1) { | ||
356 | memcpy(mq->sg, mq->bounce_sg, sizeof(struct scatterlist)); | ||
357 | return 1; | ||
358 | } | ||
359 | 315 | ||
360 | sg_init_one(mq->sg, mq->bounce_buf, 0); | 316 | sg_init_one(mq->sg, mq->bounce_buf, buflen); |
361 | |||
362 | while (sg_len) { | ||
363 | mq->sg[0].length += mq->bounce_sg[sg_len - 1].length; | ||
364 | sg_len--; | ||
365 | } | ||
366 | 317 | ||
367 | return 1; | 318 | return 1; |
368 | } | 319 | } |
369 | 320 | ||
321 | /* | ||
322 | * If writing, bounce the data to the buffer before the request | ||
323 | * is sent to the host driver | ||
324 | */ | ||
370 | void mmc_queue_bounce_pre(struct mmc_queue *mq) | 325 | void mmc_queue_bounce_pre(struct mmc_queue *mq) |
371 | { | 326 | { |
327 | unsigned long flags; | ||
328 | |||
372 | if (!mq->bounce_buf) | 329 | if (!mq->bounce_buf) |
373 | return; | 330 | return; |
374 | 331 | ||
375 | if (mq->bounce_sg_len == 1) | ||
376 | return; | ||
377 | if (rq_data_dir(mq->req) != WRITE) | 332 | if (rq_data_dir(mq->req) != WRITE) |
378 | return; | 333 | return; |
379 | 334 | ||
380 | copy_sg(mq->sg, 1, mq->bounce_sg, mq->bounce_sg_len); | 335 | local_irq_save(flags); |
336 | sg_copy_to_buffer(mq->bounce_sg, mq->bounce_sg_len, | ||
337 | mq->bounce_buf, mq->sg[0].length); | ||
338 | local_irq_restore(flags); | ||
381 | } | 339 | } |
382 | 340 | ||
341 | /* | ||
342 | * If reading, bounce the data from the buffer after the request | ||
343 | * has been handled by the host driver | ||
344 | */ | ||
383 | void mmc_queue_bounce_post(struct mmc_queue *mq) | 345 | void mmc_queue_bounce_post(struct mmc_queue *mq) |
384 | { | 346 | { |
347 | unsigned long flags; | ||
348 | |||
385 | if (!mq->bounce_buf) | 349 | if (!mq->bounce_buf) |
386 | return; | 350 | return; |
387 | 351 | ||
388 | if (mq->bounce_sg_len == 1) | ||
389 | return; | ||
390 | if (rq_data_dir(mq->req) != READ) | 352 | if (rq_data_dir(mq->req) != READ) |
391 | return; | 353 | return; |
392 | 354 | ||
393 | copy_sg(mq->bounce_sg, mq->bounce_sg_len, mq->sg, 1); | 355 | local_irq_save(flags); |
356 | sg_copy_from_buffer(mq->bounce_sg, mq->bounce_sg_len, | ||
357 | mq->bounce_buf, mq->sg[0].length); | ||
358 | local_irq_restore(flags); | ||
394 | } | 359 | } |
395 | 360 | ||
diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c index 3f15eb204895..99b20917cc0f 100644 --- a/drivers/mmc/host/au1xmmc.c +++ b/drivers/mmc/host/au1xmmc.c | |||
@@ -1043,7 +1043,7 @@ static int __devinit au1xmmc_probe(struct platform_device *pdev) | |||
1043 | goto out6; | 1043 | goto out6; |
1044 | } | 1044 | } |
1045 | 1045 | ||
1046 | platform_set_drvdata(pdev, mmc); | 1046 | platform_set_drvdata(pdev, host); |
1047 | 1047 | ||
1048 | printk(KERN_INFO DRIVER_NAME ": MMC Controller %d set up at %8.8X" | 1048 | printk(KERN_INFO DRIVER_NAME ": MMC Controller %d set up at %8.8X" |
1049 | " (mode=%s)\n", pdev->id, host->iobase, | 1049 | " (mode=%s)\n", pdev->id, host->iobase, |
@@ -1087,13 +1087,10 @@ out0: | |||
1087 | 1087 | ||
1088 | static int __devexit au1xmmc_remove(struct platform_device *pdev) | 1088 | static int __devexit au1xmmc_remove(struct platform_device *pdev) |
1089 | { | 1089 | { |
1090 | struct mmc_host *mmc = platform_get_drvdata(pdev); | 1090 | struct au1xmmc_host *host = platform_get_drvdata(pdev); |
1091 | struct au1xmmc_host *host; | ||
1092 | |||
1093 | if (mmc) { | ||
1094 | host = mmc_priv(mmc); | ||
1095 | 1091 | ||
1096 | mmc_remove_host(mmc); | 1092 | if (host) { |
1093 | mmc_remove_host(host->mmc); | ||
1097 | 1094 | ||
1098 | #ifdef CONFIG_LEDS_CLASS | 1095 | #ifdef CONFIG_LEDS_CLASS |
1099 | if (host->platdata && host->platdata->led) | 1096 | if (host->platdata && host->platdata->led) |
@@ -1101,8 +1098,8 @@ static int __devexit au1xmmc_remove(struct platform_device *pdev) | |||
1101 | #endif | 1098 | #endif |
1102 | 1099 | ||
1103 | if (host->platdata && host->platdata->cd_setup && | 1100 | if (host->platdata && host->platdata->cd_setup && |
1104 | !(mmc->caps & MMC_CAP_NEEDS_POLL)) | 1101 | !(host->mmc->caps & MMC_CAP_NEEDS_POLL)) |
1105 | host->platdata->cd_setup(mmc, 0); | 1102 | host->platdata->cd_setup(host->mmc, 0); |
1106 | 1103 | ||
1107 | au_writel(0, HOST_ENABLE(host)); | 1104 | au_writel(0, HOST_ENABLE(host)); |
1108 | au_writel(0, HOST_CONFIG(host)); | 1105 | au_writel(0, HOST_CONFIG(host)); |
@@ -1122,16 +1119,49 @@ static int __devexit au1xmmc_remove(struct platform_device *pdev) | |||
1122 | release_resource(host->ioarea); | 1119 | release_resource(host->ioarea); |
1123 | kfree(host->ioarea); | 1120 | kfree(host->ioarea); |
1124 | 1121 | ||
1125 | mmc_free_host(mmc); | 1122 | mmc_free_host(host->mmc); |
1123 | platform_set_drvdata(pdev, NULL); | ||
1126 | } | 1124 | } |
1127 | return 0; | 1125 | return 0; |
1128 | } | 1126 | } |
1129 | 1127 | ||
1128 | #ifdef CONFIG_PM | ||
1129 | static int au1xmmc_suspend(struct platform_device *pdev, pm_message_t state) | ||
1130 | { | ||
1131 | struct au1xmmc_host *host = platform_get_drvdata(pdev); | ||
1132 | int ret; | ||
1133 | |||
1134 | ret = mmc_suspend_host(host->mmc, state); | ||
1135 | if (ret) | ||
1136 | return ret; | ||
1137 | |||
1138 | au_writel(0, HOST_CONFIG2(host)); | ||
1139 | au_writel(0, HOST_CONFIG(host)); | ||
1140 | au_writel(0xffffffff, HOST_STATUS(host)); | ||
1141 | au_writel(0, HOST_ENABLE(host)); | ||
1142 | au_sync(); | ||
1143 | |||
1144 | return 0; | ||
1145 | } | ||
1146 | |||
1147 | static int au1xmmc_resume(struct platform_device *pdev) | ||
1148 | { | ||
1149 | struct au1xmmc_host *host = platform_get_drvdata(pdev); | ||
1150 | |||
1151 | au1xmmc_reset_controller(host); | ||
1152 | |||
1153 | return mmc_resume_host(host->mmc); | ||
1154 | } | ||
1155 | #else | ||
1156 | #define au1xmmc_suspend NULL | ||
1157 | #define au1xmmc_resume NULL | ||
1158 | #endif | ||
1159 | |||
1130 | static struct platform_driver au1xmmc_driver = { | 1160 | static struct platform_driver au1xmmc_driver = { |
1131 | .probe = au1xmmc_probe, | 1161 | .probe = au1xmmc_probe, |
1132 | .remove = au1xmmc_remove, | 1162 | .remove = au1xmmc_remove, |
1133 | .suspend = NULL, | 1163 | .suspend = au1xmmc_suspend, |
1134 | .resume = NULL, | 1164 | .resume = au1xmmc_resume, |
1135 | .driver = { | 1165 | .driver = { |
1136 | .name = DRIVER_NAME, | 1166 | .name = DRIVER_NAME, |
1137 | .owner = THIS_MODULE, | 1167 | .owner = THIS_MODULE, |
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index d39f59738866..a8e18fe53077 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c | |||
@@ -177,7 +177,7 @@ static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data) | |||
177 | if (dalgn) | 177 | if (dalgn) |
178 | DALGN |= (1 << host->dma); | 178 | DALGN |= (1 << host->dma); |
179 | else | 179 | else |
180 | DALGN &= (1 << host->dma); | 180 | DALGN &= ~(1 << host->dma); |
181 | DDADR(host->dma) = host->sg_dma; | 181 | DDADR(host->dma) = host->sg_dma; |
182 | DCSR(host->dma) = DCSR_RUN; | 182 | DCSR(host->dma) = DCSR_RUN; |
183 | } | 183 | } |
diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 6a1e4994b724..be550c26da68 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c | |||
@@ -1331,21 +1331,30 @@ static int __devinit s3cmci_probe(struct platform_device *pdev, int is2440) | |||
1331 | return ret; | 1331 | return ret; |
1332 | } | 1332 | } |
1333 | 1333 | ||
1334 | static void s3cmci_shutdown(struct platform_device *pdev) | ||
1335 | { | ||
1336 | struct mmc_host *mmc = platform_get_drvdata(pdev); | ||
1337 | struct s3cmci_host *host = mmc_priv(mmc); | ||
1338 | |||
1339 | if (host->irq_cd >= 0) | ||
1340 | free_irq(host->irq_cd, host); | ||
1341 | |||
1342 | mmc_remove_host(mmc); | ||
1343 | clk_disable(host->clk); | ||
1344 | } | ||
1345 | |||
1334 | static int __devexit s3cmci_remove(struct platform_device *pdev) | 1346 | static int __devexit s3cmci_remove(struct platform_device *pdev) |
1335 | { | 1347 | { |
1336 | struct mmc_host *mmc = platform_get_drvdata(pdev); | 1348 | struct mmc_host *mmc = platform_get_drvdata(pdev); |
1337 | struct s3cmci_host *host = mmc_priv(mmc); | 1349 | struct s3cmci_host *host = mmc_priv(mmc); |
1338 | 1350 | ||
1339 | mmc_remove_host(mmc); | 1351 | s3cmci_shutdown(pdev); |
1340 | 1352 | ||
1341 | clk_disable(host->clk); | ||
1342 | clk_put(host->clk); | 1353 | clk_put(host->clk); |
1343 | 1354 | ||
1344 | tasklet_disable(&host->pio_tasklet); | 1355 | tasklet_disable(&host->pio_tasklet); |
1345 | s3c2410_dma_free(S3CMCI_DMA, &s3cmci_dma_client); | 1356 | s3c2410_dma_free(S3CMCI_DMA, &s3cmci_dma_client); |
1346 | 1357 | ||
1347 | if (host->irq_cd >= 0) | ||
1348 | free_irq(host->irq_cd, host); | ||
1349 | free_irq(host->irq, host); | 1358 | free_irq(host->irq, host); |
1350 | 1359 | ||
1351 | iounmap(host->base); | 1360 | iounmap(host->base); |
@@ -1355,17 +1364,17 @@ static int __devexit s3cmci_remove(struct platform_device *pdev) | |||
1355 | return 0; | 1364 | return 0; |
1356 | } | 1365 | } |
1357 | 1366 | ||
1358 | static int __devinit s3cmci_probe_2410(struct platform_device *dev) | 1367 | static int __devinit s3cmci_2410_probe(struct platform_device *dev) |
1359 | { | 1368 | { |
1360 | return s3cmci_probe(dev, 0); | 1369 | return s3cmci_probe(dev, 0); |
1361 | } | 1370 | } |
1362 | 1371 | ||
1363 | static int __devinit s3cmci_probe_2412(struct platform_device *dev) | 1372 | static int __devinit s3cmci_2412_probe(struct platform_device *dev) |
1364 | { | 1373 | { |
1365 | return s3cmci_probe(dev, 1); | 1374 | return s3cmci_probe(dev, 1); |
1366 | } | 1375 | } |
1367 | 1376 | ||
1368 | static int __devinit s3cmci_probe_2440(struct platform_device *dev) | 1377 | static int __devinit s3cmci_2440_probe(struct platform_device *dev) |
1369 | { | 1378 | { |
1370 | return s3cmci_probe(dev, 1); | 1379 | return s3cmci_probe(dev, 1); |
1371 | } | 1380 | } |
@@ -1392,29 +1401,32 @@ static int s3cmci_resume(struct platform_device *dev) | |||
1392 | #endif /* CONFIG_PM */ | 1401 | #endif /* CONFIG_PM */ |
1393 | 1402 | ||
1394 | 1403 | ||
1395 | static struct platform_driver s3cmci_driver_2410 = { | 1404 | static struct platform_driver s3cmci_2410_driver = { |
1396 | .driver.name = "s3c2410-sdi", | 1405 | .driver.name = "s3c2410-sdi", |
1397 | .driver.owner = THIS_MODULE, | 1406 | .driver.owner = THIS_MODULE, |
1398 | .probe = s3cmci_probe_2410, | 1407 | .probe = s3cmci_2410_probe, |
1399 | .remove = __devexit_p(s3cmci_remove), | 1408 | .remove = __devexit_p(s3cmci_remove), |
1409 | .shutdown = s3cmci_shutdown, | ||
1400 | .suspend = s3cmci_suspend, | 1410 | .suspend = s3cmci_suspend, |
1401 | .resume = s3cmci_resume, | 1411 | .resume = s3cmci_resume, |
1402 | }; | 1412 | }; |
1403 | 1413 | ||
1404 | static struct platform_driver s3cmci_driver_2412 = { | 1414 | static struct platform_driver s3cmci_2412_driver = { |
1405 | .driver.name = "s3c2412-sdi", | 1415 | .driver.name = "s3c2412-sdi", |
1406 | .driver.owner = THIS_MODULE, | 1416 | .driver.owner = THIS_MODULE, |
1407 | .probe = s3cmci_probe_2412, | 1417 | .probe = s3cmci_2412_probe, |
1408 | .remove = __devexit_p(s3cmci_remove), | 1418 | .remove = __devexit_p(s3cmci_remove), |
1419 | .shutdown = s3cmci_shutdown, | ||
1409 | .suspend = s3cmci_suspend, | 1420 | .suspend = s3cmci_suspend, |
1410 | .resume = s3cmci_resume, | 1421 | .resume = s3cmci_resume, |
1411 | }; | 1422 | }; |
1412 | 1423 | ||
1413 | static struct platform_driver s3cmci_driver_2440 = { | 1424 | static struct platform_driver s3cmci_2440_driver = { |
1414 | .driver.name = "s3c2440-sdi", | 1425 | .driver.name = "s3c2440-sdi", |
1415 | .driver.owner = THIS_MODULE, | 1426 | .driver.owner = THIS_MODULE, |
1416 | .probe = s3cmci_probe_2440, | 1427 | .probe = s3cmci_2440_probe, |
1417 | .remove = __devexit_p(s3cmci_remove), | 1428 | .remove = __devexit_p(s3cmci_remove), |
1429 | .shutdown = s3cmci_shutdown, | ||
1418 | .suspend = s3cmci_suspend, | 1430 | .suspend = s3cmci_suspend, |
1419 | .resume = s3cmci_resume, | 1431 | .resume = s3cmci_resume, |
1420 | }; | 1432 | }; |
@@ -1422,17 +1434,17 @@ static struct platform_driver s3cmci_driver_2440 = { | |||
1422 | 1434 | ||
1423 | static int __init s3cmci_init(void) | 1435 | static int __init s3cmci_init(void) |
1424 | { | 1436 | { |
1425 | platform_driver_register(&s3cmci_driver_2410); | 1437 | platform_driver_register(&s3cmci_2410_driver); |
1426 | platform_driver_register(&s3cmci_driver_2412); | 1438 | platform_driver_register(&s3cmci_2412_driver); |
1427 | platform_driver_register(&s3cmci_driver_2440); | 1439 | platform_driver_register(&s3cmci_2440_driver); |
1428 | return 0; | 1440 | return 0; |
1429 | } | 1441 | } |
1430 | 1442 | ||
1431 | static void __exit s3cmci_exit(void) | 1443 | static void __exit s3cmci_exit(void) |
1432 | { | 1444 | { |
1433 | platform_driver_unregister(&s3cmci_driver_2410); | 1445 | platform_driver_unregister(&s3cmci_2410_driver); |
1434 | platform_driver_unregister(&s3cmci_driver_2412); | 1446 | platform_driver_unregister(&s3cmci_2412_driver); |
1435 | platform_driver_unregister(&s3cmci_driver_2440); | 1447 | platform_driver_unregister(&s3cmci_2440_driver); |
1436 | } | 1448 | } |
1437 | 1449 | ||
1438 | module_init(s3cmci_init); | 1450 | module_init(s3cmci_init); |
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 17701c3da733..c3a5db72ddd7 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c | |||
@@ -173,119 +173,95 @@ static void sdhci_led_control(struct led_classdev *led, | |||
173 | * * | 173 | * * |
174 | \*****************************************************************************/ | 174 | \*****************************************************************************/ |
175 | 175 | ||
176 | static inline char* sdhci_sg_to_buffer(struct sdhci_host* host) | ||
177 | { | ||
178 | return sg_virt(host->cur_sg); | ||
179 | } | ||
180 | |||
181 | static inline int sdhci_next_sg(struct sdhci_host* host) | ||
182 | { | ||
183 | /* | ||
184 | * Skip to next SG entry. | ||
185 | */ | ||
186 | host->cur_sg++; | ||
187 | host->num_sg--; | ||
188 | |||
189 | /* | ||
190 | * Any entries left? | ||
191 | */ | ||
192 | if (host->num_sg > 0) { | ||
193 | host->offset = 0; | ||
194 | host->remain = host->cur_sg->length; | ||
195 | } | ||
196 | |||
197 | return host->num_sg; | ||
198 | } | ||
199 | |||
200 | static void sdhci_read_block_pio(struct sdhci_host *host) | 176 | static void sdhci_read_block_pio(struct sdhci_host *host) |
201 | { | 177 | { |
202 | int blksize, chunk_remain; | 178 | unsigned long flags; |
203 | u32 data; | 179 | size_t blksize, len, chunk; |
204 | char *buffer; | 180 | u32 scratch; |
205 | int size; | 181 | u8 *buf; |
206 | 182 | ||
207 | DBG("PIO reading\n"); | 183 | DBG("PIO reading\n"); |
208 | 184 | ||
209 | blksize = host->data->blksz; | 185 | blksize = host->data->blksz; |
210 | chunk_remain = 0; | 186 | chunk = 0; |
211 | data = 0; | ||
212 | 187 | ||
213 | buffer = sdhci_sg_to_buffer(host) + host->offset; | 188 | local_irq_save(flags); |
214 | 189 | ||
215 | while (blksize) { | 190 | while (blksize) { |
216 | if (chunk_remain == 0) { | 191 | if (!sg_miter_next(&host->sg_miter)) |
217 | data = readl(host->ioaddr + SDHCI_BUFFER); | 192 | BUG(); |
218 | chunk_remain = min(blksize, 4); | ||
219 | } | ||
220 | 193 | ||
221 | size = min(host->remain, chunk_remain); | 194 | len = min(host->sg_miter.length, blksize); |
222 | 195 | ||
223 | chunk_remain -= size; | 196 | blksize -= len; |
224 | blksize -= size; | 197 | host->sg_miter.consumed = len; |
225 | host->offset += size; | ||
226 | host->remain -= size; | ||
227 | 198 | ||
228 | while (size) { | 199 | buf = host->sg_miter.addr; |
229 | *buffer = data & 0xFF; | ||
230 | buffer++; | ||
231 | data >>= 8; | ||
232 | size--; | ||
233 | } | ||
234 | 200 | ||
235 | if (host->remain == 0) { | 201 | while (len) { |
236 | if (sdhci_next_sg(host) == 0) { | 202 | if (chunk == 0) { |
237 | BUG_ON(blksize != 0); | 203 | scratch = readl(host->ioaddr + SDHCI_BUFFER); |
238 | return; | 204 | chunk = 4; |
239 | } | 205 | } |
240 | buffer = sdhci_sg_to_buffer(host); | 206 | |
207 | *buf = scratch & 0xFF; | ||
208 | |||
209 | buf++; | ||
210 | scratch >>= 8; | ||
211 | chunk--; | ||
212 | len--; | ||
241 | } | 213 | } |
242 | } | 214 | } |
215 | |||
216 | sg_miter_stop(&host->sg_miter); | ||
217 | |||
218 | local_irq_restore(flags); | ||
243 | } | 219 | } |
244 | 220 | ||
245 | static void sdhci_write_block_pio(struct sdhci_host *host) | 221 | static void sdhci_write_block_pio(struct sdhci_host *host) |
246 | { | 222 | { |
247 | int blksize, chunk_remain; | 223 | unsigned long flags; |
248 | u32 data; | 224 | size_t blksize, len, chunk; |
249 | char *buffer; | 225 | u32 scratch; |
250 | int bytes, size; | 226 | u8 *buf; |
251 | 227 | ||
252 | DBG("PIO writing\n"); | 228 | DBG("PIO writing\n"); |
253 | 229 | ||
254 | blksize = host->data->blksz; | 230 | blksize = host->data->blksz; |
255 | chunk_remain = 4; | 231 | chunk = 0; |
256 | data = 0; | 232 | scratch = 0; |
257 | 233 | ||
258 | bytes = 0; | 234 | local_irq_save(flags); |
259 | buffer = sdhci_sg_to_buffer(host) + host->offset; | ||
260 | 235 | ||
261 | while (blksize) { | 236 | while (blksize) { |
262 | size = min(host->remain, chunk_remain); | 237 | if (!sg_miter_next(&host->sg_miter)) |
263 | 238 | BUG(); | |
264 | chunk_remain -= size; | ||
265 | blksize -= size; | ||
266 | host->offset += size; | ||
267 | host->remain -= size; | ||
268 | |||
269 | while (size) { | ||
270 | data >>= 8; | ||
271 | data |= (u32)*buffer << 24; | ||
272 | buffer++; | ||
273 | size--; | ||
274 | } | ||
275 | 239 | ||
276 | if (chunk_remain == 0) { | 240 | len = min(host->sg_miter.length, blksize); |
277 | writel(data, host->ioaddr + SDHCI_BUFFER); | 241 | |
278 | chunk_remain = min(blksize, 4); | 242 | blksize -= len; |
279 | } | 243 | host->sg_miter.consumed = len; |
244 | |||
245 | buf = host->sg_miter.addr; | ||
280 | 246 | ||
281 | if (host->remain == 0) { | 247 | while (len) { |
282 | if (sdhci_next_sg(host) == 0) { | 248 | scratch |= (u32)*buf << (chunk * 8); |
283 | BUG_ON(blksize != 0); | 249 | |
284 | return; | 250 | buf++; |
251 | chunk++; | ||
252 | len--; | ||
253 | |||
254 | if ((chunk == 4) || ((len == 0) && (blksize == 0))) { | ||
255 | writel(scratch, host->ioaddr + SDHCI_BUFFER); | ||
256 | chunk = 0; | ||
257 | scratch = 0; | ||
285 | } | 258 | } |
286 | buffer = sdhci_sg_to_buffer(host); | ||
287 | } | 259 | } |
288 | } | 260 | } |
261 | |||
262 | sg_miter_stop(&host->sg_miter); | ||
263 | |||
264 | local_irq_restore(flags); | ||
289 | } | 265 | } |
290 | 266 | ||
291 | static void sdhci_transfer_pio(struct sdhci_host *host) | 267 | static void sdhci_transfer_pio(struct sdhci_host *host) |
@@ -294,7 +270,7 @@ static void sdhci_transfer_pio(struct sdhci_host *host) | |||
294 | 270 | ||
295 | BUG_ON(!host->data); | 271 | BUG_ON(!host->data); |
296 | 272 | ||
297 | if (host->num_sg == 0) | 273 | if (host->blocks == 0) |
298 | return; | 274 | return; |
299 | 275 | ||
300 | if (host->data->flags & MMC_DATA_READ) | 276 | if (host->data->flags & MMC_DATA_READ) |
@@ -308,7 +284,8 @@ static void sdhci_transfer_pio(struct sdhci_host *host) | |||
308 | else | 284 | else |
309 | sdhci_write_block_pio(host); | 285 | sdhci_write_block_pio(host); |
310 | 286 | ||
311 | if (host->num_sg == 0) | 287 | host->blocks--; |
288 | if (host->blocks == 0) | ||
312 | break; | 289 | break; |
313 | } | 290 | } |
314 | 291 | ||
@@ -389,6 +366,7 @@ static int sdhci_adma_table_pre(struct sdhci_host *host, | |||
389 | if (offset) { | 366 | if (offset) { |
390 | if (data->flags & MMC_DATA_WRITE) { | 367 | if (data->flags & MMC_DATA_WRITE) { |
391 | buffer = sdhci_kmap_atomic(sg, &flags); | 368 | buffer = sdhci_kmap_atomic(sg, &flags); |
369 | WARN_ON(((long)buffer & PAGE_MASK) > (PAGE_SIZE - 3)); | ||
392 | memcpy(align, buffer, offset); | 370 | memcpy(align, buffer, offset); |
393 | sdhci_kunmap_atomic(buffer, &flags); | 371 | sdhci_kunmap_atomic(buffer, &flags); |
394 | } | 372 | } |
@@ -510,6 +488,7 @@ static void sdhci_adma_table_post(struct sdhci_host *host, | |||
510 | size = 4 - (sg_dma_address(sg) & 0x3); | 488 | size = 4 - (sg_dma_address(sg) & 0x3); |
511 | 489 | ||
512 | buffer = sdhci_kmap_atomic(sg, &flags); | 490 | buffer = sdhci_kmap_atomic(sg, &flags); |
491 | WARN_ON(((long)buffer & PAGE_MASK) > (PAGE_SIZE - 3)); | ||
513 | memcpy(buffer, align, size); | 492 | memcpy(buffer, align, size); |
514 | sdhci_kunmap_atomic(buffer, &flags); | 493 | sdhci_kunmap_atomic(buffer, &flags); |
515 | 494 | ||
@@ -687,7 +666,7 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_data *data) | |||
687 | WARN_ON(1); | 666 | WARN_ON(1); |
688 | host->flags &= ~SDHCI_USE_DMA; | 667 | host->flags &= ~SDHCI_USE_DMA; |
689 | } else { | 668 | } else { |
690 | WARN_ON(count != 1); | 669 | WARN_ON(sg_cnt != 1); |
691 | writel(sg_dma_address(data->sg), | 670 | writel(sg_dma_address(data->sg), |
692 | host->ioaddr + SDHCI_DMA_ADDRESS); | 671 | host->ioaddr + SDHCI_DMA_ADDRESS); |
693 | } | 672 | } |
@@ -711,11 +690,9 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_data *data) | |||
711 | } | 690 | } |
712 | 691 | ||
713 | if (!(host->flags & SDHCI_REQ_USE_DMA)) { | 692 | if (!(host->flags & SDHCI_REQ_USE_DMA)) { |
714 | host->cur_sg = data->sg; | 693 | sg_miter_start(&host->sg_miter, |
715 | host->num_sg = data->sg_len; | 694 | data->sg, data->sg_len, SG_MITER_ATOMIC); |
716 | 695 | host->blocks = data->blocks; | |
717 | host->offset = 0; | ||
718 | host->remain = host->cur_sg->length; | ||
719 | } | 696 | } |
720 | 697 | ||
721 | /* We do not handle DMA boundaries, so set it to max (512 KiB) */ | 698 | /* We do not handle DMA boundaries, so set it to max (512 KiB) */ |
@@ -1581,9 +1558,15 @@ int sdhci_add_host(struct sdhci_host *host) | |||
1581 | } | 1558 | } |
1582 | } | 1559 | } |
1583 | 1560 | ||
1584 | /* XXX: Hack to get MMC layer to avoid highmem */ | 1561 | /* |
1585 | if (!(host->flags & SDHCI_USE_DMA)) | 1562 | * If we use DMA, then it's up to the caller to set the DMA |
1586 | mmc_dev(host->mmc)->dma_mask = NULL; | 1563 | * mask, but PIO does not need the hw shim so we set a new |
1564 | * mask here in that case. | ||
1565 | */ | ||
1566 | if (!(host->flags & SDHCI_USE_DMA)) { | ||
1567 | host->dma_mask = DMA_BIT_MASK(64); | ||
1568 | mmc_dev(host->mmc)->dma_mask = &host->dma_mask; | ||
1569 | } | ||
1587 | 1570 | ||
1588 | host->max_clk = | 1571 | host->max_clk = |
1589 | (caps & SDHCI_CLOCK_BASE_MASK) >> SDHCI_CLOCK_BASE_SHIFT; | 1572 | (caps & SDHCI_CLOCK_BASE_MASK) >> SDHCI_CLOCK_BASE_SHIFT; |
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 5bb355281765..a06bf8b89343 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h | |||
@@ -212,6 +212,7 @@ struct sdhci_host { | |||
212 | 212 | ||
213 | /* Internal data */ | 213 | /* Internal data */ |
214 | struct mmc_host *mmc; /* MMC structure */ | 214 | struct mmc_host *mmc; /* MMC structure */ |
215 | u64 dma_mask; /* custom DMA mask */ | ||
215 | 216 | ||
216 | #ifdef CONFIG_LEDS_CLASS | 217 | #ifdef CONFIG_LEDS_CLASS |
217 | struct led_classdev led; /* LED control */ | 218 | struct led_classdev led; /* LED control */ |
@@ -238,10 +239,8 @@ struct sdhci_host { | |||
238 | struct mmc_data *data; /* Current data request */ | 239 | struct mmc_data *data; /* Current data request */ |
239 | unsigned int data_early:1; /* Data finished before cmd */ | 240 | unsigned int data_early:1; /* Data finished before cmd */ |
240 | 241 | ||
241 | struct scatterlist *cur_sg; /* We're working on this */ | 242 | struct sg_mapping_iter sg_miter; /* SG state for PIO */ |
242 | int num_sg; /* Entries left */ | 243 | unsigned int blocks; /* remaining PIO blocks */ |
243 | int offset; /* Offset into current sg */ | ||
244 | int remain; /* Bytes left in current */ | ||
245 | 244 | ||
246 | int sg_count; /* Mapped sg entries */ | 245 | int sg_count; /* Mapped sg entries */ |
247 | 246 | ||
diff --git a/include/linux/scatterlist.h b/include/linux/scatterlist.h index 71fc81360048..e5996984ddd0 100644 --- a/include/linux/scatterlist.h +++ b/include/linux/scatterlist.h | |||
@@ -224,4 +224,42 @@ size_t sg_copy_to_buffer(struct scatterlist *sgl, unsigned int nents, | |||
224 | */ | 224 | */ |
225 | #define SG_MAX_SINGLE_ALLOC (PAGE_SIZE / sizeof(struct scatterlist)) | 225 | #define SG_MAX_SINGLE_ALLOC (PAGE_SIZE / sizeof(struct scatterlist)) |
226 | 226 | ||
227 | |||
228 | /* | ||
229 | * Mapping sg iterator | ||
230 | * | ||
231 | * Iterates over sg entries mapping page-by-page. On each successful | ||
232 | * iteration, @miter->page points to the mapped page and | ||
233 | * @miter->length bytes of data can be accessed at @miter->addr. As | ||
234 | * long as an interation is enclosed between start and stop, the user | ||
235 | * is free to choose control structure and when to stop. | ||
236 | * | ||
237 | * @miter->consumed is set to @miter->length on each iteration. It | ||
238 | * can be adjusted if the user can't consume all the bytes in one go. | ||
239 | * Also, a stopped iteration can be resumed by calling next on it. | ||
240 | * This is useful when iteration needs to release all resources and | ||
241 | * continue later (e.g. at the next interrupt). | ||
242 | */ | ||
243 | |||
244 | #define SG_MITER_ATOMIC (1 << 0) /* use kmap_atomic */ | ||
245 | |||
246 | struct sg_mapping_iter { | ||
247 | /* the following three fields can be accessed directly */ | ||
248 | struct page *page; /* currently mapped page */ | ||
249 | void *addr; /* pointer to the mapped area */ | ||
250 | size_t length; /* length of the mapped area */ | ||
251 | size_t consumed; /* number of consumed bytes */ | ||
252 | |||
253 | /* these are internal states, keep away */ | ||
254 | struct scatterlist *__sg; /* current entry */ | ||
255 | unsigned int __nents; /* nr of remaining entries */ | ||
256 | unsigned int __offset; /* offset within sg */ | ||
257 | unsigned int __flags; | ||
258 | }; | ||
259 | |||
260 | void sg_miter_start(struct sg_mapping_iter *miter, struct scatterlist *sgl, | ||
261 | unsigned int nents, unsigned int flags); | ||
262 | bool sg_miter_next(struct sg_mapping_iter *miter); | ||
263 | void sg_miter_stop(struct sg_mapping_iter *miter); | ||
264 | |||
227 | #endif /* _LINUX_SCATTERLIST_H */ | 265 | #endif /* _LINUX_SCATTERLIST_H */ |
diff --git a/lib/scatterlist.c b/lib/scatterlist.c index b80c21100d78..876ba6d5b670 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c | |||
@@ -295,6 +295,117 @@ int sg_alloc_table(struct sg_table *table, unsigned int nents, gfp_t gfp_mask) | |||
295 | EXPORT_SYMBOL(sg_alloc_table); | 295 | EXPORT_SYMBOL(sg_alloc_table); |
296 | 296 | ||
297 | /** | 297 | /** |
298 | * sg_miter_start - start mapping iteration over a sg list | ||
299 | * @miter: sg mapping iter to be started | ||
300 | * @sgl: sg list to iterate over | ||
301 | * @nents: number of sg entries | ||
302 | * | ||
303 | * Description: | ||
304 | * Starts mapping iterator @miter. | ||
305 | * | ||
306 | * Context: | ||
307 | * Don't care. | ||
308 | */ | ||
309 | void sg_miter_start(struct sg_mapping_iter *miter, struct scatterlist *sgl, | ||
310 | unsigned int nents, unsigned int flags) | ||
311 | { | ||
312 | memset(miter, 0, sizeof(struct sg_mapping_iter)); | ||
313 | |||
314 | miter->__sg = sgl; | ||
315 | miter->__nents = nents; | ||
316 | miter->__offset = 0; | ||
317 | miter->__flags = flags; | ||
318 | } | ||
319 | EXPORT_SYMBOL(sg_miter_start); | ||
320 | |||
321 | /** | ||
322 | * sg_miter_next - proceed mapping iterator to the next mapping | ||
323 | * @miter: sg mapping iter to proceed | ||
324 | * | ||
325 | * Description: | ||
326 | * Proceeds @miter@ to the next mapping. @miter@ should have been | ||
327 | * started using sg_miter_start(). On successful return, | ||
328 | * @miter@->page, @miter@->addr and @miter@->length point to the | ||
329 | * current mapping. | ||
330 | * | ||
331 | * Context: | ||
332 | * IRQ disabled if SG_MITER_ATOMIC. IRQ must stay disabled till | ||
333 | * @miter@ is stopped. May sleep if !SG_MITER_ATOMIC. | ||
334 | * | ||
335 | * Returns: | ||
336 | * true if @miter contains the next mapping. false if end of sg | ||
337 | * list is reached. | ||
338 | */ | ||
339 | bool sg_miter_next(struct sg_mapping_iter *miter) | ||
340 | { | ||
341 | unsigned int off, len; | ||
342 | |||
343 | /* check for end and drop resources from the last iteration */ | ||
344 | if (!miter->__nents) | ||
345 | return false; | ||
346 | |||
347 | sg_miter_stop(miter); | ||
348 | |||
349 | /* get to the next sg if necessary. __offset is adjusted by stop */ | ||
350 | if (miter->__offset == miter->__sg->length && --miter->__nents) { | ||
351 | miter->__sg = sg_next(miter->__sg); | ||
352 | miter->__offset = 0; | ||
353 | } | ||
354 | |||
355 | /* map the next page */ | ||
356 | off = miter->__sg->offset + miter->__offset; | ||
357 | len = miter->__sg->length - miter->__offset; | ||
358 | |||
359 | miter->page = nth_page(sg_page(miter->__sg), off >> PAGE_SHIFT); | ||
360 | off &= ~PAGE_MASK; | ||
361 | miter->length = min_t(unsigned int, len, PAGE_SIZE - off); | ||
362 | miter->consumed = miter->length; | ||
363 | |||
364 | if (miter->__flags & SG_MITER_ATOMIC) | ||
365 | miter->addr = kmap_atomic(miter->page, KM_BIO_SRC_IRQ) + off; | ||
366 | else | ||
367 | miter->addr = kmap(miter->page) + off; | ||
368 | |||
369 | return true; | ||
370 | } | ||
371 | EXPORT_SYMBOL(sg_miter_next); | ||
372 | |||
373 | /** | ||
374 | * sg_miter_stop - stop mapping iteration | ||
375 | * @miter: sg mapping iter to be stopped | ||
376 | * | ||
377 | * Description: | ||
378 | * Stops mapping iterator @miter. @miter should have been started | ||
379 | * started using sg_miter_start(). A stopped iteration can be | ||
380 | * resumed by calling sg_miter_next() on it. This is useful when | ||
381 | * resources (kmap) need to be released during iteration. | ||
382 | * | ||
383 | * Context: | ||
384 | * IRQ disabled if the SG_MITER_ATOMIC is set. Don't care otherwise. | ||
385 | */ | ||
386 | void sg_miter_stop(struct sg_mapping_iter *miter) | ||
387 | { | ||
388 | WARN_ON(miter->consumed > miter->length); | ||
389 | |||
390 | /* drop resources from the last iteration */ | ||
391 | if (miter->addr) { | ||
392 | miter->__offset += miter->consumed; | ||
393 | |||
394 | if (miter->__flags & SG_MITER_ATOMIC) { | ||
395 | WARN_ON(!irqs_disabled()); | ||
396 | kunmap_atomic(miter->addr, KM_BIO_SRC_IRQ); | ||
397 | } else | ||
398 | kunmap(miter->addr); | ||
399 | |||
400 | miter->page = NULL; | ||
401 | miter->addr = NULL; | ||
402 | miter->length = 0; | ||
403 | miter->consumed = 0; | ||
404 | } | ||
405 | } | ||
406 | EXPORT_SYMBOL(sg_miter_stop); | ||
407 | |||
408 | /** | ||
298 | * sg_copy_buffer - Copy data between a linear buffer and an SG list | 409 | * sg_copy_buffer - Copy data between a linear buffer and an SG list |
299 | * @sgl: The SG list | 410 | * @sgl: The SG list |
300 | * @nents: Number of SG entries | 411 | * @nents: Number of SG entries |
@@ -309,56 +420,29 @@ EXPORT_SYMBOL(sg_alloc_table); | |||
309 | static size_t sg_copy_buffer(struct scatterlist *sgl, unsigned int nents, | 420 | static size_t sg_copy_buffer(struct scatterlist *sgl, unsigned int nents, |
310 | void *buf, size_t buflen, int to_buffer) | 421 | void *buf, size_t buflen, int to_buffer) |
311 | { | 422 | { |
312 | struct scatterlist *sg; | 423 | unsigned int offset = 0; |
313 | size_t buf_off = 0; | 424 | struct sg_mapping_iter miter; |
314 | int i; | 425 | |
315 | 426 | sg_miter_start(&miter, sgl, nents, SG_MITER_ATOMIC); | |
316 | WARN_ON(!irqs_disabled()); | 427 | |
317 | 428 | while (sg_miter_next(&miter) && offset < buflen) { | |
318 | for_each_sg(sgl, sg, nents, i) { | 429 | unsigned int len; |
319 | struct page *page; | 430 | |
320 | int n = 0; | 431 | len = min(miter.length, buflen - offset); |
321 | unsigned int sg_off = sg->offset; | 432 | |
322 | unsigned int sg_copy = sg->length; | 433 | if (to_buffer) |
323 | 434 | memcpy(buf + offset, miter.addr, len); | |
324 | if (sg_copy > buflen) | 435 | else { |
325 | sg_copy = buflen; | 436 | memcpy(miter.addr, buf + offset, len); |
326 | buflen -= sg_copy; | 437 | flush_kernel_dcache_page(miter.page); |
327 | |||
328 | while (sg_copy > 0) { | ||
329 | unsigned int page_copy; | ||
330 | void *p; | ||
331 | |||
332 | page_copy = PAGE_SIZE - sg_off; | ||
333 | if (page_copy > sg_copy) | ||
334 | page_copy = sg_copy; | ||
335 | |||
336 | page = nth_page(sg_page(sg), n); | ||
337 | p = kmap_atomic(page, KM_BIO_SRC_IRQ); | ||
338 | |||
339 | if (to_buffer) | ||
340 | memcpy(buf + buf_off, p + sg_off, page_copy); | ||
341 | else { | ||
342 | memcpy(p + sg_off, buf + buf_off, page_copy); | ||
343 | flush_kernel_dcache_page(page); | ||
344 | } | ||
345 | |||
346 | kunmap_atomic(p, KM_BIO_SRC_IRQ); | ||
347 | |||
348 | buf_off += page_copy; | ||
349 | sg_off += page_copy; | ||
350 | if (sg_off == PAGE_SIZE) { | ||
351 | sg_off = 0; | ||
352 | n++; | ||
353 | } | ||
354 | sg_copy -= page_copy; | ||
355 | } | 438 | } |
356 | 439 | ||
357 | if (!buflen) | 440 | offset += len; |
358 | break; | ||
359 | } | 441 | } |
360 | 442 | ||
361 | return buf_off; | 443 | sg_miter_stop(&miter); |
444 | |||
445 | return offset; | ||
362 | } | 446 | } |
363 | 447 | ||
364 | /** | 448 | /** |