diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-05-21 15:52:33 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-07-22 00:54:42 -0400 |
commit | 1e2744011ff3cd195aba9f7a15dd71b332812a5c (patch) | |
tree | 7a2abfa8cd97eca7ff5236db71db978431c5da7e | |
parent | e282959ef3ebae0d72ac0b24242c376fa34da585 (diff) |
device create: framebuffer: convert device_create to device_create_drvdata
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.
Cc: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/video/console/fbcon.c | 3 | ||||
-rw-r--r-- | drivers/video/fbmem.c | 5 |
2 files changed, 5 insertions, 3 deletions
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 97aff8db10bf..4be3b46c069b 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c | |||
@@ -3586,7 +3586,8 @@ static int __init fb_console_init(void) | |||
3586 | 3586 | ||
3587 | acquire_console_sem(); | 3587 | acquire_console_sem(); |
3588 | fb_register_client(&fbcon_event_notifier); | 3588 | fb_register_client(&fbcon_event_notifier); |
3589 | fbcon_device = device_create(fb_class, NULL, MKDEV(0, 0), "fbcon"); | 3589 | fbcon_device = device_create_drvdata(fb_class, NULL, MKDEV(0, 0), |
3590 | NULL, "fbcon"); | ||
3590 | 3591 | ||
3591 | if (IS_ERR(fbcon_device)) { | 3592 | if (IS_ERR(fbcon_device)) { |
3592 | printk(KERN_WARNING "Unable to create device " | 3593 | printk(KERN_WARNING "Unable to create device " |
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 33ebdb198daf..1cd5071e5362 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c | |||
@@ -1439,8 +1439,9 @@ register_framebuffer(struct fb_info *fb_info) | |||
1439 | break; | 1439 | break; |
1440 | fb_info->node = i; | 1440 | fb_info->node = i; |
1441 | 1441 | ||
1442 | fb_info->dev = device_create(fb_class, fb_info->device, | 1442 | fb_info->dev = device_create_drvdata(fb_class, fb_info->device, |
1443 | MKDEV(FB_MAJOR, i), "fb%d", i); | 1443 | MKDEV(FB_MAJOR, i), NULL, |
1444 | "fb%d", i); | ||
1444 | if (IS_ERR(fb_info->dev)) { | 1445 | if (IS_ERR(fb_info->dev)) { |
1445 | /* Not fatal */ | 1446 | /* Not fatal */ |
1446 | printk(KERN_WARNING "Unable to create device for framebuffer %d; errno = %ld\n", i, PTR_ERR(fb_info->dev)); | 1447 | printk(KERN_WARNING "Unable to create device for framebuffer %d; errno = %ld\n", i, PTR_ERR(fb_info->dev)); |