diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2008-07-28 13:16:30 -0400 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2008-07-27 22:16:31 -0400 |
commit | 9b1a4d38373a5581a4e01032a3ccdd94cd93477b (patch) | |
tree | 3d0f0ebd1ac4512551fc35e57d173870eb060c0c | |
parent | eeec4fad963490821348a331cca6102ae1c4a7a3 (diff) |
stop_machine: Wean existing callers off stop_machine_run()
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r-- | arch/s390/kernel/kprobes.c | 6 | ||||
-rw-r--r-- | drivers/char/hw_random/intel-rng.c | 6 | ||||
-rw-r--r-- | kernel/module.c | 8 | ||||
-rw-r--r-- | kernel/rcuclassic.c | 4 | ||||
-rw-r--r-- | mm/page_alloc.c | 4 |
5 files changed, 14 insertions, 14 deletions
diff --git a/arch/s390/kernel/kprobes.c b/arch/s390/kernel/kprobes.c index 4f82e5b5f879..569079ec4ff0 100644 --- a/arch/s390/kernel/kprobes.c +++ b/arch/s390/kernel/kprobes.c | |||
@@ -197,7 +197,7 @@ void __kprobes arch_arm_kprobe(struct kprobe *p) | |||
197 | args.new = BREAKPOINT_INSTRUCTION; | 197 | args.new = BREAKPOINT_INSTRUCTION; |
198 | 198 | ||
199 | kcb->kprobe_status = KPROBE_SWAP_INST; | 199 | kcb->kprobe_status = KPROBE_SWAP_INST; |
200 | stop_machine_run(swap_instruction, &args, NR_CPUS); | 200 | stop_machine(swap_instruction, &args, NULL); |
201 | kcb->kprobe_status = status; | 201 | kcb->kprobe_status = status; |
202 | } | 202 | } |
203 | 203 | ||
@@ -212,7 +212,7 @@ void __kprobes arch_disarm_kprobe(struct kprobe *p) | |||
212 | args.new = p->opcode; | 212 | args.new = p->opcode; |
213 | 213 | ||
214 | kcb->kprobe_status = KPROBE_SWAP_INST; | 214 | kcb->kprobe_status = KPROBE_SWAP_INST; |
215 | stop_machine_run(swap_instruction, &args, NR_CPUS); | 215 | stop_machine(swap_instruction, &args, NULL); |
216 | kcb->kprobe_status = status; | 216 | kcb->kprobe_status = status; |
217 | } | 217 | } |
218 | 218 | ||
@@ -331,7 +331,7 @@ static int __kprobes kprobe_handler(struct pt_regs *regs) | |||
331 | * No kprobe at this address. The fault has not been | 331 | * No kprobe at this address. The fault has not been |
332 | * caused by a kprobe breakpoint. The race of breakpoint | 332 | * caused by a kprobe breakpoint. The race of breakpoint |
333 | * vs. kprobe remove does not exist because on s390 we | 333 | * vs. kprobe remove does not exist because on s390 we |
334 | * use stop_machine_run to arm/disarm the breakpoints. | 334 | * use stop_machine to arm/disarm the breakpoints. |
335 | */ | 335 | */ |
336 | goto no_kprobe; | 336 | goto no_kprobe; |
337 | 337 | ||
diff --git a/drivers/char/hw_random/intel-rng.c b/drivers/char/hw_random/intel-rng.c index 27fdc0866496..8a2fce0756ec 100644 --- a/drivers/char/hw_random/intel-rng.c +++ b/drivers/char/hw_random/intel-rng.c | |||
@@ -241,7 +241,7 @@ static int __init intel_rng_hw_init(void *_intel_rng_hw) | |||
241 | struct intel_rng_hw *intel_rng_hw = _intel_rng_hw; | 241 | struct intel_rng_hw *intel_rng_hw = _intel_rng_hw; |
242 | u8 mfc, dvc; | 242 | u8 mfc, dvc; |
243 | 243 | ||
244 | /* interrupts disabled in stop_machine_run call */ | 244 | /* interrupts disabled in stop_machine call */ |
245 | 245 | ||
246 | if (!(intel_rng_hw->fwh_dec_en1_val & FWH_F8_EN_MASK)) | 246 | if (!(intel_rng_hw->fwh_dec_en1_val & FWH_F8_EN_MASK)) |
247 | pci_write_config_byte(intel_rng_hw->dev, | 247 | pci_write_config_byte(intel_rng_hw->dev, |
@@ -365,10 +365,10 @@ static int __init mod_init(void) | |||
365 | * location with the Read ID command, all activity on the system | 365 | * location with the Read ID command, all activity on the system |
366 | * must be stopped until the state is back to normal. | 366 | * must be stopped until the state is back to normal. |
367 | * | 367 | * |
368 | * Use stop_machine_run because IPIs can be blocked by disabling | 368 | * Use stop_machine because IPIs can be blocked by disabling |
369 | * interrupts. | 369 | * interrupts. |
370 | */ | 370 | */ |
371 | err = stop_machine_run(intel_rng_hw_init, intel_rng_hw, NR_CPUS); | 371 | err = stop_machine(intel_rng_hw_init, intel_rng_hw, NULL); |
372 | pci_dev_put(dev); | 372 | pci_dev_put(dev); |
373 | iounmap(intel_rng_hw->mem); | 373 | iounmap(intel_rng_hw->mem); |
374 | kfree(intel_rng_hw); | 374 | kfree(intel_rng_hw); |
diff --git a/kernel/module.c b/kernel/module.c index d861bd5b8c10..61d212120df4 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
@@ -678,7 +678,7 @@ static int try_stop_module(struct module *mod, int flags, int *forced) | |||
678 | if (flags & O_NONBLOCK) { | 678 | if (flags & O_NONBLOCK) { |
679 | struct stopref sref = { mod, flags, forced }; | 679 | struct stopref sref = { mod, flags, forced }; |
680 | 680 | ||
681 | return stop_machine_run(__try_stop_module, &sref, NR_CPUS); | 681 | return stop_machine(__try_stop_module, &sref, NULL); |
682 | } else { | 682 | } else { |
683 | /* We don't need to stop the machine for this. */ | 683 | /* We don't need to stop the machine for this. */ |
684 | mod->state = MODULE_STATE_GOING; | 684 | mod->state = MODULE_STATE_GOING; |
@@ -1416,7 +1416,7 @@ static int __unlink_module(void *_mod) | |||
1416 | static void free_module(struct module *mod) | 1416 | static void free_module(struct module *mod) |
1417 | { | 1417 | { |
1418 | /* Delete from various lists */ | 1418 | /* Delete from various lists */ |
1419 | stop_machine_run(__unlink_module, mod, NR_CPUS); | 1419 | stop_machine(__unlink_module, mod, NULL); |
1420 | remove_notes_attrs(mod); | 1420 | remove_notes_attrs(mod); |
1421 | remove_sect_attrs(mod); | 1421 | remove_sect_attrs(mod); |
1422 | mod_kobject_remove(mod); | 1422 | mod_kobject_remove(mod); |
@@ -2197,7 +2197,7 @@ static struct module *load_module(void __user *umod, | |||
2197 | /* Now sew it into the lists so we can get lockdep and oops | 2197 | /* Now sew it into the lists so we can get lockdep and oops |
2198 | * info during argument parsing. Noone should access us, since | 2198 | * info during argument parsing. Noone should access us, since |
2199 | * strong_try_module_get() will fail. */ | 2199 | * strong_try_module_get() will fail. */ |
2200 | stop_machine_run(__link_module, mod, NR_CPUS); | 2200 | stop_machine(__link_module, mod, NULL); |
2201 | 2201 | ||
2202 | /* Size of section 0 is 0, so this works well if no params */ | 2202 | /* Size of section 0 is 0, so this works well if no params */ |
2203 | err = parse_args(mod->name, mod->args, | 2203 | err = parse_args(mod->name, mod->args, |
@@ -2231,7 +2231,7 @@ static struct module *load_module(void __user *umod, | |||
2231 | return mod; | 2231 | return mod; |
2232 | 2232 | ||
2233 | unlink: | 2233 | unlink: |
2234 | stop_machine_run(__unlink_module, mod, NR_CPUS); | 2234 | stop_machine(__unlink_module, mod, NULL); |
2235 | module_arch_cleanup(mod); | 2235 | module_arch_cleanup(mod); |
2236 | cleanup: | 2236 | cleanup: |
2237 | kobject_del(&mod->mkobj.kobj); | 2237 | kobject_del(&mod->mkobj.kobj); |
diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c index 6f8696c502f4..aad93cdc9f68 100644 --- a/kernel/rcuclassic.c +++ b/kernel/rcuclassic.c | |||
@@ -91,8 +91,8 @@ static void force_quiescent_state(struct rcu_data *rdp, | |||
91 | * rdp->cpu is the current cpu. | 91 | * rdp->cpu is the current cpu. |
92 | * | 92 | * |
93 | * cpu_online_map is updated by the _cpu_down() | 93 | * cpu_online_map is updated by the _cpu_down() |
94 | * using stop_machine_run(). Since we're in irqs disabled | 94 | * using __stop_machine(). Since we're in irqs disabled |
95 | * section, stop_machine_run() is not exectuting, hence | 95 | * section, __stop_machine() is not exectuting, hence |
96 | * the cpu_online_map is stable. | 96 | * the cpu_online_map is stable. |
97 | * | 97 | * |
98 | * However, a cpu might have been offlined _just_ before | 98 | * However, a cpu might have been offlined _just_ before |
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6da667274df5..3cf3d05b6bd4 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
@@ -2372,7 +2372,7 @@ static void build_zonelist_cache(pg_data_t *pgdat) | |||
2372 | 2372 | ||
2373 | #endif /* CONFIG_NUMA */ | 2373 | #endif /* CONFIG_NUMA */ |
2374 | 2374 | ||
2375 | /* return values int ....just for stop_machine_run() */ | 2375 | /* return values int ....just for stop_machine() */ |
2376 | static int __build_all_zonelists(void *dummy) | 2376 | static int __build_all_zonelists(void *dummy) |
2377 | { | 2377 | { |
2378 | int nid; | 2378 | int nid; |
@@ -2397,7 +2397,7 @@ void build_all_zonelists(void) | |||
2397 | } else { | 2397 | } else { |
2398 | /* we have to stop all cpus to guarantee there is no user | 2398 | /* we have to stop all cpus to guarantee there is no user |
2399 | of zonelist */ | 2399 | of zonelist */ |
2400 | stop_machine_run(__build_all_zonelists, NULL, NR_CPUS); | 2400 | stop_machine(__build_all_zonelists, NULL, NULL); |
2401 | /* cpuset refresh routine should be here */ | 2401 | /* cpuset refresh routine should be here */ |
2402 | } | 2402 | } |
2403 | vm_total_pages = nr_free_pagecache_pages(); | 2403 | vm_total_pages = nr_free_pagecache_pages(); |