diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-23 12:08:19 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-23 12:08:19 -0400 |
commit | e0c6b8a17fb3d4a740386b380ea72aa8388fbf2f (patch) | |
tree | 45d20c5d14de3ac03ce4a3ca14c4a41dff6db7ec | |
parent | 710421cc7d295cc59eb2676fe2ba3bc3252c124e (diff) | |
parent | fda5fe19725edd6805f2fd742235d1a0d0ba93f5 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/apm
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/apm:
apm-emulation: apm_mutex breaks ACK; remove it
APM: take over maintainership
-rw-r--r-- | MAINTAINERS | 5 | ||||
-rw-r--r-- | drivers/char/apm-emulation.c | 5 |
2 files changed, 3 insertions, 7 deletions
diff --git a/MAINTAINERS b/MAINTAINERS index 0c916367ae7c..1026e61c7d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
@@ -548,10 +548,11 @@ S: Maintained | |||
548 | F: sound/aoa/ | 548 | F: sound/aoa/ |
549 | 549 | ||
550 | APM DRIVER | 550 | APM DRIVER |
551 | L: linux-laptop@vger.kernel.org | 551 | M: Jiri Kosina <jkosina@suse.cz> |
552 | S: Orphan | 552 | S: Odd fixes |
553 | F: arch/x86/kernel/apm_32.c | 553 | F: arch/x86/kernel/apm_32.c |
554 | F: include/linux/apm_bios.h | 554 | F: include/linux/apm_bios.h |
555 | F: drivers/char/apm-emulation.c | ||
555 | 556 | ||
556 | APPLE BCM5974 MULTITOUCH DRIVER | 557 | APPLE BCM5974 MULTITOUCH DRIVER |
557 | M: Henrik Rydberg <rydberg@euromail.se> | 558 | M: Henrik Rydberg <rydberg@euromail.se> |
diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c index 45b987c9889e..548708c4b2b8 100644 --- a/drivers/char/apm-emulation.c +++ b/drivers/char/apm-emulation.c | |||
@@ -126,7 +126,6 @@ struct apm_user { | |||
126 | /* | 126 | /* |
127 | * Local variables | 127 | * Local variables |
128 | */ | 128 | */ |
129 | static DEFINE_MUTEX(apm_mutex); | ||
130 | static atomic_t suspend_acks_pending = ATOMIC_INIT(0); | 129 | static atomic_t suspend_acks_pending = ATOMIC_INIT(0); |
131 | static atomic_t userspace_notification_inhibit = ATOMIC_INIT(0); | 130 | static atomic_t userspace_notification_inhibit = ATOMIC_INIT(0); |
132 | static int apm_disabled; | 131 | static int apm_disabled; |
@@ -275,7 +274,6 @@ apm_ioctl(struct file *filp, u_int cmd, u_long arg) | |||
275 | if (!as->suser || !as->writer) | 274 | if (!as->suser || !as->writer) |
276 | return -EPERM; | 275 | return -EPERM; |
277 | 276 | ||
278 | mutex_lock(&apm_mutex); | ||
279 | switch (cmd) { | 277 | switch (cmd) { |
280 | case APM_IOC_SUSPEND: | 278 | case APM_IOC_SUSPEND: |
281 | mutex_lock(&state_lock); | 279 | mutex_lock(&state_lock); |
@@ -336,7 +334,6 @@ apm_ioctl(struct file *filp, u_int cmd, u_long arg) | |||
336 | mutex_unlock(&state_lock); | 334 | mutex_unlock(&state_lock); |
337 | break; | 335 | break; |
338 | } | 336 | } |
339 | mutex_unlock(&apm_mutex); | ||
340 | 337 | ||
341 | return err; | 338 | return err; |
342 | } | 339 | } |
@@ -371,7 +368,6 @@ static int apm_open(struct inode * inode, struct file * filp) | |||
371 | { | 368 | { |
372 | struct apm_user *as; | 369 | struct apm_user *as; |
373 | 370 | ||
374 | mutex_lock(&apm_mutex); | ||
375 | as = kzalloc(sizeof(*as), GFP_KERNEL); | 371 | as = kzalloc(sizeof(*as), GFP_KERNEL); |
376 | if (as) { | 372 | if (as) { |
377 | /* | 373 | /* |
@@ -391,7 +387,6 @@ static int apm_open(struct inode * inode, struct file * filp) | |||
391 | 387 | ||
392 | filp->private_data = as; | 388 | filp->private_data = as; |
393 | } | 389 | } |
394 | mutex_unlock(&apm_mutex); | ||
395 | 390 | ||
396 | return as ? 0 : -ENOMEM; | 391 | return as ? 0 : -ENOMEM; |
397 | } | 392 | } |