diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2011-03-06 06:03:26 -0500 |
---|---|---|
committer | Marcelo Tosatti <mtosatti@redhat.com> | 2011-03-17 12:08:33 -0400 |
commit | c8ce057eafd49da6a7afe7791bd84163f65f6132 (patch) | |
tree | a40cff496f6ee5e2857509af0a2c1ccd89f7db1e | |
parent | 676646ee4b0931a1ef54389786983a43eb913a6f (diff) |
KVM: improve comment on rcu use in irqfd_deassign
The RCU use in kvm_irqfd_deassign is tricky: we have rcu_assign_pointer
but no synchronize_rcu: synchronize_rcu is done by kvm_irq_routing_update
which we share a spinlock with.
Fix up a comment in an attempt to make this clearer.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
-rw-r--r-- | virt/kvm/eventfd.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index 2ca4535f4fb7..3656849f78a0 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c | |||
@@ -313,8 +313,9 @@ kvm_irqfd_deassign(struct kvm *kvm, int fd, int gsi) | |||
313 | if (irqfd->eventfd == eventfd && irqfd->gsi == gsi) { | 313 | if (irqfd->eventfd == eventfd && irqfd->gsi == gsi) { |
314 | /* | 314 | /* |
315 | * This rcu_assign_pointer is needed for when | 315 | * This rcu_assign_pointer is needed for when |
316 | * another thread calls kvm_irqfd_update before | 316 | * another thread calls kvm_irq_routing_update before |
317 | * we flush workqueue below. | 317 | * we flush workqueue below (we synchronize with |
318 | * kvm_irq_routing_update using irqfds.lock). | ||
318 | * It is paired with synchronize_rcu done by caller | 319 | * It is paired with synchronize_rcu done by caller |
319 | * of that function. | 320 | * of that function. |
320 | */ | 321 | */ |