diff options
author | Fengguang Wu <wfg@mail.ustc.edu.cn> | 2007-10-16 04:24:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-16 12:42:52 -0400 |
commit | 937085aa35cc873d427d250a1e304d641af24628 (patch) | |
tree | 99b0d2d9e6721a72e65b4cb5ad0fc30ec04f4aa2 | |
parent | 43fac94dd62667c83dd2daa5b7ac548512af780a (diff) |
readahead: compacting file_ra_state
Use 'unsigned int' instead of 'unsigned long' for readahead sizes.
This helps reduce memory consumption on 64bit CPU when a lot of files are
opened.
CC: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | include/linux/fs.h | 8 | ||||
-rw-r--r-- | mm/readahead.c | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h index 4a6a21077bae..7a998c49a086 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h | |||
@@ -697,12 +697,12 @@ struct fown_struct { | |||
697 | * Track a single file's readahead state | 697 | * Track a single file's readahead state |
698 | */ | 698 | */ |
699 | struct file_ra_state { | 699 | struct file_ra_state { |
700 | pgoff_t start; /* where readahead started */ | 700 | pgoff_t start; /* where readahead started */ |
701 | unsigned long size; /* # of readahead pages */ | 701 | unsigned int size; /* # of readahead pages */ |
702 | unsigned long async_size; /* do asynchronous readahead when | 702 | unsigned int async_size; /* do asynchronous readahead when |
703 | there are only # of pages ahead */ | 703 | there are only # of pages ahead */ |
704 | 704 | ||
705 | unsigned long ra_pages; /* Maximum readahead window */ | 705 | unsigned int ra_pages; /* Maximum readahead window */ |
706 | unsigned long mmap_hit; /* Cache hit stat for mmap accesses */ | 706 | unsigned long mmap_hit; /* Cache hit stat for mmap accesses */ |
707 | unsigned long mmap_miss; /* Cache miss stat for mmap accesses */ | 707 | unsigned long mmap_miss; /* Cache miss stat for mmap accesses */ |
708 | unsigned long prev_index; /* Cache last read() position */ | 708 | unsigned long prev_index; /* Cache last read() position */ |
diff --git a/mm/readahead.c b/mm/readahead.c index be20c9d699d3..d2504877b269 100644 --- a/mm/readahead.c +++ b/mm/readahead.c | |||
@@ -351,7 +351,7 @@ ondemand_readahead(struct address_space *mapping, | |||
351 | bool hit_readahead_marker, pgoff_t offset, | 351 | bool hit_readahead_marker, pgoff_t offset, |
352 | unsigned long req_size) | 352 | unsigned long req_size) |
353 | { | 353 | { |
354 | unsigned long max; /* max readahead pages */ | 354 | int max; /* max readahead pages */ |
355 | int sequential; | 355 | int sequential; |
356 | 356 | ||
357 | max = ra->ra_pages; | 357 | max = ra->ra_pages; |