aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes@sipsolutions.net>2008-10-21 03:57:41 -0400
committerJohn W. Linville <linville@tuxdriver.com>2008-10-31 19:00:42 -0400
commitf3b407fba52e1b86ca286ee7c218a4fb00bd29e0 (patch)
treedf5c4fce124d0792e4a52aa269f42cb734cefb12
parentcf03268e6ed6cfacaa5e32db41ea832c4d10438b (diff)
wireless: remove cfg80211_reg_mutex
This mutex is wrong, we use cfg80211_drv_mutex (which should possibly be renamed to just cfg80211_mutex) everywhere except in one place, fix that and get rid of the extra mutex. Also get rid of a spurious regulatory_requests list definition. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--net/wireless/core.c6
-rw-r--r--net/wireless/reg.c3
-rw-r--r--net/wireless/reg.h1
3 files changed, 2 insertions, 8 deletions
diff --git a/net/wireless/core.c b/net/wireless/core.c
index 5031db7b275b..72825afe2bf6 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -301,12 +301,10 @@ int wiphy_register(struct wiphy *wiphy)
301 /* check and set up bitrates */ 301 /* check and set up bitrates */
302 ieee80211_set_bitrate_flags(wiphy); 302 ieee80211_set_bitrate_flags(wiphy);
303 303
304 mutex_lock(&cfg80211_drv_mutex);
305
304 /* set up regulatory info */ 306 /* set up regulatory info */
305 mutex_lock(&cfg80211_reg_mutex);
306 wiphy_update_regulatory(wiphy, REGDOM_SET_BY_CORE); 307 wiphy_update_regulatory(wiphy, REGDOM_SET_BY_CORE);
307 mutex_unlock(&cfg80211_reg_mutex);
308
309 mutex_lock(&cfg80211_drv_mutex);
310 308
311 res = device_add(&drv->wiphy.dev); 309 res = device_add(&drv->wiphy.dev);
312 if (res) 310 if (res)
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 626dbb688499..581273d86844 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -52,7 +52,6 @@ struct regulatory_request {
52}; 52};
53 53
54static LIST_HEAD(regulatory_requests); 54static LIST_HEAD(regulatory_requests);
55DEFINE_MUTEX(cfg80211_reg_mutex);
56 55
57/* To trigger userspace events */ 56/* To trigger userspace events */
58static struct platform_device *reg_pdev; 57static struct platform_device *reg_pdev;
@@ -63,8 +62,6 @@ static u32 supported_bandwidths[] = {
63 MHZ_TO_KHZ(20), 62 MHZ_TO_KHZ(20),
64}; 63};
65 64
66static struct list_head regulatory_requests;
67
68/* Central wireless core regulatory domains, we only need two, 65/* Central wireless core regulatory domains, we only need two,
69 * the current one and a world regulatory domain in case we have no 66 * the current one and a world regulatory domain in case we have no
70 * information to give us an alpha2 */ 67 * information to give us an alpha2 */
diff --git a/net/wireless/reg.h b/net/wireless/reg.h
index a4845b140a84..0c1572b92fef 100644
--- a/net/wireless/reg.h
+++ b/net/wireless/reg.h
@@ -1,7 +1,6 @@
1#ifndef __NET_WIRELESS_REG_H 1#ifndef __NET_WIRELESS_REG_H
2#define __NET_WIRELESS_REG_H 2#define __NET_WIRELESS_REG_H
3 3
4extern struct mutex cfg80211_reg_mutex;
5bool is_world_regdom(const char *alpha2); 4bool is_world_regdom(const char *alpha2);
6bool reg_is_valid_request(const char *alpha2); 5bool reg_is_valid_request(const char *alpha2);
7 6