diff options
author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-07-06 18:39:07 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2010-08-04 22:56:13 -0400 |
commit | 449e8df39d3f94a69deae8341f157f6ef5999015 (patch) | |
tree | 75d797caf68e11d7577218e007bdf6f79326c134 | |
parent | bf23c51f1f49d3960f3cd8e3d2e7f943d9c41042 (diff) |
memblock: Add debug markers at the end of the array
Since we allocate one more than needed, why not do a bit of sanity checking
here to ensure we don't walk past the end of the array ?
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r-- | mm/memblock.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/mm/memblock.c b/mm/memblock.c index 3c474502d92b..a925866e1455 100644 --- a/mm/memblock.c +++ b/mm/memblock.c | |||
@@ -13,6 +13,7 @@ | |||
13 | #include <linux/kernel.h> | 13 | #include <linux/kernel.h> |
14 | #include <linux/init.h> | 14 | #include <linux/init.h> |
15 | #include <linux/bitops.h> | 15 | #include <linux/bitops.h> |
16 | #include <linux/poison.h> | ||
16 | #include <linux/memblock.h> | 17 | #include <linux/memblock.h> |
17 | 18 | ||
18 | struct memblock memblock; | 19 | struct memblock memblock; |
@@ -112,6 +113,10 @@ void __init memblock_init(void) | |||
112 | memblock.reserved.regions = memblock_reserved_init_regions; | 113 | memblock.reserved.regions = memblock_reserved_init_regions; |
113 | memblock.reserved.max = INIT_MEMBLOCK_REGIONS; | 114 | memblock.reserved.max = INIT_MEMBLOCK_REGIONS; |
114 | 115 | ||
116 | /* Write a marker in the unused last array entry */ | ||
117 | memblock.memory.regions[INIT_MEMBLOCK_REGIONS].base = (phys_addr_t)RED_INACTIVE; | ||
118 | memblock.reserved.regions[INIT_MEMBLOCK_REGIONS].base = (phys_addr_t)RED_INACTIVE; | ||
119 | |||
115 | /* Create a dummy zero size MEMBLOCK which will get coalesced away later. | 120 | /* Create a dummy zero size MEMBLOCK which will get coalesced away later. |
116 | * This simplifies the memblock_add() code below... | 121 | * This simplifies the memblock_add() code below... |
117 | */ | 122 | */ |
@@ -131,6 +136,12 @@ void __init memblock_analyze(void) | |||
131 | { | 136 | { |
132 | int i; | 137 | int i; |
133 | 138 | ||
139 | /* Check marker in the unused last array entry */ | ||
140 | WARN_ON(memblock_memory_init_regions[INIT_MEMBLOCK_REGIONS].base | ||
141 | != (phys_addr_t)RED_INACTIVE); | ||
142 | WARN_ON(memblock_reserved_init_regions[INIT_MEMBLOCK_REGIONS].base | ||
143 | != (phys_addr_t)RED_INACTIVE); | ||
144 | |||
134 | memblock.memory_size = 0; | 145 | memblock.memory_size = 0; |
135 | 146 | ||
136 | for (i = 0; i < memblock.memory.cnt; i++) | 147 | for (i = 0; i < memblock.memory.cnt; i++) |