aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2006-11-02 15:16:08 -0500
committerStefan Richter <stefanr@s5r6.in-berlin.de>2006-12-07 17:03:49 -0500
commit2a533b179dcfe941ccbe30344d14f39f6d7098ae (patch)
tree1bcfe5063f7a227a2f83c60d43cae7080a17926d
parentcd641f68d628e5c44350447d4b8d661991419e60 (diff)
ieee1394: sbp2: update comment on things to do
Some people actually look at those comments. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r--drivers/ieee1394/sbp2.c26
1 files changed, 19 insertions, 7 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 2b6d9a0fa737..187e26f0485d 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -29,13 +29,27 @@
29 * driver. It also registers as a SCSI lower-level driver in order to accept 29 * driver. It also registers as a SCSI lower-level driver in order to accept
30 * SCSI commands for transport using SBP-2. 30 * SCSI commands for transport using SBP-2.
31 * 31 *
32 * You may access any attached SBP-2 storage devices as if they were SCSI 32 * You may access any attached SBP-2 (usually storage devices) as regular
33 * devices (e.g. mount /dev/sda1, fdisk, mkfs, etc.). 33 * SCSI devices. E.g. mount /dev/sda1, fdisk, mkfs, etc..
34 * 34 *
35 * Current Issues: 35 * See http://www.t10.org/drafts.htm#sbp2 for the final draft of the SBP-2
36 * specification and for where to purchase the official standard.
36 * 37 *
37 * - Error Handling: SCSI aborts and bus reset requests are handled somewhat 38 * TODO:
38 * but the code needs additional debugging. 39 * - look into possible improvements of the SCSI error handlers
40 * - handle Unit_Characteristics.mgt_ORB_timeout and .ORB_size
41 * - handle Logical_Unit_Number.ordered
42 * - handle src == 1 in status blocks
43 * - reimplement the DMA mapping in absence of physical DMA so that
44 * bus_to_virt is no longer required
45 * - debug the handling of absent physical DMA
46 * - replace CONFIG_IEEE1394_SBP2_PHYS_DMA by automatic detection
47 * (this is easy but depends on the previous two TODO items)
48 * - make the parameter serialize_io configurable per device
49 * - move all requests to fetch agent registers into non-atomic context,
50 * replace all usages of sbp2util_node_write_no_wait by true transactions
51 * - convert to generic DMA mapping API to eliminate dependency on PCI
52 * Grep for inline FIXME comments below.
39 */ 53 */
40 54
41#include <linux/blkdev.h> 55#include <linux/blkdev.h>
@@ -107,8 +121,6 @@ MODULE_PARM_DESC(max_speed, "Force max speed "
107 * Set serialize_io to 1 if you'd like only one scsi command sent 121 * Set serialize_io to 1 if you'd like only one scsi command sent
108 * down to us at a time (debugging). This might be necessary for very 122 * down to us at a time (debugging). This might be necessary for very
109 * badly behaved sbp2 devices. 123 * badly behaved sbp2 devices.
110 *
111 * TODO: Make this configurable per device.
112 */ 124 */
113static int sbp2_serialize_io = 1; 125static int sbp2_serialize_io = 1;
114module_param_named(serialize_io, sbp2_serialize_io, int, 0444); 126module_param_named(serialize_io, sbp2_serialize_io, int, 0444);