diff options
author | Bing Zhao <bzhao@marvell.com> | 2012-10-05 16:57:48 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-10-19 15:53:16 -0400 |
commit | f575f65897e84018ee7163407ca5514272e11223 (patch) | |
tree | 54f6a74a57bc7c44dcdf7f388d8e91981d2ad848 | |
parent | 7a66205a218c4b22ced8b3326ab925136b160b01 (diff) |
mwifiex: use sizeof(array) to print_hex_dump_bytes
DBG_CMD_NUM is the number of commands, not the actual bytes of
data for printing.
Also remove the duplicated DBG_CMD_NUM definition.
Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/mwifiex/cmdevt.c | 11 | ||||
-rw-r--r-- | drivers/net/wireless/mwifiex/main.h | 2 |
2 files changed, 7 insertions, 6 deletions
diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c index 8d465107f52b..6627f9caabd0 100644 --- a/drivers/net/wireless/mwifiex/cmdevt.c +++ b/drivers/net/wireless/mwifiex/cmdevt.c | |||
@@ -918,20 +918,23 @@ mwifiex_cmd_timeout_func(unsigned long function_context) | |||
918 | dev_err(adapter->dev, "last_cmd_index = %d\n", | 918 | dev_err(adapter->dev, "last_cmd_index = %d\n", |
919 | adapter->dbg.last_cmd_index); | 919 | adapter->dbg.last_cmd_index); |
920 | print_hex_dump_bytes("last_cmd_id: ", DUMP_PREFIX_OFFSET, | 920 | print_hex_dump_bytes("last_cmd_id: ", DUMP_PREFIX_OFFSET, |
921 | adapter->dbg.last_cmd_id, DBG_CMD_NUM); | 921 | adapter->dbg.last_cmd_id, |
922 | sizeof(adapter->dbg.last_cmd_id)); | ||
922 | print_hex_dump_bytes("last_cmd_act: ", DUMP_PREFIX_OFFSET, | 923 | print_hex_dump_bytes("last_cmd_act: ", DUMP_PREFIX_OFFSET, |
923 | adapter->dbg.last_cmd_act, DBG_CMD_NUM); | 924 | adapter->dbg.last_cmd_act, |
925 | sizeof(adapter->dbg.last_cmd_act)); | ||
924 | 926 | ||
925 | dev_err(adapter->dev, "last_cmd_resp_index = %d\n", | 927 | dev_err(adapter->dev, "last_cmd_resp_index = %d\n", |
926 | adapter->dbg.last_cmd_resp_index); | 928 | adapter->dbg.last_cmd_resp_index); |
927 | print_hex_dump_bytes("last_cmd_resp_id: ", DUMP_PREFIX_OFFSET, | 929 | print_hex_dump_bytes("last_cmd_resp_id: ", DUMP_PREFIX_OFFSET, |
928 | adapter->dbg.last_cmd_resp_id, | 930 | adapter->dbg.last_cmd_resp_id, |
929 | DBG_CMD_NUM); | 931 | sizeof(adapter->dbg.last_cmd_resp_id)); |
930 | 932 | ||
931 | dev_err(adapter->dev, "last_event_index = %d\n", | 933 | dev_err(adapter->dev, "last_event_index = %d\n", |
932 | adapter->dbg.last_event_index); | 934 | adapter->dbg.last_event_index); |
933 | print_hex_dump_bytes("last_event: ", DUMP_PREFIX_OFFSET, | 935 | print_hex_dump_bytes("last_event: ", DUMP_PREFIX_OFFSET, |
934 | adapter->dbg.last_event, DBG_CMD_NUM); | 936 | adapter->dbg.last_event, |
937 | sizeof(adapter->dbg.last_event)); | ||
935 | 938 | ||
936 | dev_err(adapter->dev, "data_sent=%d cmd_sent=%d\n", | 939 | dev_err(adapter->dev, "data_sent=%d cmd_sent=%d\n", |
937 | adapter->data_sent, adapter->cmd_sent); | 940 | adapter->data_sent, adapter->cmd_sent); |
diff --git a/drivers/net/wireless/mwifiex/main.h b/drivers/net/wireless/mwifiex/main.h index c2d0ab146af5..0b747ec84c4d 100644 --- a/drivers/net/wireless/mwifiex/main.h +++ b/drivers/net/wireless/mwifiex/main.h | |||
@@ -115,8 +115,6 @@ enum { | |||
115 | #define MWIFIEX_TYPE_DATA 0 | 115 | #define MWIFIEX_TYPE_DATA 0 |
116 | #define MWIFIEX_TYPE_EVENT 3 | 116 | #define MWIFIEX_TYPE_EVENT 3 |
117 | 117 | ||
118 | #define DBG_CMD_NUM 5 | ||
119 | |||
120 | #define MAX_BITMAP_RATES_SIZE 10 | 118 | #define MAX_BITMAP_RATES_SIZE 10 |
121 | 119 | ||
122 | #define MAX_CHANNEL_BAND_BG 14 | 120 | #define MAX_CHANNEL_BAND_BG 14 |