diff options
author | Fabio Estevam <fabio.estevam@freescale.com> | 2013-05-08 09:05:55 -0400 |
---|---|---|
committer | Olof Johansson <olof@lixom.net> | 2013-05-09 16:06:00 -0400 |
commit | d7321df327a1f5a7dd3cb5c51c887c5a43362379 (patch) | |
tree | 5a9bf3b76326934d980c2d7f9d40d038f905ecd5 | |
parent | 60371952e1dd0d507039b2654c22083b32c38398 (diff) |
video: mxsfb: Adapt to new videomode API
commit 6cd2c7db4 (videomode: videomode_from_timing work) changed the name of
the function from videomode_from_timing() to videomode_from_timings().
commit 32ed6ef1 (videomode: create enum for videomode's display flags) changed
the 'data_flags' field in videomode structure to 'flags'
Adapt to these changes in order to fix the following errors:
drivers/video/mxsfb.c:761:3: error: too many arguments to function 'videomode_from_timing'
drivers/video/mxsfb.c:761:7: error: void value not ignored as it ought to be
drivers/video/mxsfb.c:768:9: error: 'struct videomode' has no member named 'data_flags'
drivers/video/mxsfb.c:770:9: error: 'struct videomode' has no member named 'data_flags'
Also, select VIDEOMODE_HELPER instead of OF_VIDEOMODE, as this one is
deprecated.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
-rw-r--r-- | drivers/video/Kconfig | 2 | ||||
-rw-r--r-- | drivers/video/mxsfb.c | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 1534cf3c1423..d71d60f94fc1 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig | |||
@@ -2429,7 +2429,7 @@ config FB_MXS | |||
2429 | select FB_CFB_COPYAREA | 2429 | select FB_CFB_COPYAREA |
2430 | select FB_CFB_IMAGEBLIT | 2430 | select FB_CFB_IMAGEBLIT |
2431 | select FB_MODE_HELPERS | 2431 | select FB_MODE_HELPERS |
2432 | select OF_VIDEOMODE | 2432 | select VIDEOMODE_HELPERS |
2433 | help | 2433 | help |
2434 | Framebuffer support for the MXS SoC. | 2434 | Framebuffer support for the MXS SoC. |
2435 | 2435 | ||
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 1b2c26d1658c..21223d475b39 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c | |||
@@ -42,7 +42,6 @@ | |||
42 | #include <linux/module.h> | 42 | #include <linux/module.h> |
43 | #include <linux/kernel.h> | 43 | #include <linux/kernel.h> |
44 | #include <linux/of_device.h> | 44 | #include <linux/of_device.h> |
45 | #include <video/of_display_timing.h> | ||
46 | #include <linux/platform_device.h> | 45 | #include <linux/platform_device.h> |
47 | #include <linux/clk.h> | 46 | #include <linux/clk.h> |
48 | #include <linux/dma-mapping.h> | 47 | #include <linux/dma-mapping.h> |
@@ -50,6 +49,7 @@ | |||
50 | #include <linux/pinctrl/consumer.h> | 49 | #include <linux/pinctrl/consumer.h> |
51 | #include <linux/fb.h> | 50 | #include <linux/fb.h> |
52 | #include <linux/regulator/consumer.h> | 51 | #include <linux/regulator/consumer.h> |
52 | #include <video/of_display_timing.h> | ||
53 | #include <video/videomode.h> | 53 | #include <video/videomode.h> |
54 | 54 | ||
55 | #define REG_SET 4 | 55 | #define REG_SET 4 |
@@ -777,16 +777,16 @@ static int mxsfb_init_fbinfo_dt(struct mxsfb_info *host) | |||
777 | struct videomode vm; | 777 | struct videomode vm; |
778 | struct fb_videomode fb_vm; | 778 | struct fb_videomode fb_vm; |
779 | 779 | ||
780 | ret = videomode_from_timing(timings, &vm, i); | 780 | ret = videomode_from_timings(timings, &vm, i); |
781 | if (ret < 0) | 781 | if (ret < 0) |
782 | goto put_timings_node; | 782 | goto put_timings_node; |
783 | ret = fb_videomode_from_videomode(&vm, &fb_vm); | 783 | ret = fb_videomode_from_videomode(&vm, &fb_vm); |
784 | if (ret < 0) | 784 | if (ret < 0) |
785 | goto put_timings_node; | 785 | goto put_timings_node; |
786 | 786 | ||
787 | if (vm.data_flags & DISPLAY_FLAGS_DE_HIGH) | 787 | if (vm.flags & DISPLAY_FLAGS_DE_HIGH) |
788 | host->sync |= MXSFB_SYNC_DATA_ENABLE_HIGH_ACT; | 788 | host->sync |= MXSFB_SYNC_DATA_ENABLE_HIGH_ACT; |
789 | if (vm.data_flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) | 789 | if (vm.flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) |
790 | host->sync |= MXSFB_SYNC_DOTCLK_FALLING_ACT; | 790 | host->sync |= MXSFB_SYNC_DOTCLK_FALLING_ACT; |
791 | fb_add_videomode(&fb_vm, &fb_info->modelist); | 791 | fb_add_videomode(&fb_vm, &fb_info->modelist); |
792 | } | 792 | } |