aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2011-08-22 14:30:38 -0400
committerDavid S. Miller <davem@davemloft.net>2011-08-22 14:30:38 -0400
commitc8d755b59ae6750150d7f351210b97ad4cce5a51 (patch)
tree1404f8966112ca6f4c3ba19792117d311b521348
parentca1ba7caa68520864e4b9227e67f3bbc6fed373b (diff)
net/wan/hdlc_ppp: use break in switch
We'll either hit one of the case labels or the default in the switch and in all cases do we then 'goto out' and we also have a 'goto out' after the switch that is redundant. Change to just use break in the case statements and leave the 'goto out' after the lop for everyone to hit. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/wan/hdlc_ppp.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c
index 055a918067e6..0d7645581f91 100644
--- a/drivers/net/wan/hdlc_ppp.c
+++ b/drivers/net/wan/hdlc_ppp.c
@@ -515,37 +515,37 @@ static int ppp_rx(struct sk_buff *skb)
515 switch (cp->code) { 515 switch (cp->code) {
516 case CP_CONF_REQ: 516 case CP_CONF_REQ:
517 ppp_cp_parse_cr(dev, pid, cp->id, len, skb->data); 517 ppp_cp_parse_cr(dev, pid, cp->id, len, skb->data);
518 goto out; 518 break;
519 519
520 case CP_CONF_ACK: 520 case CP_CONF_ACK:
521 if (cp->id == proto->cr_id) 521 if (cp->id == proto->cr_id)
522 ppp_cp_event(dev, pid, RCA, 0, 0, 0, NULL); 522 ppp_cp_event(dev, pid, RCA, 0, 0, 0, NULL);
523 goto out; 523 break;
524 524
525 case CP_CONF_REJ: 525 case CP_CONF_REJ:
526 case CP_CONF_NAK: 526 case CP_CONF_NAK:
527 if (cp->id == proto->cr_id) 527 if (cp->id == proto->cr_id)
528 ppp_cp_event(dev, pid, RCN, 0, 0, 0, NULL); 528 ppp_cp_event(dev, pid, RCN, 0, 0, 0, NULL);
529 goto out; 529 break;
530 530
531 case CP_TERM_REQ: 531 case CP_TERM_REQ:
532 ppp_cp_event(dev, pid, RTR, 0, cp->id, 0, NULL); 532 ppp_cp_event(dev, pid, RTR, 0, cp->id, 0, NULL);
533 goto out; 533 break;
534 534
535 case CP_TERM_ACK: 535 case CP_TERM_ACK:
536 ppp_cp_event(dev, pid, RTA, 0, 0, 0, NULL); 536 ppp_cp_event(dev, pid, RTA, 0, 0, 0, NULL);
537 goto out; 537 break;
538 538
539 case CP_CODE_REJ: 539 case CP_CODE_REJ:
540 ppp_cp_event(dev, pid, RXJ_BAD, 0, 0, 0, NULL); 540 ppp_cp_event(dev, pid, RXJ_BAD, 0, 0, 0, NULL);
541 goto out; 541 break;
542 542
543 default: 543 default:
544 len += sizeof(struct cp_header); 544 len += sizeof(struct cp_header);
545 if (len > dev->mtu) 545 if (len > dev->mtu)
546 len = dev->mtu; 546 len = dev->mtu;
547 ppp_cp_event(dev, pid, RUC, 0, 0, len, cp); 547 ppp_cp_event(dev, pid, RUC, 0, 0, len, cp);
548 goto out; 548 break;
549 } 549 }
550 goto out; 550 goto out;
551 551