diff options
author | Leonidas S. Barbosa <leosilva@linux.vnet.ibm.com> | 2014-10-28 13:46:49 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-11-06 10:15:01 -0500 |
commit | c7b675de390005be5dde57d341347c52684d2f69 (patch) | |
tree | bb237370519e8225c7e559289797c1a1b0fd77ee | |
parent | 01a5aa08ef383bf3d39f280df6417d50d6d9a269 (diff) |
crypto: nx - Moving NX-AES-ECB to be processed logic
The previous limits were estimated locally in a single step
basead on bound values, however it was not correct since
when given certain scatterlist the function nx_build_sg_lists
was consuming more sg entries than allocated causing a
memory corruption and crashes.
This patch removes the old logic and replaces it into nx_sg_build_lists
in order to build a correct nx_sg list using the correct sg_max limit
and bounds.
Signed-off-by: Leonidas S. Barbosa <leosilva@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r-- | drivers/crypto/nx/nx-aes-ecb.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/crypto/nx/nx-aes-ecb.c b/drivers/crypto/nx/nx-aes-ecb.c index 85a8d23cf29d..cfdde8b8bc76 100644 --- a/drivers/crypto/nx/nx-aes-ecb.c +++ b/drivers/crypto/nx/nx-aes-ecb.c | |||
@@ -72,27 +72,19 @@ static int ecb_aes_nx_crypt(struct blkcipher_desc *desc, | |||
72 | struct nx_csbcpb *csbcpb = nx_ctx->csbcpb; | 72 | struct nx_csbcpb *csbcpb = nx_ctx->csbcpb; |
73 | unsigned long irq_flags; | 73 | unsigned long irq_flags; |
74 | unsigned int processed = 0, to_process; | 74 | unsigned int processed = 0, to_process; |
75 | u32 max_sg_len; | ||
76 | int rc; | 75 | int rc; |
77 | 76 | ||
78 | spin_lock_irqsave(&nx_ctx->lock, irq_flags); | 77 | spin_lock_irqsave(&nx_ctx->lock, irq_flags); |
79 | 78 | ||
80 | max_sg_len = min_t(u32, nx_driver.of.max_sg_len/sizeof(struct nx_sg), | ||
81 | nx_ctx->ap->sglen); | ||
82 | |||
83 | if (enc) | 79 | if (enc) |
84 | NX_CPB_FDM(csbcpb) |= NX_FDM_ENDE_ENCRYPT; | 80 | NX_CPB_FDM(csbcpb) |= NX_FDM_ENDE_ENCRYPT; |
85 | else | 81 | else |
86 | NX_CPB_FDM(csbcpb) &= ~NX_FDM_ENDE_ENCRYPT; | 82 | NX_CPB_FDM(csbcpb) &= ~NX_FDM_ENDE_ENCRYPT; |
87 | 83 | ||
88 | do { | 84 | do { |
89 | to_process = min_t(u64, nbytes - processed, | 85 | to_process = nbytes - processed; |
90 | nx_ctx->ap->databytelen); | ||
91 | to_process = min_t(u64, to_process, | ||
92 | NX_PAGE_SIZE * (max_sg_len - 1)); | ||
93 | to_process = to_process & ~(AES_BLOCK_SIZE - 1); | ||
94 | 86 | ||
95 | rc = nx_build_sg_lists(nx_ctx, desc, dst, src, to_process, | 87 | rc = nx_build_sg_lists(nx_ctx, desc, dst, src, &to_process, |
96 | processed, NULL); | 88 | processed, NULL); |
97 | if (rc) | 89 | if (rc) |
98 | goto out; | 90 | goto out; |