diff options
author | Zhang Rui <rui.zhang@intel.com> | 2012-12-04 17:23:16 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2012-12-04 17:23:16 -0500 |
commit | b7e383046c2c7c13ad928cd7407eafff758ddd4b (patch) | |
tree | 5d0ca5f0cc3cfc489b16f2d7437e1183d65d866c | |
parent | a6b5e88c0e42093b9057856f35770966c8c591e3 (diff) |
ACPI : do not use Lid and Sleep button for S5 wakeup
When system enters power off, the _PSW of Lid device is enabled.
But this may cause the system to reboot instead of power off.
A proper way to fix this is to always disable lid wakeup capability for S5.
References: https://bugzilla.kernel.org/show_bug.cgi?id=35262
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | drivers/acpi/scan.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index d0b38ab47ab5..bd523bfbaad1 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c | |||
@@ -917,8 +917,8 @@ acpi_bus_extract_wakeup_device_power_package(acpi_handle handle, | |||
917 | static void acpi_bus_set_run_wake_flags(struct acpi_device *device) | 917 | static void acpi_bus_set_run_wake_flags(struct acpi_device *device) |
918 | { | 918 | { |
919 | struct acpi_device_id button_device_ids[] = { | 919 | struct acpi_device_id button_device_ids[] = { |
920 | {"PNP0C0D", 0}, | ||
921 | {"PNP0C0C", 0}, | 920 | {"PNP0C0C", 0}, |
921 | {"PNP0C0D", 0}, | ||
922 | {"PNP0C0E", 0}, | 922 | {"PNP0C0E", 0}, |
923 | {"", 0}, | 923 | {"", 0}, |
924 | }; | 924 | }; |
@@ -930,6 +930,11 @@ static void acpi_bus_set_run_wake_flags(struct acpi_device *device) | |||
930 | /* Power button, Lid switch always enable wakeup */ | 930 | /* Power button, Lid switch always enable wakeup */ |
931 | if (!acpi_match_device_ids(device, button_device_ids)) { | 931 | if (!acpi_match_device_ids(device, button_device_ids)) { |
932 | device->wakeup.flags.run_wake = 1; | 932 | device->wakeup.flags.run_wake = 1; |
933 | if (!acpi_match_device_ids(device, &button_device_ids[1])) { | ||
934 | /* Do not use Lid/sleep button for S5 wakeup */ | ||
935 | if (device->wakeup.sleep_state == ACPI_STATE_S5) | ||
936 | device->wakeup.sleep_state = ACPI_STATE_S4; | ||
937 | } | ||
933 | device_set_wakeup_capable(&device->dev, true); | 938 | device_set_wakeup_capable(&device->dev, true); |
934 | return; | 939 | return; |
935 | } | 940 | } |