diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-12-20 19:52:45 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-12-20 19:52:45 -0500 |
commit | b7000adef17a5cce85636e40fa2c2d9851a89e28 (patch) | |
tree | 35ba6eb35920624fbaf16e1c404f3012531c95a9 | |
parent | a6ddeee32dadec066e910c7dcd237be732535fc2 (diff) |
Don't set the INITRD_COMPRESS environment variable automatically
Commit 1bf49dd4be0b ("./Makefile: export initial ramdisk compression
config option") started setting the INITRD_COMPRESS environment variable
depending on which decompression models the kernel had available.
That is completely broken.
For example, we by default have CONFIG_RD_LZ4 enabled, and are able to
decompress such an initrd, but the user tools to *create* such an initrd
may not be availble. So trying to tell dracut to generate an
lz4-compressed image just because we can decode such an image is
completely inappropriate.
Cc: J P <ppandit@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | Makefile | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -738,7 +738,9 @@ INITRD_COMPRESS-$(CONFIG_RD_LZMA) := lzma | |||
738 | INITRD_COMPRESS-$(CONFIG_RD_XZ) := xz | 738 | INITRD_COMPRESS-$(CONFIG_RD_XZ) := xz |
739 | INITRD_COMPRESS-$(CONFIG_RD_LZO) := lzo | 739 | INITRD_COMPRESS-$(CONFIG_RD_LZO) := lzo |
740 | INITRD_COMPRESS-$(CONFIG_RD_LZ4) := lz4 | 740 | INITRD_COMPRESS-$(CONFIG_RD_LZ4) := lz4 |
741 | export INITRD_COMPRESS := $(INITRD_COMPRESS-y) | 741 | # do not export INITRD_COMPRESS, since we didn't actually |
742 | # choose a sane default compression above. | ||
743 | # export INITRD_COMPRESS := $(INITRD_COMPRESS-y) | ||
742 | 744 | ||
743 | ifdef CONFIG_MODULE_SIG_ALL | 745 | ifdef CONFIG_MODULE_SIG_ALL |
744 | MODSECKEY = ./signing_key.priv | 746 | MODSECKEY = ./signing_key.priv |