diff options
author | Sachin Kamat <sachin.kamat@linaro.org> | 2013-09-04 07:47:52 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2013-09-16 19:28:44 -0400 |
commit | ab1d65e03afdafa991bb208ade089d36b0e1d2ad (patch) | |
tree | 33245ed4ebac30052784c7ff5df499444ed536d4 | |
parent | 95095e422e94afa5a286c2a015aad4c039c9cbd4 (diff) |
regulator: tps65912: Use devm_regulator_register
devm_* simplifies the code.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r-- | drivers/regulator/tps65912-regulator.c | 24 |
1 files changed, 4 insertions, 20 deletions
diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c index 281e52ac64ba..1ed4d049abfe 100644 --- a/drivers/regulator/tps65912-regulator.c +++ b/drivers/regulator/tps65912-regulator.c | |||
@@ -461,7 +461,7 @@ static int tps65912_probe(struct platform_device *pdev) | |||
461 | struct regulator_dev *rdev; | 461 | struct regulator_dev *rdev; |
462 | struct tps65912_reg *pmic; | 462 | struct tps65912_reg *pmic; |
463 | struct tps65912_board *pmic_plat_data; | 463 | struct tps65912_board *pmic_plat_data; |
464 | int i, err; | 464 | int i; |
465 | 465 | ||
466 | pmic_plat_data = dev_get_platdata(tps65912->dev); | 466 | pmic_plat_data = dev_get_platdata(tps65912->dev); |
467 | if (!pmic_plat_data) | 467 | if (!pmic_plat_data) |
@@ -504,34 +504,19 @@ static int tps65912_probe(struct platform_device *pdev) | |||
504 | config.init_data = reg_data; | 504 | config.init_data = reg_data; |
505 | config.driver_data = pmic; | 505 | config.driver_data = pmic; |
506 | 506 | ||
507 | rdev = regulator_register(&pmic->desc[i], &config); | 507 | rdev = devm_regulator_register(&pdev->dev, &pmic->desc[i], |
508 | &config); | ||
508 | if (IS_ERR(rdev)) { | 509 | if (IS_ERR(rdev)) { |
509 | dev_err(tps65912->dev, | 510 | dev_err(tps65912->dev, |
510 | "failed to register %s regulator\n", | 511 | "failed to register %s regulator\n", |
511 | pdev->name); | 512 | pdev->name); |
512 | err = PTR_ERR(rdev); | 513 | return PTR_ERR(rdev); |
513 | goto err; | ||
514 | } | 514 | } |
515 | 515 | ||
516 | /* Save regulator for cleanup */ | 516 | /* Save regulator for cleanup */ |
517 | pmic->rdev[i] = rdev; | 517 | pmic->rdev[i] = rdev; |
518 | } | 518 | } |
519 | return 0; | 519 | return 0; |
520 | |||
521 | err: | ||
522 | while (--i >= 0) | ||
523 | regulator_unregister(pmic->rdev[i]); | ||
524 | return err; | ||
525 | } | ||
526 | |||
527 | static int tps65912_remove(struct platform_device *pdev) | ||
528 | { | ||
529 | struct tps65912_reg *tps65912_reg = platform_get_drvdata(pdev); | ||
530 | int i; | ||
531 | |||
532 | for (i = 0; i < TPS65912_NUM_REGULATOR; i++) | ||
533 | regulator_unregister(tps65912_reg->rdev[i]); | ||
534 | return 0; | ||
535 | } | 520 | } |
536 | 521 | ||
537 | static struct platform_driver tps65912_driver = { | 522 | static struct platform_driver tps65912_driver = { |
@@ -540,7 +525,6 @@ static struct platform_driver tps65912_driver = { | |||
540 | .owner = THIS_MODULE, | 525 | .owner = THIS_MODULE, |
541 | }, | 526 | }, |
542 | .probe = tps65912_probe, | 527 | .probe = tps65912_probe, |
543 | .remove = tps65912_remove, | ||
544 | }; | 528 | }; |
545 | 529 | ||
546 | static int __init tps65912_init(void) | 530 | static int __init tps65912_init(void) |