diff options
author | Robert Richter <robert.richter@amd.com> | 2009-05-14 11:10:52 -0400 |
---|---|---|
committer | Robert Richter <robert.richter@amd.com> | 2009-06-10 16:07:35 -0400 |
commit | 849620fab413355eff48232eac5a8c53c57615c5 (patch) | |
tree | 4aec13fcc0e1bb6a3dd1e36349473c7fe3477f86 | |
parent | 0886751c5d8b19fcee2e65d34ae21c9111e652a9 (diff) |
Revert "oprofile: discover counters for op ppro too"
This reverts commit 59512900baab03c5629f2ff5efad1d5d4e682ece.
arch_perfmon_setup_counters() is actually never called for ppro, so
there is no code that changes the numbers in op_ppro_spec. The patch
as it is has no effect.
Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
-rw-r--r-- | arch/x86/oprofile/op_model_ppro.c | 8 | ||||
-rw-r--r-- | arch/x86/oprofile/op_x86_model.h | 2 |
2 files changed, 4 insertions, 6 deletions
diff --git a/arch/x86/oprofile/op_model_ppro.c b/arch/x86/oprofile/op_model_ppro.c index 10131fbdaada..2a123990a84c 100644 --- a/arch/x86/oprofile/op_model_ppro.c +++ b/arch/x86/oprofile/op_model_ppro.c | |||
@@ -213,9 +213,9 @@ static void ppro_shutdown(struct op_msrs const * const msrs) | |||
213 | } | 213 | } |
214 | 214 | ||
215 | 215 | ||
216 | struct op_x86_model_spec op_ppro_spec = { | 216 | struct op_x86_model_spec const op_ppro_spec = { |
217 | .num_counters = 2, /* can be overriden */ | 217 | .num_counters = 2, |
218 | .num_controls = 2, /* dito */ | 218 | .num_controls = 2, |
219 | .fill_in_addresses = &ppro_fill_in_addresses, | 219 | .fill_in_addresses = &ppro_fill_in_addresses, |
220 | .setup_ctrs = &ppro_setup_ctrs, | 220 | .setup_ctrs = &ppro_setup_ctrs, |
221 | .check_ctrs = &ppro_check_ctrs, | 221 | .check_ctrs = &ppro_check_ctrs, |
@@ -251,8 +251,6 @@ void arch_perfmon_setup_counters(void) | |||
251 | 251 | ||
252 | op_arch_perfmon_spec.num_counters = num_counters; | 252 | op_arch_perfmon_spec.num_counters = num_counters; |
253 | op_arch_perfmon_spec.num_controls = num_counters; | 253 | op_arch_perfmon_spec.num_controls = num_counters; |
254 | op_ppro_spec.num_counters = num_counters; | ||
255 | op_ppro_spec.num_controls = num_counters; | ||
256 | } | 254 | } |
257 | 255 | ||
258 | struct op_x86_model_spec op_arch_perfmon_spec = { | 256 | struct op_x86_model_spec op_arch_perfmon_spec = { |
diff --git a/arch/x86/oprofile/op_x86_model.h b/arch/x86/oprofile/op_x86_model.h index 825e79064d64..2317149c94f0 100644 --- a/arch/x86/oprofile/op_x86_model.h +++ b/arch/x86/oprofile/op_x86_model.h | |||
@@ -45,7 +45,7 @@ struct op_x86_model_spec { | |||
45 | void (*shutdown)(struct op_msrs const * const msrs); | 45 | void (*shutdown)(struct op_msrs const * const msrs); |
46 | }; | 46 | }; |
47 | 47 | ||
48 | extern struct op_x86_model_spec op_ppro_spec; | 48 | extern struct op_x86_model_spec const op_ppro_spec; |
49 | extern struct op_x86_model_spec const op_p4_spec; | 49 | extern struct op_x86_model_spec const op_p4_spec; |
50 | extern struct op_x86_model_spec const op_p4_ht2_spec; | 50 | extern struct op_x86_model_spec const op_p4_ht2_spec; |
51 | extern struct op_x86_model_spec const op_amd_spec; | 51 | extern struct op_x86_model_spec const op_amd_spec; |