diff options
author | Hariprasad Shenai <hariprasad@chelsio.com> | 2015-03-19 12:57:36 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-03-19 15:30:21 -0400 |
commit | 768ffc66b45fd6551162d64ac8d92c101725262a (patch) | |
tree | a0fe3040612ba917bdfd64846e4abdc1a15bb263 | |
parent | 933e0db118fd6f73f8692c29ed47994c7e073552 (diff) |
cxgb4/cxgb4vf/csiostor: Make PCI Device ID Tables be "const"
Make PCI Device ID Tables be "const" to move them out of the data segment and
remove a redundant check on CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN in
t4_pci_id_tbl.h to guard the contents of the include file.
Signed-off-by: Casey Leedom <leedom@chelsio.com>
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 4 | ||||
-rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 | ||||
-rw-r--r-- | drivers/scsi/csiostor/csio_init.c | 2 |
4 files changed, 3 insertions, 7 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 4af8a9fd75ae..dd4b2da6e468 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | |||
@@ -124,7 +124,7 @@ struct filter_entry { | |||
124 | /* Macros needed to support the PCI Device ID Table ... | 124 | /* Macros needed to support the PCI Device ID Table ... |
125 | */ | 125 | */ |
126 | #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \ | 126 | #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \ |
127 | static struct pci_device_id cxgb4_pci_tbl[] = { | 127 | static const struct pci_device_id cxgb4_pci_tbl[] = { |
128 | #define CH_PCI_DEVICE_ID_FUNCTION 0x4 | 128 | #define CH_PCI_DEVICE_ID_FUNCTION 0x4 |
129 | 129 | ||
130 | /* Include PCI Device IDs for both PF4 and PF0-3 so our PCI probe() routine is | 130 | /* Include PCI Device IDs for both PF4 and PF0-3 so our PCI probe() routine is |
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h index ee877c008493..1a9a6f334d2d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | |||
@@ -60,8 +60,6 @@ | |||
60 | * -- Used to finish the definition of the PCI ID Table. Note that we | 60 | * -- Used to finish the definition of the PCI ID Table. Note that we |
61 | * -- will be adding a trailing semi-colon (";") here. | 61 | * -- will be adding a trailing semi-colon (";") here. |
62 | */ | 62 | */ |
63 | #ifdef CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN | ||
64 | |||
65 | #ifndef CH_PCI_DEVICE_ID_FUNCTION | 63 | #ifndef CH_PCI_DEVICE_ID_FUNCTION |
66 | #error CH_PCI_DEVICE_ID_FUNCTION not defined! | 64 | #error CH_PCI_DEVICE_ID_FUNCTION not defined! |
67 | #endif | 65 | #endif |
@@ -157,6 +155,4 @@ CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN | |||
157 | CH_PCI_ID_TABLE_FENTRY(0x5090), /* Custom T540-CR */ | 155 | CH_PCI_ID_TABLE_FENTRY(0x5090), /* Custom T540-CR */ |
158 | CH_PCI_DEVICE_ID_TABLE_DEFINE_END; | 156 | CH_PCI_DEVICE_ID_TABLE_DEFINE_END; |
159 | 157 | ||
160 | #endif /* CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN */ | ||
161 | |||
162 | #endif /* __T4_PCI_ID_TBL_H__ */ | 158 | #endif /* __T4_PCI_ID_TBL_H__ */ |
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c index 122e2964e63b..1d893b0b7ddf 100644 --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | |||
@@ -3034,7 +3034,7 @@ static void cxgb4vf_pci_shutdown(struct pci_dev *pdev) | |||
3034 | /* Macros needed to support the PCI Device ID Table ... | 3034 | /* Macros needed to support the PCI Device ID Table ... |
3035 | */ | 3035 | */ |
3036 | #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \ | 3036 | #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \ |
3037 | static struct pci_device_id cxgb4vf_pci_tbl[] = { | 3037 | static const struct pci_device_id cxgb4vf_pci_tbl[] = { |
3038 | #define CH_PCI_DEVICE_ID_FUNCTION 0x8 | 3038 | #define CH_PCI_DEVICE_ID_FUNCTION 0x8 |
3039 | 3039 | ||
3040 | #define CH_PCI_ID_TABLE_ENTRY(devid) \ | 3040 | #define CH_PCI_ID_TABLE_ENTRY(devid) \ |
diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c index d9631e15f7b5..dbe416ff46c2 100644 --- a/drivers/scsi/csiostor/csio_init.c +++ b/drivers/scsi/csiostor/csio_init.c | |||
@@ -1172,7 +1172,7 @@ static struct pci_error_handlers csio_err_handler = { | |||
1172 | * Macros needed to support the PCI Device ID Table ... | 1172 | * Macros needed to support the PCI Device ID Table ... |
1173 | */ | 1173 | */ |
1174 | #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \ | 1174 | #define CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN \ |
1175 | static struct pci_device_id csio_pci_tbl[] = { | 1175 | static const struct pci_device_id csio_pci_tbl[] = { |
1176 | /* Define for FCoE uses PF6 */ | 1176 | /* Define for FCoE uses PF6 */ |
1177 | #define CH_PCI_DEVICE_ID_FUNCTION 0x6 | 1177 | #define CH_PCI_DEVICE_ID_FUNCTION 0x6 |
1178 | 1178 | ||