diff options
author | H Hartley Sweeten <hartleys@visionengravers.com> | 2012-11-29 20:18:35 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-11-29 21:05:30 -0500 |
commit | 61034e002d8ad10d2265d33168d1dc721375869f (patch) | |
tree | 0f97a34e225da687e7d05b29f8893ac59ae1e4ae | |
parent | c0c3c7dfc1fd5c970b9893e68796314e8551124f (diff) |
staging: comedi: addi_apci_2032: cleanup the s->subdev_flags
The flags SDF_GROUND and SDF_COMMON only have meaning for analog
input/output subdevices. Remove these flags from the digital
output and timer subdevices in this driver.
The digital output subdevice does not need the SDF_READABLE flag.
Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/comedi/drivers/addi_apci_2032.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/comedi/drivers/addi_apci_2032.c b/drivers/staging/comedi/drivers/addi_apci_2032.c index 93ff8300fed8..26f6e0072ed0 100644 --- a/drivers/staging/comedi/drivers/addi_apci_2032.c +++ b/drivers/staging/comedi/drivers/addi_apci_2032.c | |||
@@ -59,8 +59,7 @@ static int apci2032_auto_attach(struct comedi_device *dev, | |||
59 | /* Initialize the digital output subdevice */ | 59 | /* Initialize the digital output subdevice */ |
60 | s = &dev->subdevices[0]; | 60 | s = &dev->subdevices[0]; |
61 | s->type = COMEDI_SUBD_DO; | 61 | s->type = COMEDI_SUBD_DO; |
62 | s->subdev_flags = | 62 | s->subdev_flags = SDF_WRITEABLE; |
63 | SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; | ||
64 | s->n_chan = 32; | 63 | s->n_chan = 32; |
65 | s->maxdata = 1; | 64 | s->maxdata = 1; |
66 | s->range_table = &range_digital; | 65 | s->range_table = &range_digital; |
@@ -71,7 +70,7 @@ static int apci2032_auto_attach(struct comedi_device *dev, | |||
71 | /* Initialize the watchdog subdevice */ | 70 | /* Initialize the watchdog subdevice */ |
72 | s = &dev->subdevices[1]; | 71 | s = &dev->subdevices[1]; |
73 | s->type = COMEDI_SUBD_TIMER; | 72 | s->type = COMEDI_SUBD_TIMER; |
74 | s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; | 73 | s->subdev_flags = SDF_WRITEABLE; |
75 | s->n_chan = 1; | 74 | s->n_chan = 1; |
76 | s->maxdata = 0; | 75 | s->maxdata = 0; |
77 | s->len_chanlist = 1; | 76 | s->len_chanlist = 1; |