aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-05-30 03:50:46 -0400
committerJames Bottomley <JBottomley@Parallels.com>2013-06-26 20:41:44 -0400
commit5d65f91896197bd047f97ed8e7792b06de491eac (patch)
tree9eaf4f6f1531179197798251661759cd1a825e8e
parent607be2cff4f4899f47ef906eba5b147abc3c5da4 (diff)
[SCSI] fnic: potential dead lock in fnic_is_abts_pending()
There is an unlock missing if the == FNIC_IOREQ_ABTS_PENDING is false. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Hiral Patel <hiralpat@cisco.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
-rw-r--r--drivers/scsi/fnic/fnic_scsi.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index be99e7549d89..a97e6e584f8c 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -2432,11 +2432,9 @@ int fnic_is_abts_pending(struct fnic *fnic, struct scsi_cmnd *lr_sc)
2432 "Found IO in %s on lun\n", 2432 "Found IO in %s on lun\n",
2433 fnic_ioreq_state_to_str(CMD_STATE(sc))); 2433 fnic_ioreq_state_to_str(CMD_STATE(sc)));
2434 2434
2435 if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING) { 2435 if (CMD_STATE(sc) == FNIC_IOREQ_ABTS_PENDING)
2436 spin_unlock_irqrestore(io_lock, flags);
2437 ret = 1; 2436 ret = 1;
2438 continue; 2437 spin_unlock_irqrestore(io_lock, flags);
2439 }
2440 } 2438 }
2441 2439
2442 return ret; 2440 return ret;