diff options
author | Suzuki K. Poulose <suzuki@in.ibm.com> | 2012-08-31 03:09:18 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2012-10-24 12:20:11 -0400 |
commit | 03f2f93ae00762eb881424df1c688d034fd341ee (patch) | |
tree | d0f58d63e0447ff86c9e1c24ec226a0adcce4e8d | |
parent | 68e94f4eb56d92ccb617a98fcac5e575702ec4fd (diff) |
Account the nr_entries in rblist properly
The nr_entries in rblist is never decremented when an element
is deleted. Also, use rblist__remove_node to delete a node in
rblist__delete(). This would keep the nr_entries sane.
Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com>
Acked-by: David S. Ahern <dsahern@gmail.com>
Cc: David S. Ahern <dsahern@gmail.com>
Link: http://lkml.kernel.org/r/20120831070834.14806.87398.stgit@suzukikp.in.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/util/rblist.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/perf/util/rblist.c b/tools/perf/util/rblist.c index 0171fb611004..a16cdd2625ad 100644 --- a/tools/perf/util/rblist.c +++ b/tools/perf/util/rblist.c | |||
@@ -44,6 +44,7 @@ int rblist__add_node(struct rblist *rblist, const void *new_entry) | |||
44 | void rblist__remove_node(struct rblist *rblist, struct rb_node *rb_node) | 44 | void rblist__remove_node(struct rblist *rblist, struct rb_node *rb_node) |
45 | { | 45 | { |
46 | rb_erase(rb_node, &rblist->entries); | 46 | rb_erase(rb_node, &rblist->entries); |
47 | --rblist->nr_entries; | ||
47 | rblist->node_delete(rblist, rb_node); | 48 | rblist->node_delete(rblist, rb_node); |
48 | } | 49 | } |
49 | 50 | ||
@@ -87,8 +88,7 @@ void rblist__delete(struct rblist *rblist) | |||
87 | while (next) { | 88 | while (next) { |
88 | pos = next; | 89 | pos = next; |
89 | next = rb_next(pos); | 90 | next = rb_next(pos); |
90 | rb_erase(pos, &rblist->entries); | 91 | rblist__remove_node(rblist, pos); |
91 | rblist->node_delete(rblist, pos); | ||
92 | } | 92 | } |
93 | free(rblist); | 93 | free(rblist); |
94 | } | 94 | } |