diff options
author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2006-06-15 13:02:25 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2006-06-18 11:17:42 -0400 |
commit | cc1a852137d6c12d50c372d61a1c5f763998536b (patch) | |
tree | d7c01ac23534b98ae76af22f1a914b4a569176dc | |
parent | ce7a3fdc5c55fd01d8e2deda0daef84473644f8b (diff) |
[ARM] Replace extramask with a full copy of the sigmask
There's not much point in splitting the sigmask between two different
locations, so copy it entirely into a proper sigset_t. This will
eventually allow rt_sigframe and sigframe to share more code.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r-- | arch/arm/kernel/signal.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c index 0ddbf2795c5b..7a4213ef0f46 100644 --- a/arch/arm/kernel/signal.c +++ b/arch/arm/kernel/signal.c | |||
@@ -194,7 +194,7 @@ struct aux_sigframe { | |||
194 | */ | 194 | */ |
195 | struct sigframe { | 195 | struct sigframe { |
196 | struct sigcontext sc; | 196 | struct sigcontext sc; |
197 | unsigned long extramask[_NSIG_WORDS-1]; | 197 | sigset_t sigmask; |
198 | unsigned long retcode[2]; | 198 | unsigned long retcode[2]; |
199 | struct aux_sigframe aux __attribute__((aligned(8))); | 199 | struct aux_sigframe aux __attribute__((aligned(8))); |
200 | }; | 200 | }; |
@@ -264,10 +264,7 @@ asmlinkage int sys_sigreturn(struct pt_regs *regs) | |||
264 | 264 | ||
265 | if (!access_ok(VERIFY_READ, frame, sizeof (*frame))) | 265 | if (!access_ok(VERIFY_READ, frame, sizeof (*frame))) |
266 | goto badframe; | 266 | goto badframe; |
267 | if (__get_user(set.sig[0], &frame->sc.oldmask) | 267 | if (__copy_from_user(&set, &frame->sigmask, sizeof(set))) |
268 | || (_NSIG_WORDS > 1 | ||
269 | && __copy_from_user(&set.sig[1], &frame->extramask, | ||
270 | sizeof(frame->extramask)))) | ||
271 | goto badframe; | 268 | goto badframe; |
272 | 269 | ||
273 | sigdelsetmask(&set, ~_BLOCKABLE); | 270 | sigdelsetmask(&set, ~_BLOCKABLE); |
@@ -486,11 +483,7 @@ setup_frame(int usig, struct k_sigaction *ka, sigset_t *set, struct pt_regs *reg | |||
486 | return 1; | 483 | return 1; |
487 | 484 | ||
488 | err |= setup_sigcontext(&frame->sc, &frame->aux, regs, set->sig[0]); | 485 | err |= setup_sigcontext(&frame->sc, &frame->aux, regs, set->sig[0]); |
489 | 486 | err |= __copy_to_user(&frame->sigmask, set, sizeof(*set)); | |
490 | if (_NSIG_WORDS > 1) { | ||
491 | err |= __copy_to_user(frame->extramask, &set->sig[1], | ||
492 | sizeof(frame->extramask)); | ||
493 | } | ||
494 | 487 | ||
495 | if (err == 0) | 488 | if (err == 0) |
496 | err = setup_return(regs, ka, frame->retcode, frame, usig); | 489 | err = setup_return(regs, ka, frame->retcode, frame, usig); |