aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilip Craig <philipc@snapgear.com>2006-06-20 21:33:26 -0400
committerJeff Garzik <jeff@garzik.org>2006-06-22 23:20:29 -0400
commitd73f1e3c3b0703e25728ce5bdda9806d6f2c576f (patch)
tree5bb928aa9d053bf14cc5a2a2eeb63e6ffa6160d6
parentfc13dcae24bfd877aeff07774c035b2b896e05ca (diff)
[PATCH] 8139cp: fix eeprom read command length
The read command for the 93C46/93C56 EEPROMS should be 3 bits plus the address. This doesn't appear to affect the operation of the read command, but similar errors for write commands do cause failures. Signed-off-by: Philip Craig <philipc@snapgear.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r--drivers/net/8139cp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index 46d8c01437e9..b49be8f2c107 100644
--- a/drivers/net/8139cp.c
+++ b/drivers/net/8139cp.c
@@ -1628,7 +1628,7 @@ static int read_eeprom (void __iomem *ioaddr, int location, int addr_len)
1628 eeprom_delay (); 1628 eeprom_delay ();
1629 1629
1630 /* Shift the read command bits out. */ 1630 /* Shift the read command bits out. */
1631 for (i = 4 + addr_len; i >= 0; i--) { 1631 for (i = 3 + addr_len - 1; i >= 0; i--) {
1632 int dataval = (read_cmd & (1 << i)) ? EE_DATA_WRITE : 0; 1632 int dataval = (read_cmd & (1 << i)) ? EE_DATA_WRITE : 0;
1633 writeb (EE_ENB | dataval, ee_addr); 1633 writeb (EE_ENB | dataval, ee_addr);
1634 eeprom_delay (); 1634 eeprom_delay ();