diff options
author | Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-16 19:40:04 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-16 19:40:04 -0500 |
commit | 1b9bb3c14c60324b54645ffefbe6d270f9fd191c (patch) | |
tree | e22157379c9b826f9691a0a9af0be7f08cc68d37 | |
parent | 0e12c5e85e6fe0a247d547a28a1884915cd3f5b9 (diff) | |
parent | d355c3c23ce56ab83e41f2bfb30d02fb90618530 (diff) |
Merge master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6
* master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6:
aoe: Add forgotten NULL at end of attribute list in aoeblk.c
debugfs: check return value correctly
W1: ioremap balanced with iounmap
-rw-r--r-- | drivers/block/aoe/aoeblk.c | 1 | ||||
-rw-r--r-- | drivers/w1/masters/matrox_w1.c | 2 | ||||
-rw-r--r-- | fs/debugfs/inode.c | 4 |
3 files changed, 5 insertions, 2 deletions
diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index d433f27e0ce2..aa25f8b09fe3 100644 --- a/drivers/block/aoe/aoeblk.c +++ b/drivers/block/aoe/aoeblk.c | |||
@@ -68,6 +68,7 @@ static struct attribute *aoe_attrs[] = { | |||
68 | &disk_attr_mac.attr, | 68 | &disk_attr_mac.attr, |
69 | &disk_attr_netif.attr, | 69 | &disk_attr_netif.attr, |
70 | &disk_attr_fwver.attr, | 70 | &disk_attr_fwver.attr, |
71 | NULL | ||
71 | }; | 72 | }; |
72 | 73 | ||
73 | static const struct attribute_group attr_group = { | 74 | static const struct attribute_group attr_group = { |
diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index 2788b8ca9bb1..6f9d880ab2e9 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c | |||
@@ -215,6 +215,8 @@ static int __devinit matrox_w1_probe(struct pci_dev *pdev, const struct pci_devi | |||
215 | return 0; | 215 | return 0; |
216 | 216 | ||
217 | err_out_free_device: | 217 | err_out_free_device: |
218 | if (dev->virt_addr) | ||
219 | iounmap(dev->virt_addr); | ||
218 | kfree(dev); | 220 | kfree(dev); |
219 | 221 | ||
220 | return err; | 222 | return err; |
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index e77676df6713..a736d44989c4 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c | |||
@@ -147,13 +147,13 @@ static int debugfs_create_by_name(const char *name, mode_t mode, | |||
147 | *dentry = NULL; | 147 | *dentry = NULL; |
148 | mutex_lock(&parent->d_inode->i_mutex); | 148 | mutex_lock(&parent->d_inode->i_mutex); |
149 | *dentry = lookup_one_len(name, parent, strlen(name)); | 149 | *dentry = lookup_one_len(name, parent, strlen(name)); |
150 | if (!IS_ERR(dentry)) { | 150 | if (!IS_ERR(*dentry)) { |
151 | if ((mode & S_IFMT) == S_IFDIR) | 151 | if ((mode & S_IFMT) == S_IFDIR) |
152 | error = debugfs_mkdir(parent->d_inode, *dentry, mode); | 152 | error = debugfs_mkdir(parent->d_inode, *dentry, mode); |
153 | else | 153 | else |
154 | error = debugfs_create(parent->d_inode, *dentry, mode); | 154 | error = debugfs_create(parent->d_inode, *dentry, mode); |
155 | } else | 155 | } else |
156 | error = PTR_ERR(dentry); | 156 | error = PTR_ERR(*dentry); |
157 | mutex_unlock(&parent->d_inode->i_mutex); | 157 | mutex_unlock(&parent->d_inode->i_mutex); |
158 | 158 | ||
159 | return error; | 159 | return error; |