aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2008-02-26 00:40:50 -0500
committerTrond Myklebust <Trond.Myklebust@netapp.com>2008-02-29 02:26:25 -0500
commitf5fb7b06e4e4ab18326f067f4317b2016ce18af2 (patch)
treec1a2c972d373d503b432f592b52d4fd2a59a1b46
parenteb276c0e10187702928aeaa133e1d3dbaf3eafc7 (diff)
SUNRPC: Eliminate the now-redundant rpc_start_wakeup()
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--include/linux/sunrpc/sched.h12
-rw-r--r--net/sunrpc/sched.c8
2 files changed, 3 insertions, 17 deletions
diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h
index 0d7be1642dc0..bf69fce84ed0 100644
--- a/include/linux/sunrpc/sched.h
+++ b/include/linux/sunrpc/sched.h
@@ -142,8 +142,7 @@ struct rpc_task_setup {
142 142
143#define RPC_TASK_RUNNING 0 143#define RPC_TASK_RUNNING 0
144#define RPC_TASK_QUEUED 1 144#define RPC_TASK_QUEUED 1
145#define RPC_TASK_WAKEUP 2 145#define RPC_TASK_ACTIVE 2
146#define RPC_TASK_ACTIVE 3
147 146
148#define RPC_IS_RUNNING(t) test_bit(RPC_TASK_RUNNING, &(t)->tk_runstate) 147#define RPC_IS_RUNNING(t) test_bit(RPC_TASK_RUNNING, &(t)->tk_runstate)
149#define rpc_set_running(t) set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate) 148#define rpc_set_running(t) set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate)
@@ -165,15 +164,6 @@ struct rpc_task_setup {
165 smp_mb__after_clear_bit(); \ 164 smp_mb__after_clear_bit(); \
166 } while (0) 165 } while (0)
167 166
168#define rpc_start_wakeup(t) \
169 (test_and_set_bit(RPC_TASK_WAKEUP, &(t)->tk_runstate) == 0)
170#define rpc_finish_wakeup(t) \
171 do { \
172 smp_mb__before_clear_bit(); \
173 clear_bit(RPC_TASK_WAKEUP, &(t)->tk_runstate); \
174 smp_mb__after_clear_bit(); \
175 } while (0)
176
177#define RPC_IS_ACTIVATED(t) test_bit(RPC_TASK_ACTIVE, &(t)->tk_runstate) 167#define RPC_IS_ACTIVATED(t) test_bit(RPC_TASK_ACTIVE, &(t)->tk_runstate)
178 168
179/* 169/*
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c
index 043eef4c15a2..88a686a8e43e 100644
--- a/net/sunrpc/sched.c
+++ b/net/sunrpc/sched.c
@@ -384,12 +384,8 @@ static void __rpc_do_wake_up_task(struct rpc_wait_queue *queue, struct rpc_task
384 */ 384 */
385static void rpc_wake_up_task_queue_locked(struct rpc_wait_queue *queue, struct rpc_task *task) 385static void rpc_wake_up_task_queue_locked(struct rpc_wait_queue *queue, struct rpc_task *task)
386{ 386{
387 if (!RPC_IS_QUEUED(task) || task->tk_waitqueue != queue) 387 if (RPC_IS_QUEUED(task) && task->tk_waitqueue == queue)
388 return; 388 __rpc_do_wake_up_task(queue, task);
389 if (rpc_start_wakeup(task)) {
390 __rpc_do_wake_up_task(queue, task);
391 rpc_finish_wakeup(task);
392 }
393} 389}
394 390
395/* 391/*