diff options
author | Horms <horms@verge.net.au> | 2007-03-19 02:06:44 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2007-03-20 12:30:31 -0400 |
commit | b364fd5081b02fa8a966a29eea2da628913fd4b8 (patch) | |
tree | 3cffc336ce2ca8704702f88af95102ab474a351a | |
parent | a1f9ce056a1875b6c8633f370df4fb169b925b16 (diff) |
[SCSI] fusion: honour return value of pci_enable_device() in mpt_resume()
Honour the return value of pci_enable_device(), which
seems to be a desirable thing to do:
2.6.20-rc4
gcc (GCC) 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
CC [M] drivers/message/fusion/mptbase.o
drivers/message/fusion/mptbase.c: In function `mpt_resume':
drivers/message/fusion/mptbase.c:1541: warning: ignoring return value
of `pci_enable_device', declared with attribute warn_unused_result
It also in turn has mptscsih_resume() honour the return value of
mpt_resume()
I'm not sure about the handling of the other potential error cases
in mpt_resume(), of which there appear to be many. But this does
seem to be a good start.
Signed-off-by: Simon Horman <horms@verge.net.au>
Acked-by: "Moore, Eric" <Eric.Moore@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r-- | drivers/message/fusion/mptbase.c | 5 | ||||
-rw-r--r-- | drivers/message/fusion/mptscsih.c | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 0a2d7db7b634..97471af4309c 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c | |||
@@ -1531,6 +1531,7 @@ mpt_resume(struct pci_dev *pdev) | |||
1531 | MPT_ADAPTER *ioc = pci_get_drvdata(pdev); | 1531 | MPT_ADAPTER *ioc = pci_get_drvdata(pdev); |
1532 | u32 device_state = pdev->current_state; | 1532 | u32 device_state = pdev->current_state; |
1533 | int recovery_state; | 1533 | int recovery_state; |
1534 | int err; | ||
1534 | 1535 | ||
1535 | printk(MYIOC_s_INFO_FMT | 1536 | printk(MYIOC_s_INFO_FMT |
1536 | "pci-resume: pdev=0x%p, slot=%s, Previous operating state [D%d]\n", | 1537 | "pci-resume: pdev=0x%p, slot=%s, Previous operating state [D%d]\n", |
@@ -1538,7 +1539,9 @@ mpt_resume(struct pci_dev *pdev) | |||
1538 | 1539 | ||
1539 | pci_set_power_state(pdev, 0); | 1540 | pci_set_power_state(pdev, 0); |
1540 | pci_restore_state(pdev); | 1541 | pci_restore_state(pdev); |
1541 | pci_enable_device(pdev); | 1542 | err = pci_enable_device(pdev); |
1543 | if (err) | ||
1544 | return err; | ||
1542 | 1545 | ||
1543 | /* enable interrupts */ | 1546 | /* enable interrupts */ |
1544 | CHIPREG_WRITE32(&ioc->chip->IntMask, MPI_HIM_DIM); | 1547 | CHIPREG_WRITE32(&ioc->chip->IntMask, MPI_HIM_DIM); |
diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c index 10927e34c2b4..537fcc221c9d 100644 --- a/drivers/message/fusion/mptscsih.c +++ b/drivers/message/fusion/mptscsih.c | |||
@@ -1188,8 +1188,7 @@ mptscsih_suspend(struct pci_dev *pdev, pm_message_t state) | |||
1188 | int | 1188 | int |
1189 | mptscsih_resume(struct pci_dev *pdev) | 1189 | mptscsih_resume(struct pci_dev *pdev) |
1190 | { | 1190 | { |
1191 | mpt_resume(pdev); | 1191 | return mpt_resume(pdev); |
1192 | return 0; | ||
1193 | } | 1192 | } |
1194 | 1193 | ||
1195 | #endif | 1194 | #endif |