diff options
author | Nathan Lynch <ntl@pobox.com> | 2010-08-10 21:03:08 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-11 11:59:20 -0400 |
commit | a2a20c412c86e0bb46a9ab0dd31bcfe6d201b913 (patch) | |
tree | 25d32209eab03f3e3aa5eca7a93e5199174abb5a | |
parent | c7e49c1488ab20342eaaf38f1ca35a207f4c051d (diff) |
signalfd: fill in ssi_int for posix timers and message queues
If signalfd is used to consume a signal generated by a POSIX interval
timer or POSIX message queue, the ssi_int field does not reflect the data
(sigevent->sigev_value) supplied to timer_create(2) or mq_notify(3). (The
ssi_ptr field, however, is filled in.)
This behavior differs from signalfd's treatment of sigqueue-generated
signals -- see the default case in signalfd_copyinfo. It also gives
results that differ from the case when a signal is handled conventionally
via a sigaction-registered handler.
So, set signalfd_siginfo->ssi_int in the remaining cases (__SI_TIMER,
__SI_MESGQ) where ssi_ptr is set.
akpm: a non-back-compatible change. Merge into -stable to minimise the
number of kernels which are in the field and which miss this feature.
Signed-off-by: Nathan Lynch <ntl@pobox.com>
Acked-by: Davide Libenzi <davidel@xmailserver.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | fs/signalfd.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/signalfd.c b/fs/signalfd.c index f329849ce3c0..1c5a6add779d 100644 --- a/fs/signalfd.c +++ b/fs/signalfd.c | |||
@@ -88,6 +88,7 @@ static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo, | |||
88 | err |= __put_user(kinfo->si_tid, &uinfo->ssi_tid); | 88 | err |= __put_user(kinfo->si_tid, &uinfo->ssi_tid); |
89 | err |= __put_user(kinfo->si_overrun, &uinfo->ssi_overrun); | 89 | err |= __put_user(kinfo->si_overrun, &uinfo->ssi_overrun); |
90 | err |= __put_user((long) kinfo->si_ptr, &uinfo->ssi_ptr); | 90 | err |= __put_user((long) kinfo->si_ptr, &uinfo->ssi_ptr); |
91 | err |= __put_user(kinfo->si_int, &uinfo->ssi_int); | ||
91 | break; | 92 | break; |
92 | case __SI_POLL: | 93 | case __SI_POLL: |
93 | err |= __put_user(kinfo->si_band, &uinfo->ssi_band); | 94 | err |= __put_user(kinfo->si_band, &uinfo->ssi_band); |
@@ -111,6 +112,7 @@ static int signalfd_copyinfo(struct signalfd_siginfo __user *uinfo, | |||
111 | err |= __put_user(kinfo->si_pid, &uinfo->ssi_pid); | 112 | err |= __put_user(kinfo->si_pid, &uinfo->ssi_pid); |
112 | err |= __put_user(kinfo->si_uid, &uinfo->ssi_uid); | 113 | err |= __put_user(kinfo->si_uid, &uinfo->ssi_uid); |
113 | err |= __put_user((long) kinfo->si_ptr, &uinfo->ssi_ptr); | 114 | err |= __put_user((long) kinfo->si_ptr, &uinfo->ssi_ptr); |
115 | err |= __put_user(kinfo->si_int, &uinfo->ssi_int); | ||
114 | break; | 116 | break; |
115 | default: | 117 | default: |
116 | /* | 118 | /* |