diff options
author | Michal Nazarewicz <m.nazarewicz@samsung.com> | 2010-05-05 06:53:12 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-20 16:21:42 -0400 |
commit | 8120a8aadb2059e29982561658bc6675126f8105 (patch) | |
tree | 1e05b58df0397b76c7ad1543d2af21e746e44369 | |
parent | 22c43c81a51e05f61e90445ceb59d486c12fd921 (diff) |
fs/timerfd.c: make use of wait_event_interruptible_locked_irq()
This patch modifies the fs/timerfd.c to use the newly created
wait_event_interruptible_locked_irq() macro. This replaces an open
code implementation with a single macro call.
Signed-off-by: Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Roland Dreier <rolandd@cisco.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christoph Lameter <cl@linux-foundation.org>
Cc: Davide Libenzi <davidel@xmailserver.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | fs/timerfd.c | 25 |
1 files changed, 4 insertions, 21 deletions
diff --git a/fs/timerfd.c b/fs/timerfd.c index 98158de91d24..b86ab8eff79a 100644 --- a/fs/timerfd.c +++ b/fs/timerfd.c | |||
@@ -110,31 +110,14 @@ static ssize_t timerfd_read(struct file *file, char __user *buf, size_t count, | |||
110 | struct timerfd_ctx *ctx = file->private_data; | 110 | struct timerfd_ctx *ctx = file->private_data; |
111 | ssize_t res; | 111 | ssize_t res; |
112 | u64 ticks = 0; | 112 | u64 ticks = 0; |
113 | DECLARE_WAITQUEUE(wait, current); | ||
114 | 113 | ||
115 | if (count < sizeof(ticks)) | 114 | if (count < sizeof(ticks)) |
116 | return -EINVAL; | 115 | return -EINVAL; |
117 | spin_lock_irq(&ctx->wqh.lock); | 116 | spin_lock_irq(&ctx->wqh.lock); |
118 | res = -EAGAIN; | 117 | if (file->f_flags & O_NONBLOCK) |
119 | if (!ctx->ticks && !(file->f_flags & O_NONBLOCK)) { | 118 | res = -EAGAIN; |
120 | __add_wait_queue(&ctx->wqh, &wait); | 119 | else |
121 | for (res = 0;;) { | 120 | res = wait_event_interruptible_locked_irq(ctx->wqh, ctx->ticks); |
122 | set_current_state(TASK_INTERRUPTIBLE); | ||
123 | if (ctx->ticks) { | ||
124 | res = 0; | ||
125 | break; | ||
126 | } | ||
127 | if (signal_pending(current)) { | ||
128 | res = -ERESTARTSYS; | ||
129 | break; | ||
130 | } | ||
131 | spin_unlock_irq(&ctx->wqh.lock); | ||
132 | schedule(); | ||
133 | spin_lock_irq(&ctx->wqh.lock); | ||
134 | } | ||
135 | __remove_wait_queue(&ctx->wqh, &wait); | ||
136 | __set_current_state(TASK_RUNNING); | ||
137 | } | ||
138 | if (ctx->ticks) { | 121 | if (ctx->ticks) { |
139 | ticks = ctx->ticks; | 122 | ticks = ctx->ticks; |
140 | if (ctx->expired && ctx->tintv.tv64) { | 123 | if (ctx->expired && ctx->tintv.tv64) { |