diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2008-12-29 07:40:31 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-01-05 11:54:29 -0500 |
commit | 5b45d96bf963afeb931a75faf02fb424e446e5a9 (patch) | |
tree | 12f77648fc10aad3cc188537ce7a82dc9b3275a3 | |
parent | d8e9650dff48055057253ca30933605bd7d0733b (diff) |
fix the treatment of jfs special inodes
We used to put them on a single list, without any locking. Racy.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r-- | fs/jfs/jfs_imap.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/fs/jfs/jfs_imap.c b/fs/jfs/jfs_imap.c index d6363d8309d0..0f94381ca6d0 100644 --- a/fs/jfs/jfs_imap.c +++ b/fs/jfs/jfs_imap.c | |||
@@ -58,9 +58,9 @@ | |||
58 | 58 | ||
59 | /* | 59 | /* |
60 | * __mark_inode_dirty expects inodes to be hashed. Since we don't want | 60 | * __mark_inode_dirty expects inodes to be hashed. Since we don't want |
61 | * special inodes in the fileset inode space, we hash them to a dummy head | 61 | * special inodes in the fileset inode space, we make them appear hashed, |
62 | * but do not put on any lists. | ||
62 | */ | 63 | */ |
63 | static HLIST_HEAD(aggregate_hash); | ||
64 | 64 | ||
65 | /* | 65 | /* |
66 | * imap locks | 66 | * imap locks |
@@ -496,7 +496,11 @@ struct inode *diReadSpecial(struct super_block *sb, ino_t inum, int secondary) | |||
496 | /* release the page */ | 496 | /* release the page */ |
497 | release_metapage(mp); | 497 | release_metapage(mp); |
498 | 498 | ||
499 | hlist_add_head(&ip->i_hash, &aggregate_hash); | 499 | /* |
500 | * that will look hashed, but won't be on any list; hlist_del() | ||
501 | * will work fine and require no locking. | ||
502 | */ | ||
503 | ip->i_hash.pprev = &ip->i_hash.next; | ||
500 | 504 | ||
501 | return (ip); | 505 | return (ip); |
502 | } | 506 | } |