aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@vyatta.com>2009-01-08 14:17:13 -0500
committerDavid S. Miller <davem@davemloft.net>2009-01-08 14:17:13 -0500
commit283a21d3e16e9709012cc8b0839ec474d8888a5d (patch)
tree34345accb5f219a2802013cca8a14bb318abff7a
parent9fd7a1d92b4462acaa460bb0f58b12ede6ffe6b9 (diff)
pcnet32: round off carrier watch timer
The link check watchdog timer on this driver fires every two seconds, but since not aligned it causes extra wakeups. It is more important on this driver than most because it is the hardware that is emulated by default when using network interfaces on VMware. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/pcnet32.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index c1bef953bf07..665a4286da39 100644
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -2282,7 +2282,7 @@ static int pcnet32_open(struct net_device *dev)
2282 if (lp->chip_version >= PCNET32_79C970A) { 2282 if (lp->chip_version >= PCNET32_79C970A) {
2283 /* Print the link status and start the watchdog */ 2283 /* Print the link status and start the watchdog */
2284 pcnet32_check_media(dev, 1); 2284 pcnet32_check_media(dev, 1);
2285 mod_timer(&(lp->watchdog_timer), PCNET32_WATCHDOG_TIMEOUT); 2285 mod_timer(&lp->watchdog_timer, PCNET32_WATCHDOG_TIMEOUT);
2286 } 2286 }
2287 2287
2288 i = 0; 2288 i = 0;
@@ -2917,7 +2917,7 @@ static void pcnet32_watchdog(struct net_device *dev)
2917 pcnet32_check_media(dev, 0); 2917 pcnet32_check_media(dev, 0);
2918 spin_unlock_irqrestore(&lp->lock, flags); 2918 spin_unlock_irqrestore(&lp->lock, flags);
2919 2919
2920 mod_timer(&(lp->watchdog_timer), PCNET32_WATCHDOG_TIMEOUT); 2920 mod_timer(&lp->watchdog_timer, round_jiffies(PCNET32_WATCHDOG_TIMEOUT));
2921} 2921}
2922 2922
2923static int pcnet32_pm_suspend(struct pci_dev *pdev, pm_message_t state) 2923static int pcnet32_pm_suspend(struct pci_dev *pdev, pm_message_t state)