diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2007-09-11 18:00:25 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2007-10-09 17:16:45 -0400 |
commit | d66968f207b6402fd12c20145cb31dbe3608979c (patch) | |
tree | 693fd189a2d9b414edfc9139db784ba6e48a1999 | |
parent | 06b8d2552d50f802a3277137a565febcd59ef037 (diff) |
SUNRPC: Clean up in rpc_show_tasks
/home/cel/linux/net/sunrpc/clnt.c: In function ‘rpc_show_tasks’:
/home/cel/linux/net/sunrpc/clnt.c:1538: warning:
signed and unsigned type in conditional expression
This points out another case where a conditional expression returns a
signed value in one arm and an unsigned value in the other.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | net/sunrpc/clnt.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 0357819ffdb0..7a7cd3b7acce 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c | |||
@@ -1526,13 +1526,18 @@ void rpc_show_tasks(void) | |||
1526 | spin_lock(&clnt->cl_lock); | 1526 | spin_lock(&clnt->cl_lock); |
1527 | list_for_each_entry(t, &clnt->cl_tasks, tk_task) { | 1527 | list_for_each_entry(t, &clnt->cl_tasks, tk_task) { |
1528 | const char *rpc_waitq = "none"; | 1528 | const char *rpc_waitq = "none"; |
1529 | int proc; | ||
1530 | |||
1531 | if (t->tk_msg.rpc_proc) | ||
1532 | proc = t->tk_msg.rpc_proc->p_proc; | ||
1533 | else | ||
1534 | proc = -1; | ||
1529 | 1535 | ||
1530 | if (RPC_IS_QUEUED(t)) | 1536 | if (RPC_IS_QUEUED(t)) |
1531 | rpc_waitq = rpc_qname(t->u.tk_wait.rpc_waitq); | 1537 | rpc_waitq = rpc_qname(t->u.tk_wait.rpc_waitq); |
1532 | 1538 | ||
1533 | printk("%5u %04d %04x %6d %8p %6d %8p %8ld %8s %8p %8p\n", | 1539 | printk("%5u %04d %04x %6d %8p %6d %8p %8ld %8s %8p %8p\n", |
1534 | t->tk_pid, | 1540 | t->tk_pid, proc, |
1535 | (t->tk_msg.rpc_proc ? t->tk_msg.rpc_proc->p_proc : -1), | ||
1536 | t->tk_flags, t->tk_status, | 1541 | t->tk_flags, t->tk_status, |
1537 | t->tk_client, | 1542 | t->tk_client, |
1538 | (t->tk_client ? t->tk_client->cl_prog : 0), | 1543 | (t->tk_client ? t->tk_client->cl_prog : 0), |