aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Carlson <mcarlson@broadcom.com>2008-12-21 23:18:56 -0500
committerDavid S. Miller <davem@davemloft.net>2008-12-21 23:18:56 -0500
commit2023276ebf074a01eb56f38ed4d04deef1deee67 (patch)
tree5e5af7f26637298841ca0a2e761f2b929b95ebd6
parent7f3ff4f63f76c2702da6041d2da5eb30fac407f6 (diff)
tg3: WOL fixes
The first hunk of this patch inverts a flag that was accidentally toggled as part of commit 0a459aac9d151c2e36ec65723b9b845b24c5cbc3 ("tg3: Allow WOL for phylib controlled Broadcom phys"). The second hunk of the patch removes the call to device_may_wakeup() in the 5906 config detection path. At the point of the call, the driver shouldn't be querying for WOL capability. It should be detecting and setting it. Signed-off-by: Matt Carlson <mcarlson@broadcom.com> Signed-off-by: Benjamin Li <benli@broadcom.com> Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/tg3.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 06bd2f4eee6c..bacbfc582704 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -2237,7 +2237,7 @@ static int tg3_set_power_state(struct tg3 *tp, pci_power_t state)
2237 } 2237 }
2238 } 2238 }
2239 } else { 2239 } else {
2240 do_low_power = false; 2240 do_low_power = true;
2241 2241
2242 if (tp->link_config.phy_is_low_power == 0) { 2242 if (tp->link_config.phy_is_low_power == 0) {
2243 tp->link_config.phy_is_low_power = 1; 2243 tp->link_config.phy_is_low_power = 1;
@@ -11544,8 +11544,7 @@ static void __devinit tg3_get_eeprom_hw_cfg(struct tg3 *tp)
11544 if (val & VCPU_CFGSHDW_ASPM_DBNC) 11544 if (val & VCPU_CFGSHDW_ASPM_DBNC)
11545 tp->tg3_flags |= TG3_FLAG_ASPM_WORKAROUND; 11545 tp->tg3_flags |= TG3_FLAG_ASPM_WORKAROUND;
11546 if ((val & VCPU_CFGSHDW_WOL_ENABLE) && 11546 if ((val & VCPU_CFGSHDW_WOL_ENABLE) &&
11547 (val & VCPU_CFGSHDW_WOL_MAGPKT) && 11547 (val & VCPU_CFGSHDW_WOL_MAGPKT))
11548 device_may_wakeup(&tp->pdev->dev))
11549 tp->tg3_flags |= TG3_FLAG_WOL_ENABLE; 11548 tp->tg3_flags |= TG3_FLAG_WOL_ENABLE;
11550 goto done; 11549 goto done;
11551 } 11550 }